From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21975 invoked by alias); 3 Apr 2014 00:11:33 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 21965 invoked by uid 89); 3 Apr 2014 00:11:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f175.google.com Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 03 Apr 2014 00:11:31 +0000 Received: by mail-vc0-f175.google.com with SMTP id lh14so1443517vcb.34 for ; Wed, 02 Apr 2014 17:11:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=qvTo133mKKB8vsDqpOS/KFRK/W1x8cGvT9d0SQymyTQ=; b=LdeKf8lyDAlaNfhtb70xySVYUkdytc9GpdfquvcVrdiTLlpK4gdju8wxO0MgjAS/eG FgZy+OCoEkHuh/U6o3bOzFs6S/mDm295jerFdQsvq/oWXb3EvJjipOttnwNKPDEZruoW K7SML6NRgMNi3LE/tp/woaoTbDV8f4oijs+WqN+/YcJvcH8HBqH4iItHfHongx/uyfDM x7abU6eNiIIKVRGV8fAY3E58rgJvRtKaT66oa2/cKrX4KE2GP8MMSaCSBCNXMvlc45wb GNGaBJEjOk+tc2yqLeEJ9ebnCGXSUthD8UV3eiUwjdMtweJdaa145nopHA1nQKHbCCdK BkRg== X-Gm-Message-State: ALoCoQkPVoJXwq+Da2tWr+RqY1DP3mrJPyzQxk8NYt+rzudZDQlsc6BwLeB3mLWgwV4oSsmSe6yAa2U+N2mstvyubMYTWspYBgtyRngfPmhVTScUpR5gMw0jB0G7XTOMARQiXyKuIkEIahi6n/+YncEcInWXzJwAKc8ieC4FRvl5y/J/vCDAbcfOXMU7XZ/wYXqIQ2HkffVoOD/EOKiG4ID0GIdhJ4KdLg== MIME-Version: 1.0 X-Received: by 10.220.159.4 with SMTP id h4mr142550vcx.1.1396483889476; Wed, 02 Apr 2014 17:11:29 -0700 (PDT) Received: by 10.52.184.202 with HTTP; Wed, 2 Apr 2014 17:11:29 -0700 (PDT) In-Reply-To: References: <20140402065443.GA18201@bubble.grove.modra.org> Date: Thu, 03 Apr 2014 00:11:00 -0000 Message-ID: Subject: Re: ICF on PowerPC Bug From: Sriraman Tallam To: Cary Coutant Cc: binutils , Ian Lance Taylor Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00030.txt.bz2 Committed with those changes. Thanks Sri On Wed, Apr 2, 2014 at 2:12 PM, Cary Coutant wrote: >> Attached patch to fix the PPC ICF problem by using references to the >> reloc info vectors. Ok to commit? > > - Icf::Sections_reachable_info v = > + Icf::Sections_reachable_info &v = > (it_reloc_info_list->second).section_info; > // Stores the information of the symbol pointed to by the reloc. > - Icf::Symbol_info s = (it_reloc_info_list->second).symbol_info; > + Icf::Symbol_info &s = (it_reloc_info_list->second).symbol_info; > // Stores the addend and the symbol value. > - Icf::Addend_info a = (it_reloc_info_list->second).addend_info; > + Icf::Addend_info &a = (it_reloc_info_list->second).addend_info; > // Stores the offset of the reloc. > - Icf::Offset_info o = (it_reloc_info_list->second).offset_info; > - Icf::Reloc_addend_size_info reloc_addend_size_info = > + Icf::Offset_info &o = (it_reloc_info_list->second).offset_info; > + Icf::Reloc_addend_size_info &reloc_addend_size_info = > (it_reloc_info_list->second).reloc_addend_size_info; > Icf::Sections_reachable_info::iterator it_v = v.begin(); > Icf::Symbol_info::iterator it_s = s.begin(); > > Except for v and a, I think these can all be const, and their > iterators can be const_iterators. OK with those changes. > > Thanks! > > -cary