* [PATCH] Disable --long-plt test for arm-nacl targets.
@ 2014-02-28 18:00 Roland McGrath
2014-03-03 6:54 ` Yury Gribov
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Roland McGrath @ 2014-02-28 18:00 UTC (permalink / raw)
To: binutils
The --long-plt switch is a no-op (and unnecessary) for arm-nacl targets.
The test case does not apply.
OK for trunk?
Thanks,
Roland
ld/testsuite/
2014-02-28 Roland McGrath <mcgrathr@google.com>
* ld-arm/arm-elf.exp (armelftests_common): Move long-plt case ...
(armelftests_nonacl): ... here.
--- a/ld/testsuite/ld-arm/arm-elf.exp
+++ b/ld/testsuite/ld-arm/arm-elf.exp
@@ -188,10 +188,6 @@ set armelftests_common {
"" {exec-got-1b.s}
{{readelf --relocs exec-got-1.d}}
"exec-got-1"}
- {"Long PLT entries in executables" "--long-plt -shared
--section-start=.plt=0x200 --section-start=.got=0xf0000300" ""
- "" {long-plt-format.s}
- {{objdump "-d -j .plt" long-plt-format.d}}
- "long-plt-format"}
{"abs call" "-T arm.ld" "" "" {abs-call-1.s}
{{objdump -d abs-call-1.d}}
"abs-call-1"}
@@ -460,6 +456,10 @@ set armelftests_nonacl {
{objdump {-s -j.data -j.got} ifunc-17.gd}
{readelf -r ifunc-17.rd}}
"ifunc-17"}
+ {"Long PLT entries in executables" "--long-plt -shared
--section-start=.plt=0x200 --section-start=.got=0xf0000300" ""
+ "" {long-plt-format.s}
+ {{objdump "-d -j .plt" long-plt-format.d}}
+ "long-plt-format"}
}
run_ld_link_tests $armelftests_common
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Disable --long-plt test for arm-nacl targets.
2014-02-28 18:00 [PATCH] Disable --long-plt test for arm-nacl targets Roland McGrath
@ 2014-03-03 6:54 ` Yury Gribov
2014-03-03 17:47 ` Nicholas Clifton
2014-03-05 18:07 ` Roland McGrath
2 siblings, 0 replies; 6+ messages in thread
From: Yury Gribov @ 2014-03-03 6:54 UTC (permalink / raw)
To: Roland McGrath, binutils
> On 02/28/2014 09:59 PM, Roland McGrath wrote:
> The --long-plt switch is a no-op (and unnecessary) for arm-nacl targets.
> The test case does not apply.
>
> OK for trunk?
Thanks for fixing this, I support this patch (but we still need to wait
for approve from maintainer).
-Y
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Disable --long-plt test for arm-nacl targets.
2014-02-28 18:00 [PATCH] Disable --long-plt test for arm-nacl targets Roland McGrath
2014-03-03 6:54 ` Yury Gribov
@ 2014-03-03 17:47 ` Nicholas Clifton
2014-03-05 18:07 ` Roland McGrath
2 siblings, 0 replies; 6+ messages in thread
From: Nicholas Clifton @ 2014-03-03 17:47 UTC (permalink / raw)
To: binutils
> ld/testsuite/
> 2014-02-28 Roland McGrath <mcgrathr@google.com>
>
> * ld-arm/arm-elf.exp (armelftests_common): Move long-plt case ...
> (armelftests_nonacl): ... here.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Disable --long-plt test for arm-nacl targets.
2014-02-28 18:00 [PATCH] Disable --long-plt test for arm-nacl targets Roland McGrath
2014-03-03 6:54 ` Yury Gribov
2014-03-03 17:47 ` Nicholas Clifton
@ 2014-03-05 18:07 ` Roland McGrath
2014-03-06 4:51 ` Yury Gribov
2 siblings, 1 reply; 6+ messages in thread
From: Roland McGrath @ 2014-03-05 18:07 UTC (permalink / raw)
To: binutils
ping? Need trivial maintainer approval.
On Fri, Feb 28, 2014 at 9:59 AM, Roland McGrath <mcgrathr@google.com> wrote:
> The --long-plt switch is a no-op (and unnecessary) for arm-nacl targets.
> The test case does not apply.
>
> OK for trunk?
>
>
> Thanks,
> Roland
>
>
> ld/testsuite/
> 2014-02-28 Roland McGrath <mcgrathr@google.com>
>
> * ld-arm/arm-elf.exp (armelftests_common): Move long-plt case ...
> (armelftests_nonacl): ... here.
>
> --- a/ld/testsuite/ld-arm/arm-elf.exp
> +++ b/ld/testsuite/ld-arm/arm-elf.exp
> @@ -188,10 +188,6 @@ set armelftests_common {
> "" {exec-got-1b.s}
> {{readelf --relocs exec-got-1.d}}
> "exec-got-1"}
> - {"Long PLT entries in executables" "--long-plt -shared
> --section-start=.plt=0x200 --section-start=.got=0xf0000300" ""
> - "" {long-plt-format.s}
> - {{objdump "-d -j .plt" long-plt-format.d}}
> - "long-plt-format"}
> {"abs call" "-T arm.ld" "" "" {abs-call-1.s}
> {{objdump -d abs-call-1.d}}
> "abs-call-1"}
> @@ -460,6 +456,10 @@ set armelftests_nonacl {
> {objdump {-s -j.data -j.got} ifunc-17.gd}
> {readelf -r ifunc-17.rd}}
> "ifunc-17"}
> + {"Long PLT entries in executables" "--long-plt -shared
> --section-start=.plt=0x200 --section-start=.got=0xf0000300" ""
> + "" {long-plt-format.s}
> + {{objdump "-d -j .plt" long-plt-format.d}}
> + "long-plt-format"}
> }
>
> run_ld_link_tests $armelftests_common
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Disable --long-plt test for arm-nacl targets.
2014-03-05 18:07 ` Roland McGrath
@ 2014-03-06 4:51 ` Yury Gribov
2014-03-06 17:45 ` Roland McGrath
0 siblings, 1 reply; 6+ messages in thread
From: Yury Gribov @ 2014-03-06 4:51 UTC (permalink / raw)
To: Roland McGrath, binutils
On 03/05/2014 10:06 PM, Roland McGrath wrote:
> ping? Need trivial maintainer approval.
What about this one:
https://sourceware.org/ml/binutils/2014-03/msg00017.html ?
-Y
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Disable --long-plt test for arm-nacl targets.
2014-03-06 4:51 ` Yury Gribov
@ 2014-03-06 17:45 ` Roland McGrath
0 siblings, 0 replies; 6+ messages in thread
From: Roland McGrath @ 2014-03-06 17:45 UTC (permalink / raw)
To: Yury Gribov; +Cc: binutils
On Wed, Mar 5, 2014 at 8:51 PM, Yury Gribov <y.gribov@samsung.com> wrote:
> On 03/05/2014 10:06 PM, Roland McGrath wrote:
>> ping? Need trivial maintainer approval.
>
> What about this one:
> https://sourceware.org/ml/binutils/2014-03/msg00017.html ?
Ah! Naughy Nick sent to the list and not to me, so I didn't see it.
Committed now.
Thanks,
Roland
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-06 17:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-28 18:00 [PATCH] Disable --long-plt test for arm-nacl targets Roland McGrath
2014-03-03 6:54 ` Yury Gribov
2014-03-03 17:47 ` Nicholas Clifton
2014-03-05 18:07 ` Roland McGrath
2014-03-06 4:51 ` Yury Gribov
2014-03-06 17:45 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).