* [PATCH 2.26 backport] PR gold/19047: Fix bug related to addend computation for MERGE sections.
@ 2016-05-05 17:07 Roland McGrath
2016-05-05 19:59 ` Cary Coutant
0 siblings, 1 reply; 5+ messages in thread
From: Roland McGrath @ 2016-05-05 17:07 UTC (permalink / raw)
To: binutils; +Cc: Sriraman Tallam
Trunk commit 8fe0f303f4d792ab581483be69d448574bbd4835 applies cleanly
to the 2.26 branch.
I'd like to push cherry-pick -x of that to the branch. It fixes 19047. OK?
Unfortunately the ChangeLog entry in the trunk fix did not mention the
bugzilla #.
Should I just leave it as it is, or should I amend the ChangeLog
message in the cherry-pick?
Thanks,
Roland
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.26 backport] PR gold/19047: Fix bug related to addend computation for MERGE sections.
2016-05-05 17:07 [PATCH 2.26 backport] PR gold/19047: Fix bug related to addend computation for MERGE sections Roland McGrath
@ 2016-05-05 19:59 ` Cary Coutant
2016-05-05 20:18 ` Roland McGrath
0 siblings, 1 reply; 5+ messages in thread
From: Cary Coutant @ 2016-05-05 19:59 UTC (permalink / raw)
To: Roland McGrath; +Cc: binutils, Sriraman Tallam
> Trunk commit 8fe0f303f4d792ab581483be69d448574bbd4835 applies cleanly
> to the 2.26 branch.
> I'd like to push cherry-pick -x of that to the branch. It fixes 19047. OK?
>
> Unfortunately the ChangeLog entry in the trunk fix did not mention the
> bugzilla #.
> Should I just leave it as it is, or should I amend the ChangeLog
> message in the cherry-pick?
OK. Yes, please do fix the ChangeLog entry. Thanks!
-cary
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.26 backport] PR gold/19047: Fix bug related to addend computation for MERGE sections.
2016-05-05 19:59 ` Cary Coutant
@ 2016-05-05 20:18 ` Roland McGrath
2016-05-05 20:22 ` H.J. Lu
0 siblings, 1 reply; 5+ messages in thread
From: Roland McGrath @ 2016-05-05 20:18 UTC (permalink / raw)
To: Cary Coutant; +Cc: binutils, Sriraman Tallam
I've committed it to 2.26 with "PR gold/19047" added to the ChangeLog
and the git commit log.
I've also changed 19047 to be for 2.26 rather than 2.25 (I'm the
reporter, and I don't care about a 2.25 backport), and marked it
fixed.
Thanks,
Roland
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.26 backport] PR gold/19047: Fix bug related to addend computation for MERGE sections.
2016-05-05 20:18 ` Roland McGrath
@ 2016-05-05 20:22 ` H.J. Lu
2016-05-05 20:24 ` Roland McGrath
0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2016-05-05 20:22 UTC (permalink / raw)
To: Roland McGrath; +Cc: Cary Coutant, binutils, Sriraman Tallam
On Thu, May 5, 2016 at 1:17 PM, Roland McGrath <mcgrathr@google.com> wrote:
> I've committed it to 2.26 with "PR gold/19047" added to the ChangeLog
> and the git commit log.
> I've also changed 19047 to be for 2.26 rather than 2.25 (I'm the
> reporter, and I don't care about a 2.25 backport), and marked it
> fixed.
It is wrong to say that PR 19047 is fixed in 2.26 release.
--
H.J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.26 backport] PR gold/19047: Fix bug related to addend computation for MERGE sections.
2016-05-05 20:22 ` H.J. Lu
@ 2016-05-05 20:24 ` Roland McGrath
0 siblings, 0 replies; 5+ messages in thread
From: Roland McGrath @ 2016-05-05 20:24 UTC (permalink / raw)
To: H.J. Lu; +Cc: Cary Coutant, binutils, Sriraman Tallam
On Thu, May 5, 2016 at 1:22 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> It is wrong to say that PR 19047 is fixed in 2.26 release.
I don't think I said that. Bugzilla now shows 19047 as reported as a
bug in the 2.26 release, and as now fixed (meaning it's fixed on the
2.26 branch). Is there a convention for bugzilla states that I've
violated?
Thanks,
Roland
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-05 20:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-05 17:07 [PATCH 2.26 backport] PR gold/19047: Fix bug related to addend computation for MERGE sections Roland McGrath
2016-05-05 19:59 ` Cary Coutant
2016-05-05 20:18 ` Roland McGrath
2016-05-05 20:22 ` H.J. Lu
2016-05-05 20:24 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).