* Offering enhancement to 'strings'
@ 2011-07-26 1:19 Ralf Brown
2011-07-27 18:31 ` Richard Sandiford
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Brown @ 2011-07-26 1:19 UTC (permalink / raw)
To: binutils
I've added support for UTF-8 and EUC encodings to the strings(1) code,
and would like to contribute the changes back to the FSF. I'm willing
to sign a copyright assignment.
I saved multiple checkpoints during the update, so I can offer a
series of incremental patches starting with the CVS version as of the
morning of 2011-07-25:
Patch 1: Simple refactoring to move the actual reading of bytes from
get_char() into its own function get_byte(), as we will be using this
code multiple times.
Patch 2: Move the decision of whether a character is a desired
graphical character into get_char() and adjust print_strings()
accordingly.
Patch 3: Enhance the character-handling code in print_strings() to
deal with multi-byte characters.
Patch 4: Add UTF-8 processing to get_char() and add new 'u' encoding
type in main().
Patch 5: Add baseline EUC processing to get_char() and add new 'e'
encoding type in main().
I look forward to hearing from you.
Ralf Brown
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Offering enhancement to 'strings'
2011-07-26 1:19 Offering enhancement to 'strings' Ralf Brown
@ 2011-07-27 18:31 ` Richard Sandiford
0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2011-07-27 18:31 UTC (permalink / raw)
To: Ralf Brown; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
Ralf Brown <ralf.brown@gmail.com> writes:
> I've added support for UTF-8 and EUC encodings to the strings(1) code,
> and would like to contribute the changes back to the FSF. I'm willing
> to sign a copyright assignment.
Sounds like a really useful extension, thanks. The patch split
looks good too.
Like you say, a copyright assignment would be needed for a contribution
of this size. I've attached the form, in case you don't already have
a copy.
Thanks,
Richard
[-- Attachment #2: request-assign.future --]
[-- Type: application/octet-stream, Size: 971 bytes --]
Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.
Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES
[What is the name of the program or package you're contributing to?]
[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]
[Do you have an employer who might have a basis to claim to own
your changes? Do you attend a school which might make such a claim?]
[For the copyright registration, what country are you a citizen of?]
[What year were you born?]
[Please write your email address here.]
[Please write your postal address here.]
[Which files have you changed so far, and which new files have you written
so far?]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-27 18:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-26 1:19 Offering enhancement to 'strings' Ralf Brown
2011-07-27 18:31 ` Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).