From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id B42B53858CDB for ; Thu, 4 May 2023 17:33:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B42B53858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2ac826a1572so5049421fa.0 for ; Thu, 04 May 2023 10:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683221617; x=1685813617; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LhCtU4I7RP/Wa+x6XUm7fOeM+kNYgDwqgjPna8tKO5E=; b=Dg0ZWlZwUwAPbJcjPb00MOVVQ0kDZVUrenGxA6D//jR8QmHexMs5kEMOgLxIwzqktv P/sRrDob+s7/cUqKrZ37GhjVhVuzC4QqEHLy1xB4XiS+8p29qAcC767TGCSVnoBduj3t h2p98LmqiZsgTAECxLKE8BUN2GwIf3cYsjQySJvsxiBZTV1H0gRAHmaoYV1t6WmTWjFd Pt3bLx07fpSiVBMIaSOfbzEAhlVUQx2F4yqDOQeck/tY0tyld37XQsZmFRyNX49v+OE8 9Cy52ZY3npbgUUhznFzYBQ6Bc9ehpDrl+DjJjnW0Tig74snLEWlRDqgaFG5fz4PAJx0e zWGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683221617; x=1685813617; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LhCtU4I7RP/Wa+x6XUm7fOeM+kNYgDwqgjPna8tKO5E=; b=TRLLyvhzhERqxG+aK5MLJgZN4cRlYpjeegRLhbQ/jNmjGYq8IXTTlscPyFRX1fKg+Z 43uBoyudz5ekncXyUHc5eEaEbDqwiaAO0arK5cSAYAuarExbmJ0pPAcm2Rs5ayFRGSpU 89isnP0y8aECb3W+sVfjdor1ipxTtycHUZzCATPXsnJleywF7plTNo0ZCbZvkgETPZhc e2krxhM4oZD2tKcC95MRLpHG7acipEl7+b3xUsKbzXcO7vS2Al5/vW9QrZKYjKFVnvSn EORB8ByBNHSspb4yYa7mYjB9hybiQxWgqcNzMrtdqNoXBWkuBSOkLyL77z/jMhgX0+BU 3tCA== X-Gm-Message-State: AC+VfDwc+Ady1fj1NeGyspE+h6aepDJuvMc9ZW+hPd0kiqkTaD1me/Lz Wcue9D8sc1Dxzwx8Eof17TaA5bU1Zw5vmOrKmItxpAQ9 X-Google-Smtp-Source: ACHHUZ5Xc4teoxWu3NsowRpob8alUo9rtna/2Ne5IhYmTo1ZDJmyM4bhVKKeXzZ0DPBl/Mh70nfptcAx21yWBg1iNsA= X-Received: by 2002:a2e:3109:0:b0:2a8:bade:e382 with SMTP id x9-20020a2e3109000000b002a8badee382mr1063971ljx.9.1683221616951; Thu, 04 May 2023 10:33:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Oleg Tolmatcev Date: Thu, 4 May 2023 19:33:25 +0200 Message-ID: Subject: Re: [PATCH] optimize handle_COMDAT To: Alan Modra Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Do., 4. Mai 2023 um 06:11 Uhr schrieb Alan Modra : > > On Sat, Apr 29, 2023 at 02:39:00PM +0200, Oleg Tolmatcev via Binutils wrote: > > Thanks for the review. Here is a new version. > > The patch you posted to the list is truncated, and the patch you sent > me privately was somehow corrupted, with tabs being replaced with 4 > spaces and the single space lines in the patch being replaced with an > empty line. Please fix your email client and/or editor. I applied it > by hand, and found > > FAIL: Build pe-x86-64-1 > FAIL: Build pe-x86-64-2 > FAIL: Build pe-x86-64-3 > FAIL: Build pe-x86-64-6 > > when running the testsuite on an x86_64-linux build. This is not > acceptable. I also see you have ripped out more than just a little > sanity checking and other code you didn't understand. Do you expect > Nick or I to fix your patches for you? Thanks for the review Alan. No I do not. It is my first time trying to contribute, which is why I made mistakes. I am sorry.