From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 7F3623858D33 for ; Wed, 3 May 2023 18:10:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F3623858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2ac78bb48eeso5628141fa.1 for ; Wed, 03 May 2023 11:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683137425; x=1685729425; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k8mnxBkL/xynuVM1PxB1cKwIlJdeUC5qx+PskhctDzQ=; b=jAFM+3Ij+J1mbLEnam6COKCnasVMNmWHyRV/s5iWe5Htq9HzPewbKd89XZMuRUiaiq vGrHC3EHfGuHAVbWzz4nBzBQb2KK03C1vB3ffx5w0FW7r9sXcgQ2/i7S4Py6NxzAteTo l2TgyBqt88JXuNVRa5MMxnxG1cqfJWZhAHaE2SPJNkF0W3kKLoZudRs5TlgSQTRLdTjx knlK3f5y+qgSuAjn2pXJ8gXC5LHNXQQ6mrJlltzoabcPXVkGF/NXSrW9+PhRuFE4adXD LzONzvdp+RSvN4022B/FyPaXH2YJukyL3RA2M/Z8ktoqbbKDIQaP0932oFZx1rbLiYM+ vrcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683137425; x=1685729425; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k8mnxBkL/xynuVM1PxB1cKwIlJdeUC5qx+PskhctDzQ=; b=YsdrIke1P4icy8wLQOm3EoK+y46Jv8bRUiP+m/WXKLtM/NBXKsBkBnR0StTRKRvVXF TzM7AQVRkdS8qr+1Hi8BZi5kDr8nyJeDiiUsMmpNXb5adq4H8L0yAEl5uTiqGkhxfM+n lh2f2yYm4KrUfPd83cC27quWFIELboW87gGhWQUbnwByGMfYpQU3EJBnb2Fs707Jzg0S L1ZX8RaZX92rb6ioqX586/L1/QMNCo0FW5W30DzrW6fNRGTuWUF7IIO/UXrQrFlAVuxy Z+GYmUJiRYRcQEyPbhIKmGbSzayzzi2L/4DfTeNYX/nL7pValojDJMIyxg6iu8rJ2aEC rJEQ== X-Gm-Message-State: AC+VfDzNoc0WVdZfMKmQUjzjkEyRD7f7KIHDpcLrKp+BUUJ5v1aU7IwX hAfDAYikH0LGwaXJF0o5ZdNvpbnKbrLgA+WbDXfXM7uC X-Google-Smtp-Source: ACHHUZ51bzsZtHAESrYhrVcuZNIJ2ilz0oeOBea6lhxdOhkZ2uz+BbNNVj5SVKYjtKKbq0tLBAXHREZKb//nSLtHZ7Y= X-Received: by 2002:a05:651c:c9:b0:2a8:b7e9:82ee with SMTP id 9-20020a05651c00c900b002a8b7e982eemr223951ljr.1.1683137424684; Wed, 03 May 2023 11:10:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Oleg Tolmatcev Date: Wed, 3 May 2023 20:10:13 +0200 Message-ID: Subject: Re: [PATCH] make coff_compute_checksum faster To: Nick Clifton Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Mi., 3. Mai 2023 um 16:39 Uhr schrieb Nick Clifton : > > Hi Oleg, > > > This makes linking faster by reading 8 MB of data at once instead of > > reading 2 bytes at once. This drastically reduces the number of system > > calls. > > Thanks very much. I have applied your patch with one small change: > > > + buf = (unsigned char *)bfd_malloc (0x800000); > > I replaced the use of a magic number in the malloc, and subsequent > read, with a #define'd value: > > buf = (unsigned char *) bfd_malloc (COFF_CHECKSUM_BUFFER_SIZE); > > It just makes it easier to change the buffer size, should that > become needed in the future. > > Cheers > Nick Thank you, Nick.