From: Han Shen <shenhan@google.com>
To: Cary Coutant <ccoutant@gmail.com>
Cc: binutils <binutils@sourceware.org>,
Luis Lozano <llozano@google.com>,
Bhaskar <bjanakiraman@google.com>
Subject: Re: [gold][aarch64] Patch for erratum-843419 (2 of 2 - fix erratum occurrences)
Date: Thu, 11 Jun 2015 21:05:00 -0000 [thread overview]
Message-ID: <CACkGtrhZ9z6KYfGnzzfo24T-zyur-_QNbsj20XjOsZD1Xfj1Vw@mail.gmail.com> (raw)
In-Reply-To: <CAJimCsGBBzwrEZHdXji21TohfDd+pYOe8N7sHAuAVW-Ng2Ht_g@mail.gmail.com>
Hi Cary, thanks for fixing this. I shall do an debug(-O0) build next time.
-Han
On Thu, Jun 11, 2015 at 1:25 PM, Cary Coutant <ccoutant@gmail.com> wrote:
> With your last patch, gold won't build at -O0, because the
> declarations of "static const int STUB_ADDR_ALIGN" need to be made
> outside the class body. I've committed the attached patch to move
> these initializations out of the class body.
>
> -cary
>
>
> 2015-06-11 Cary Coutant <ccoutant@gmail.com>
>
> gold/
> * aarch64.cc (Erratum_stub::STUB_ADDR_ALIGN): Move initialization
> outside class body.
> (Reloc_stub::STUB_ADDR_ALIGN): Likewise.
--
Han Shen | Software Engineer | shenhan@google.com | +1-650-440-3330
prev parent reply other threads:[~2015-06-11 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 18:20 Han Shen
2015-06-01 21:39 ` Cary Coutant
2015-06-05 18:50 ` Han Shen
2015-06-10 6:15 ` Cary Coutant
[not found] ` <CACkGtrjvQ67aQau4yDWnF0rOuKLsBgQU5MdXCh_f56Wvb8s5mg@mail.gmail.com>
2015-06-11 20:25 ` Cary Coutant
2015-06-11 21:05 ` Han Shen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACkGtrhZ9z6KYfGnzzfo24T-zyur-_QNbsj20XjOsZD1Xfj1Vw@mail.gmail.com \
--to=shenhan@google.com \
--cc=binutils@sourceware.org \
--cc=bjanakiraman@google.com \
--cc=ccoutant@gmail.com \
--cc=llozano@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).