Thanks for your feedback Jan. Yes, I understand that one option for a single newline smells fulsome but the idea is to use it to mark the end of output when addr2line is used as a "server" process: right now I see only the "-i" use case, but there could be others in the future for new options. Said that I would propose adding the "add-newline" long option only to trivially add a new line, that could be reused for other output. What do you think? Maurizio On Mon, Jan 9, 2023 at 5:17 PM Jan Beulich wrote: > On 09.01.2023 17:04, Maurizio Papini via Binutils wrote: > > Do you think this should go through an RFC? Do you have any thoughts? > > Well, I'm of two minds here, which so far kept me from responding: On one > hand an option that's useful to someone is probably a good thing. Otoh an > option to control a single newline character seems a little too fine > grained to me. Plus I'm a little concerned of burning a short option for > this (niche?) issue. Since you say it's specifically an issue with -i, > would it be an option to add a long-only option providing the intended > variant of behavior, i.e. combining what would (aiui) be "-i -n" with the > current proposal? > > Jan > > > On Mon, Dec 19, 2022 at 2:53 PM Maurizio Papini > wrote: > > > >> This series adds a new option to addr2line (-n) to append a newline > >> after the last informative one. > >> > >> This new option is helpful for using a running addr2line process and > >> performing queries, in particular when the option -i is requested: the > >> additional empty line can be used to mark the end of the inlined > functions > >> lists so that an application can get the output without defining a > timeout. > >> > >> The first patch adds the new option while the second one adds the > relative > >> test. > >> > >> Let me know what you think. > >> > >> Maurizio > >> > >> > >> Maurizio Papini (2): > >> addr2line: new option -n to add a newline at the end > >> addr2line: test to check -n option > >> > >> binutils/addr2line.c | 11 +++++++++-- > >> binutils/doc/binutils.texi | 5 +++++ > >> binutils/testsuite/binutils-all/addr2line.exp | 10 ++++++++++ > >> 3 files changed, 24 insertions(+), 2 deletions(-) > >> > >> -- > >> 2.38.1 > >> > >> > >