From: Denis Chertykov <chertykov@gmail.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: binutils@sourceware.org, Eric Weddington <eric.weddington@atmel.com>
Subject: Re: Ping: [RFC,Patch,AVR]: ad PR13503: Add new relocs to TC_VALIDATE_FIX?
Date: Tue, 28 Aug 2012 02:53:00 -0000 [thread overview]
Message-ID: <CADOs=zaMZt3Xny0uXwdXjsH9pD2DXdpf61dwfxvGkO4Sh42r3Q@mail.gmail.com> (raw)
In-Reply-To: <503A6547.7010901@gjlay.de>
2012/8/26 Georg-Johann Lay <avr@gjlay.de>:
> Just a ping for
>
> http://sourceware.org/ml/binutils/2012-08/msg00270.html
>
>> Hi, in gas/config/tc-avr.h there is the following comment
>> to TC_VALIDATE_FIX:
>>
>> /* We don't want gas to fixup the following program memory related
>> relocations.
>> We will need them in case that we want to do linker relaxation.
>> We could in principle keep these fixups in gas when not relaxing.
>> However, there is no serious performance penilty when making the linker
>> make the fixup work. Check also that fx_addsy is not NULL, in order to
>> make
>> sure that the fixup refers to some sort of lable. */
>>
>> PR13503 introduced new relocs that are not mentioned in TC_VALIDATE_FIX.
>>
>> The attached patch adds the new BFD_RELOC_AVR_8_LO, BFD_RELOC_AVR_8_HI,
>> BFD_RELOC_AVR_8_HLO to that exclude list.
>>
>> I cannot say if these new relocs need to be handled there, if the must
>> be handled there or must *not* be handled there. I just noticed that
>> the new relocs are missing there, but no clue if that's good or bad or
>> simply does not matter...
>>
>> Thus please review this patch. And in the case it is actually needed,
>> please apply it.
>>
>>
>> Johann
>>
>>
>> gas/
>> PR 13503
>> * config/tc-avr.h (TC_VALIDATE_FIX): Skip: BFD_RELOC_AVR_8_LO,
>> BFD_RELOC_AVR_8_HI, BFD_RELOC_AVR_8_HLO.
>>
>
Seems right, but I don't remember some BFD nuances.
Denis.
next prev parent reply other threads:[~2012-08-27 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 7:57 Georg-Johann Lay
2012-08-26 20:42 ` Ping: " Georg-Johann Lay
2012-08-28 2:53 ` Denis Chertykov [this message]
2012-09-07 20:27 ` Georg-Johann Lay
2012-09-11 17:02 ` Denis Chertykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADOs=zaMZt3Xny0uXwdXjsH9pD2DXdpf61dwfxvGkO4Sh42r3Q@mail.gmail.com' \
--to=chertykov@gmail.com \
--cc=avr@gjlay.de \
--cc=binutils@sourceware.org \
--cc=eric.weddington@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).