From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31443 invoked by alias); 27 Aug 2012 07:54:46 -0000 Received: (qmail 31434 invoked by uid 22791); 27 Aug 2012 07:54:44 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ey0-f169.google.com (HELO mail-ey0-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Aug 2012 07:54:31 +0000 Received: by eaaf11 with SMTP id f11so1136093eaa.0 for ; Mon, 27 Aug 2012 00:54:30 -0700 (PDT) Received: by 10.14.203.73 with SMTP id e49mr16499736eeo.27.1346054070439; Mon, 27 Aug 2012 00:54:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.101.13 with HTTP; Mon, 27 Aug 2012 00:54:10 -0700 (PDT) In-Reply-To: <503A6547.7010901@gjlay.de> References: <502B43D1.5040506@gjlay.de> <503A6547.7010901@gjlay.de> From: Denis Chertykov Date: Tue, 28 Aug 2012 02:53:00 -0000 Message-ID: Subject: Re: Ping: [RFC,Patch,AVR]: ad PR13503: Add new relocs to TC_VALIDATE_FIX? To: Georg-Johann Lay Cc: binutils@sourceware.org, Eric Weddington Content-Type: text/plain; charset=UTF-8 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00464.txt.bz2 2012/8/26 Georg-Johann Lay : > Just a ping for > > http://sourceware.org/ml/binutils/2012-08/msg00270.html > >> Hi, in gas/config/tc-avr.h there is the following comment >> to TC_VALIDATE_FIX: >> >> /* We don't want gas to fixup the following program memory related >> relocations. >> We will need them in case that we want to do linker relaxation. >> We could in principle keep these fixups in gas when not relaxing. >> However, there is no serious performance penilty when making the linker >> make the fixup work. Check also that fx_addsy is not NULL, in order to >> make >> sure that the fixup refers to some sort of lable. */ >> >> PR13503 introduced new relocs that are not mentioned in TC_VALIDATE_FIX. >> >> The attached patch adds the new BFD_RELOC_AVR_8_LO, BFD_RELOC_AVR_8_HI, >> BFD_RELOC_AVR_8_HLO to that exclude list. >> >> I cannot say if these new relocs need to be handled there, if the must >> be handled there or must *not* be handled there. I just noticed that >> the new relocs are missing there, but no clue if that's good or bad or >> simply does not matter... >> >> Thus please review this patch. And in the case it is actually needed, >> please apply it. >> >> >> Johann >> >> >> gas/ >> PR 13503 >> * config/tc-avr.h (TC_VALIDATE_FIX): Skip: BFD_RELOC_AVR_8_LO, >> BFD_RELOC_AVR_8_HI, BFD_RELOC_AVR_8_HLO. >> > Seems right, but I don't remember some BFD nuances. Denis.