From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21813 invoked by alias); 29 Mar 2014 05:55:23 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 21802 invoked by uid 89); 29 Mar 2014 05:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f170.google.com Received: from mail-yk0-f170.google.com (HELO mail-yk0-f170.google.com) (209.85.160.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 29 Mar 2014 05:55:19 +0000 Received: by mail-yk0-f170.google.com with SMTP id 9so4438331ykp.15 for ; Fri, 28 Mar 2014 22:55:17 -0700 (PDT) X-Received: by 10.236.160.67 with SMTP id t43mr17552325yhk.11.1396072517504; Fri, 28 Mar 2014 22:55:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.196.7 with HTTP; Fri, 28 Mar 2014 22:54:57 -0700 (PDT) In-Reply-To: References: From: Denis Chertykov Date: Sat, 29 Mar 2014 05:55:00 -0000 Message-ID: Subject: Re: [patch,avr] device specific instruction support for avr devices To: "S, Pitchumani" Cc: "binutils@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-03/txt/msg00308.txt.bz2 2014-03-27 9:07 GMT+04:00 S, Pitchumani : >> -----Original Message----- >> From: Denis Chertykov [mailto:chertykov@gmail.com] >> Sent: Tuesday, March 25, 2014 10:37 PM >> To: S, Pitchumani >> Cc: binutils@sourceware.org >> Subject: Re: [patch,avr] device specific instruction support for avr >> devices >> >> 2014-03-24 12:23 GMT+04:00 S, Pitchumani : >> >> -----Original Message----- >> >> From: binutils-owner@sourceware.org [mailto:binutils- >> owner@sourceware.org] >> >> On Behalf Of S, Pitchumani >> >> Sent: Monday, March 03, 2014 11:21 AM >> >> To: binutils@sourceware.org >> >> Cc: chertykov@gmail.com >> >> Subject: [patch,avr] device specific instruction support for avr >> devices >> >> >> >> Hi, >> >> >> >> Few AVR Xmega devices have specific instruction support than the >> >> architecture >> >> it belongs to. For example atxmega128b1 device has RMW instructions >> >> (XCH,LAC, >> >> LAS and LAT) support, but not all avrxmega6 devices have. >> >> >> >> Now, avr-gcc passes architecture name to assembler instead of device >> name. >> >> So, >> >> RMW instructions are not recognized (illegal opcode error) by >> assembler. >> >> >> >> I have attached a patch to address this issue in assembler. >> >> - It adds a option '-mrmw' to assembler. >> >> - Based on -mrmw option device specific instructions are added to >> current >> >> instruction set (mcu_types[i].isa | AVR_ISA_RMW) >> >> Now assembler can recognize rmw instructions for respective devices. >> >> >> >> It is necessary to update gcc to pass -mrmw option to assembler if the >> >> selected device has rmw instructions. I'll send a patch for gcc as >> well. >> >> >> >> Please review the attached patch and give your suggestions. >> > >> > Hi, >> > >> > I have updated the patch to include -mrmw option to binutils. >> >> Where is the patch ? >> >> Denis. > > > Sorry, now I have attached the patch. > > Regards, > Pitchumani > > gas/ChangeLog > 2014-03-27 Pitchumani Sivanupandi > > * config/tc-avr.c: Add specified_mcu variable for selected mcu. > (enum options): add OPTION_ISA_RMW for -mrmw option. > (struct option md_longopts): Add mrmw option. > (md_show_usage): add -mrmw option description. > (md_parse_option): Update isa details if -mrmw option specified. > * doc/c-avr.texi: Add doc for new option -mrmw. > > gas/testsuite/ChangeLog > 2014-02-27 Pitchumani Sivanupandi > > * gas/avr/avr.exp: Run new tests for avr target. > * gas/avr/rmw.d: Add test for additional ISA support. > * gas/avr/rmw.s: Ditto. Committed. Denis.