public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Gregory Fong <gregory.0xf0@gmail.com>
To: binutils@sourceware.org
Cc: Roland McGrath <mcgrathr@google.com>
Subject: [PATCH] gas: delete unnecessary skip of whitespace
Date: Thu, 17 Oct 2013 22:27:00 -0000	[thread overview]
Message-ID: <CADtm3G4dkiGeABjjotJZRxeBgDH0WRQkVHc6uisCb5CSYZQukg@mail.gmail.com> (raw)

Was going through fixes for PR14887 and PR14987 and noticed that
there's a whitespace skip that was made unnecessary by
https://sourceware.org/ml/binutils-cvs/2013-06/msg00107.html .

This is pretty minor and could probably just be worked into a larger
cleanup changeset if there are plans for that in the near future.

Checked for regression by running the testsuite.

Regards,

Gregory


gas/
        * config/tc-arm.c (parse_address_main) Delete skip of whitespace
        here as it is no longer needed.

--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -5175,9 +5175,6 @@ parse_address_main (char **str, int i, int
group_relocations,
       return PARSE_OPERAND_SUCCESS;
     }

-  /* PR gas/14887: Allow for whitespace after the opening bracket.  */
-  skip_whitespace (p);
-
   if ((reg = arm_reg_parse (&p, REG_TYPE_RN)) == FAIL)
     {
       inst.error = _(reg_expected_msgs[REG_TYPE_RN]);

             reply	other threads:[~2013-10-17 22:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 22:27 Gregory Fong [this message]
2013-10-17 22:34 ` Gregory Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADtm3G4dkiGeABjjotJZRxeBgDH0WRQkVHc6uisCb5CSYZQukg@mail.gmail.com \
    --to=gregory.0xf0@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=mcgrathr@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).