[PATCH] gas: delete unnecessary skip of whitespace

[PATCH] gas: delete unnecessary skip of whitespace

[Gregory Fong]

Was going through fixes for PR14887 and PR14987 and noticed that
there's a whitespace skip that was made unnecessary by
https://sourceware.org/ml/binutils-cvs/2013-06/msg00107.html .

This is pretty minor and could probably just be worked into a larger
cleanup changeset if there are plans for that in the near future.

Checked for regression by running the testsuite.

Regards,

Gregory


gas/
        * config/tc-arm.c (parse_address_main) Delete skip of whitespace
        here as it is no longer needed.

--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -5175,9 +5175,6 @@ parse_address_main (char **str, int i, int
group_relocations,
       return PARSE_OPERAND_SUCCESS;
     }

-  /* PR gas/14887: Allow for whitespace after the opening bracket.  */
-  skip_whitespace (p);
-
   if ((reg = arm_reg_parse (&p, REG_TYPE_RN)) == FAIL)
     {
       inst.error = _(reg_expected_msgs[REG_TYPE_RN]);

Re: [PATCH] gas: delete unnecessary skip of whitespace

[Gregory Fong]

On Thu, Oct 17, 2013 at 3:26 PM, Gregory Fong <gregory.0xf0@gmail.com> wrote:
> Was going through fixes for PR14887 and PR14987 and noticed that
> there's a whitespace skip that was made unnecessary by
> https://sourceware.org/ml/binutils-cvs/2013-06/msg00107.html .
>
> This is pretty minor and could probably just be worked into a larger
> cleanup changeset if there are plans for that in the near future.
>
> Checked for regression by running the testsuite.
>

Sorry, accidentally let gmail butcher that patch.  This should be better:

gas/
        * config/tc-arm.c (parse_address_main) Delete skip of whitespace
        here as it is no longer needed.

--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -5175,9 +5175,6 @@ parse_address_main (char **str, int i, int group_rel
       return PARSE_OPERAND_SUCCESS;
     }

-  /* PR gas/14887: Allow for whitespace after the opening bracket.  */
-  skip_whitespace (p);
-
   if ((reg = arm_reg_parse (&p, REG_TYPE_RN)) == FAIL)
     {
       inst.error = _(reg_expected_msgs[REG_TYPE_RN]);