From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2892 invoked by alias); 17 Oct 2013 22:34:20 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 2881 invoked by uid 89); 17 Oct 2013 22:34:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f171.google.com Received: from mail-vc0-f171.google.com (HELO mail-vc0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 17 Oct 2013 22:34:19 +0000 Received: by mail-vc0-f171.google.com with SMTP id lf12so26354vcb.30 for ; Thu, 17 Oct 2013 15:34:17 -0700 (PDT) X-Received: by 10.52.22.110 with SMTP id c14mr43338vdf.28.1382049257364; Thu, 17 Oct 2013 15:34:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.174.71 with HTTP; Thu, 17 Oct 2013 15:33:47 -0700 (PDT) In-Reply-To: References: From: Gregory Fong Date: Thu, 17 Oct 2013 22:34:00 -0000 Message-ID: Subject: Re: [PATCH] gas: delete unnecessary skip of whitespace To: binutils@sourceware.org Cc: Roland McGrath Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00255.txt.bz2 On Thu, Oct 17, 2013 at 3:26 PM, Gregory Fong wrote: > Was going through fixes for PR14887 and PR14987 and noticed that > there's a whitespace skip that was made unnecessary by > https://sourceware.org/ml/binutils-cvs/2013-06/msg00107.html . > > This is pretty minor and could probably just be worked into a larger > cleanup changeset if there are plans for that in the near future. > > Checked for regression by running the testsuite. > Sorry, accidentally let gmail butcher that patch. This should be better: gas/ * config/tc-arm.c (parse_address_main) Delete skip of whitespace here as it is no longer needed. --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -5175,9 +5175,6 @@ parse_address_main (char **str, int i, int group_rel return PARSE_OPERAND_SUCCESS; } - /* PR gas/14887: Allow for whitespace after the opening bracket. */ - skip_whitespace (p); - if ((reg = arm_reg_parse (&p, REG_TYPE_RN)) == FAIL) { inst.error = _(reg_expected_msgs[REG_TYPE_RN]);