From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id E7BF6386D61B for ; Thu, 15 Feb 2024 21:44:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7BF6386D61B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E7BF6386D61B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::82e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708033463; cv=none; b=PRt1gvI2dCMC7tSRmeGy+z3GxdoAoG4ij/H9HtrOvWvgE+a9ffcstnYayGjgxIdILFRD2ZB3ZkZ5u6Ed94zTqMYBc1AG2P3thI9Dv/KDvO/ADjtBo+xmRRnru+0DgperMvd364ZpSw/rBOGsFV4ibz5M1uZ2UbddeUV/zWnsE0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708033463; c=relaxed/simple; bh=ahW3KzSmB/nOltC/E7Tt7+no4DmKAkhhIbWtOY2lqEw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=gAgoa98dRqJUZ8jirnP/zwmuWE3To5xkkcw5qQb4EbijHdo1Eivx70sUs/gc88VKSRxbFqQlpCMyJXGg9zUQBgp/cLklRXBglMeH1yyTlzACKQ8tQyzazofJ/CqFSiejzFWZ1gR+MZP0fy4QMMiOT8F7k1uLBycS7EfJ1uDnJik= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qt1-x82e.google.com with SMTP id d75a77b69052e-42dd9dfe170so1478181cf.1 for ; Thu, 15 Feb 2024 13:44:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20230601.gappssmtp.com; s=20230601; t=1708033461; x=1708638261; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BVE4X3S2evwxxe5PCHy2am/Tpjne2V3JKPf+Vnpo1UY=; b=lcn8mSmWWXQnHtBFFdx0EesK7x/e3JCl62D9gdZVTjJVDselRdd8uzS8YGcPoPDuDw 90gbZV0J2Y9uH0hfnearQiQsT8IX10oAf2m2RnyNFM86yNxMpdP3X21DqwDlF6PE4bfE Q9xGq7GO9FuOQXrgW4aSv1IjYvJPSsdcbSN4nq4H3bXjYO6L9c4+M0UeAc1wPBMkUQZc PRdrocFCNOzJdMbkSAqC/TqdX7d/Ki6m4dwQfh9BSlycrm0xavV+6A4C95mS7rzjHcqm fSWW6jfsMPBwX08QvVPPXCMiAaG7KXm99ozU869SvZ533dxuntSavF3WZpDdkqC+P35n vFTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708033461; x=1708638261; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BVE4X3S2evwxxe5PCHy2am/Tpjne2V3JKPf+Vnpo1UY=; b=Tb6rZ+3RH+deSlMovSFiWpS6pM+Ys1Su3RGVrBRcNLrbG2ck4tb7l+bysC7g32/7NQ voWG9Owdu+B0pmm3eJ2PIwtztINcgy47e1QItzps+IQlBe9EH5tCoSJKUZaHMVd6cFd4 J7rP355STCG28oYLwsOo6J6ZOvxZvUy4uZ7LetGUiVnyGzX3tm8hM1khrfBjiQHGL6D2 +48LkQsbC2kb7KgEvxs31U6WLk8gHmMvOLa1b/dzs8JEFrbPCucd88yDNg5slpcFmHnT kLZktBccb4/iWnWKRvcEF4KX2jYpfUZ8/tkRFW/ecaJOogGxtsmRYcHssSm1YcOxykz3 URhg== X-Forwarded-Encrypted: i=1; AJvYcCXJPauRUY9sLn2CNC7yckr0OOEAZBbToprqdnizCFah5OMCCB+Moan84f26Zrk2HPoKB1rSU84EnQZ+BHzxtJ+dHJw1ESnDRQ== X-Gm-Message-State: AOJu0YwNl+s+O3Q5Lw3WIbULp5tDrJ9IoGg+myCze7dGF4/+tbEAOF86 KjZXzxhtecVxwO19mqHC/pmINGwVbsjaO2JDqjEjirI58xqkY/EHUnM+9coPAbJrDGyWIZgChc9 nlApxkO6OT22TI642auqkMryWgPV/rKlZKSX6Ig== X-Google-Smtp-Source: AGHT+IGxm3FC4SpVjl3bdqP0rl7vyoXThSAIixYoqR9Kls4f42qBkXk5k5IF31qXecc30ls4i/pN3m81tsKMfgDIoK8= X-Received: by 2002:a0c:f594:0:b0:68d:1485:58b3 with SMTP id k20-20020a0cf594000000b0068d148558b3mr2982885qvm.22.1708033460906; Thu, 15 Feb 2024 13:44:20 -0800 (PST) MIME-Version: 1.0 References: <20240212174209.620310-1-hawkinsw@obs.cr> <20240212174209.620310-2-hawkinsw@obs.cr> <82116e8c-390b-4389-8d04-744839785f2c@redhat.com> <87jzn7nwhe.fsf@oracle.com> <87h6ibkopa.fsf@oracle.com> <87il2pivz7.fsf@oracle.com> In-Reply-To: <87il2pivz7.fsf@oracle.com> From: Will Hawkins Date: Thu, 15 Feb 2024 16:44:08 -0500 Message-ID: Subject: Re: [PATCH v2 1/1] objdump, as: Add callx support for BPF CPU v1 To: "Jose E. Marchesi" Cc: Nick Clifton , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 15, 2024 at 10:32=E2=80=AFAM Jose E. Marchesi wrote: > > > > On Wed, Feb 14, 2024 at 11:14=E2=80=AFAM Jose E. Marchesi > > wrote: > >> > >> > >> > On Wed, Feb 14, 2024 at 5:58=E2=80=AFAM Jose E. Marchesi > >> > wrote: > >> >> > >> >> > >> >> > First, as I said yesterday in my direct message to you, thank you= for > >> >> > making binutils such a pleasant place to contribute to FOSS. You = have > >> >> > no idea what that means to contributors like me! > >> >> > > >> >> > Second, thank you for this helpful critique. I really appreciated > >> >> > reading your feedback and will reply inline below (including with= an > >> >> > offer for a patch unrelated to callx that may clean up some of th= e > >> >> > non-constant uses throughout the bpf-specific code). > >> >> > > >> >> > Third, there is good news: The heavy lifting of this patch is lar= gely > >> >> > "overcome by events" -- clang/llvm developers are changing their > >> >> > encoding of the callx instruction to more closely match what gcc = does. > >> >> > In fact, v3 of this patch will look much more like v1 than v2. > >> >> > >> >> Hi Will. > >> >> > >> >> It seems to me that all we need binutils-wise is to enable the call= x > >> >> instruction with BPF >=3D v1. No other changes are necessary as fa= r as I > >> >> can see, other than adjusting the testsuite accordingly. > >> > > >> > It should be making its way across the Internet to you now! > >> > >> Thanks :) > >> > >> > The only thing ... it will probably cause a build error until a > >> > corresponding patch in the simulator lands that takes into > >> > consideration the new enum value. > >> > > >> > I am happy to handle that however you like! > >> > >> No problem. I will tackle the simulator patch in the GDB list and app= ly > >> both at almost the same time so the buildbots do not get (too) upset. > > > > Thanks!! It's been fun working on this. And, as I offered to Nick last > > night, I am more than happy to take on a little project to do a > > cleanup of the code. Just let me know if you would be open to that! > > By all means, and than you. > Improvements are always very welcome :) > > BTW, I would ask you to not include a separated cover letter for single > patches. This makes it easier to reply and quote to both the > description of the patch and its contents. Thank you! That's great feedback! I will definitely do that from now on! Will > > > > > Will > > > >> > >> > Sorry for the delay! > >> > Will > >> > > >> > > >> >> > >> >> Thanks!