From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by sourceware.org (Postfix) with ESMTPS id 711B63858D20 for ; Sat, 10 Feb 2024 06:14:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 711B63858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 711B63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707545649; cv=none; b=eToQuKGaaHU0rYdB6XDkcz3+UMcEvTap+p0wwnwQQruEEhuyWuGfKsfzcGS0csXc56tknTRaEjS7DPh3atrSp6oQT4aG6+TkSZYnSx9r8bG3VzoVxeeaGaVcCB05ZDi/usSc32/LOUu2VP6MXkS5OwTn1cYQAyZvmeCQeNbKwlc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707545649; c=relaxed/simple; bh=cGKNYM7OEERVVaZrWRyU6Y5QwiXo/7TCcgKfSsCh10E=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=qsHIPwGGw6tPUaPW2YGhEYUJNiuQRjidm543nT9m0+6U5Z4vcdHpLR6eey17msXpd0ohQjVjIYLUBt4tvWObYxZDA5GOBSHdRXCw17xphoYzqXQqB4qFsL6RpY9gf4QIqL27cGhHpv2C1aBLUrZ9Pmw6mg26io+oGLeW3s6hCYs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf29.google.com with SMTP id 6a1803df08f44-6818aa08a33so15392056d6.0 for ; Fri, 09 Feb 2024 22:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20230601.gappssmtp.com; s=20230601; t=1707545645; x=1708150445; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Anq5v5w3KhlKpozqdKBsovC4vqOqKSGN6JZn9NeAy+Y=; b=CHTU6rdsJIlTkBLoc4m+oCdTZFYX5lLjnK81Juk++LZOdskWVn/vz45uYUuTqgnfCC xttZ1ANEYzjcXBZ1UawGgaWqc2WU2he30f766c6YXI3SekLQafHu7BS34SaGYFAVIzt8 VwkGmX+04qylBLYpGYBoJhZUu/m0/YiIap0Bg5HqY9uGfx3tBPeIpxyQQBR9au5Ifojg zQR6EQbVYFlyswH1NmI7WCNRadT08j+g0vhoi0yAdWUtwuOf1ES3sCREL0ptqOLwFTUE f5TOA+UoCPEz1U/U8RyCBqAk+GxaS7iVqtMVeY9FqOnMLwDncLk5GoRKAMWs20kvgCBP 8YSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707545645; x=1708150445; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Anq5v5w3KhlKpozqdKBsovC4vqOqKSGN6JZn9NeAy+Y=; b=iGTGO6EjCbNyjSg/mqNoA/NeMAFXV64sDLE/R624eTUC6Tq6aSNS85LL9FC/uLZ0qJ Wv7v5sYGkywFgwngsIelGiQQNxf/hEBeJ8daZICeiU7JIf37I2TtEXpssJNHGfCEOur/ MBkRdu5CRrff7Wkj6fKCtkNrTsNrkRLtQEl8w1YzAKSB2aQyNAr5VWd6PtfLbAa3KxQO hW6MO6+SBQxbbqnAzWdvWTaWANZW6/wRghvNItP5c3B2qWuiBkgrgXIi5RIUCAhhP+tW 4x+d1F6qKYlOt2U7tKskgNKHbgYlVeTM7I95VUVrlHzCQkXdSL82zPAGM5LPrO6oWQN7 tUfg== X-Gm-Message-State: AOJu0YyH7dPYXZEunHYodyHuWxCYsh9IyiAA3uYUvpQP9WetS0SZQ/Hb 0vQzNZsj9TxWiC8QOq6XXTZo3f0Y3nlr2kn1fxkPTHAN4mat/05QqqSymVXBY/KKb0LJ8EKeL2Z wXp2gQPP7XSMqiPnXlGQ2fyK8jtYfAODozmAuSg== X-Google-Smtp-Source: AGHT+IG+f1Y/AARcbEbkR70xzjviYMLGk3+ZLm7ECmB7L4xwvaLFzBcCuGe/FN8EpdOXeh2jFSmF10R//vibRAmeHpE= X-Received: by 2002:a05:6214:5d8e:b0:68c:7cbb:272e with SMTP id mf14-20020a0562145d8e00b0068c7cbb272emr6543402qvb.19.1707545645731; Fri, 09 Feb 2024 22:14:05 -0800 (PST) MIME-Version: 1.0 References: <20240209180734.443763-1-hawkinsw@obs.cr> <20240209180734.443763-2-hawkinsw@obs.cr> In-Reply-To: From: Will Hawkins Date: Sat, 10 Feb 2024 01:13:55 -0500 Message-ID: Subject: Re: [PATCH 1/1] objdump: Add callx support for BPF CPU v1 To: Hans-Peter Nilsson Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 9, 2024 at 11:47=E2=80=AFPM Hans-Peter Nilsson wrote: > > On Fri, 9 Feb 2024, Will Hawkins wrote: > > > Add support for disassembling the callx instruction back to CPU v1. > > > > include/ChangeLog: > > > > * opcode/bpf.h (enum bpf_insn_id): > > > > opcodes/ChangeLog: > > > > * bpf-opc.c: > > > > ChangeLog: > > > > * sim/bpf/bpf-sim.c (execute): > > Not commenting on the rest of the patch but there's missing text > after ":" above. Beware: gcc/contrib/mklog.py doesn't help with > that part. :) > Thank you! I thought something looked suspicious but because it was what contrib/mklog.py gave me, I assumed you all had special requirements! I will fix it and resubmit. Thank you again! Will > Happy hacking! > > brgds, H-P