From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by sourceware.org (Postfix) with ESMTPS id 767F43858D20 for ; Sun, 11 Feb 2024 23:26:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 767F43858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 767F43858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707694008; cv=none; b=LYxj4pF7OufYnmndM2p4mZlHLK4NL/Y8Dp9ZLJx2a6jKwvpVIDpoepGuWVBhedRgUUH+16+psoQDTK1MvWlzvUb3Lo3fO5kn03dLOGKPeXT4LjBwENifW4+2Yb1XUVViM5ogLX51W9FXQoMd//EuhNI8fGUskzmFQwVEsNtGxUo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707694008; c=relaxed/simple; bh=pBA2PyRxjtIvpvHmPxCzQcq4Bvy+s4FxNT1cKQsbWnw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Ck8jnd4I6izq99YDxhlUNKR0ibvVnG2fh4LCmibS0LPsYgdupxHsB/Inm26XZmlg+pKl+zmOPMzA7fPm/RjY23Etw7BWMOH20oLG+61XRTsPS9Vfh/2fzoOmRtnvJ+VWzwBn5wt7vgUJHZXOBlF/fn0/Zo0hvSvHAjnu1Sw814Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-6818f3cf00aso17258136d6.0 for ; Sun, 11 Feb 2024 15:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20230601.gappssmtp.com; s=20230601; t=1707694006; x=1708298806; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tMiTGZQ2d+YUaxjZu/x6er5uin8pshXXGHHMZq3gStA=; b=c8o1QqWiIkvlonWkxPs9+cgvt45BPX/yVbMZ/n+3taSAojWUkfWnJiVlBZAacTKINE ytyEhtcg710MeJVFwfW7H5+mtWyFZN60TpJS6/wUK9XWnrBUpRdFCKhbCmxV3EtCmVXO GWYNES5RFnu6V7GDfKzjALkZd2VV8VZ//DCK2Z+TKFh/ta/I471uUIRaWU7LborA3VlN 4LdTC6n1OBJZrxcJIszljVIw9Z61BF5qcaQmGhKy1/EDkvG5rYIKC4jCfCpwu6XqgOqt qmrCKIDscq7Iyh7jK1nPPuf6rW6xrzrR+vONXsZsSH6Z6+jrEmLfCRK9E8pTz3nQ6hz9 nwQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707694006; x=1708298806; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tMiTGZQ2d+YUaxjZu/x6er5uin8pshXXGHHMZq3gStA=; b=sbTpRsDrUvb5alKPIgkmaAPAHH0ECPdhZoSyj4MMYr4a4Fz9VXwBkVjZ4VQ9sjU5ZH vl/DydJAELOAbrCBUrOzPucYGQSuEPmvC7EUi8MwIP488gwI335St5aGZlNUSNLri5iM IrbXI1WQ4U8my1VSfY8SvZkbJFMFx+QBVGA7rYUBxggwzWkBi0kaYhJN3jQ12HFE7Tcd pwwMhnjvHStjdhDZXfJ6UaLjYECQZihJ/nB/EdoAtzkBW7s+NdSnFfVcdOaAGMo5rnd/ NMCnyEkXmbqYV+/a5zFLbeSu8SjzG74/M1Yozba/ym805+AByKp+705ldRfFyAEC2VOA 8zqg== X-Gm-Message-State: AOJu0Yx+VBwEa25UaMUqmDFAp3mbpapS+h8e41s0wdL83AEUrjSA0DyI aaJymuNyB7YBQQ+C1UaIVTtgPshTpVHp9OekSOSvlXgBkBPy59MflZvrHDxTHp7z0qxz/PpZWPO ymT2HsXpkX3vQNJMr4FAe1yN62+RIXVPoa+piFeYZtvk8AYHz X-Google-Smtp-Source: AGHT+IFxl/psQc5PXdvjwRajSBgR8sThhiJLL0lhEjxl6hqsYshL2gicusXqvwUB/zgci3IPzBXt0Ny1A6CxgGF9vXg= X-Received: by 2002:ad4:5de2:0:b0:68d:12b8:4419 with SMTP id jn2-20020ad45de2000000b0068d12b84419mr1808365qvb.46.1707694005737; Sun, 11 Feb 2024 15:26:45 -0800 (PST) MIME-Version: 1.0 References: <20240209180734.443763-1-hawkinsw@obs.cr> <20240209180734.443763-2-hawkinsw@obs.cr> In-Reply-To: From: Will Hawkins Date: Sun, 11 Feb 2024 18:26:34 -0500 Message-ID: Subject: Re: [PATCH 1/1] objdump: Add callx support for BPF CPU v1 To: Hans-Peter Nilsson Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Feb 10, 2024 at 1:13=E2=80=AFAM Will Hawkins wrot= e: > > On Fri, Feb 9, 2024 at 11:47=E2=80=AFPM Hans-Peter Nilsson wrote: > > > > On Fri, 9 Feb 2024, Will Hawkins wrote: > > > > > Add support for disassembling the callx instruction back to CPU v1. > > > > > > include/ChangeLog: > > > > > > * opcode/bpf.h (enum bpf_insn_id): > > > > > > opcodes/ChangeLog: > > > > > > * bpf-opc.c: > > > > > > ChangeLog: > > > > > > * sim/bpf/bpf-sim.c (execute): > > > > Not commenting on the rest of the patch but there's missing text > > after ":" above. Beware: gcc/contrib/mklog.py doesn't help with > > that part. :) > > > > Thank you! I thought something looked suspicious but because it was > what contrib/mklog.py gave me, I assumed you all had special > requirements! I will fix it and resubmit. > > Thank you again! > Will > > Please disregard this version of the patch. I will resubmit a v2 patch soon. There is a discrepancy between the way that gcc encodes the callx (aka callr) and the way that clang encodes the callx. I am working with the author of the IETF standardization document for the BPF ISA to understand how the instruction encoding will be specified. Once that discussion has concluded, I will resubmit the patch. Sorry for the extra emails. Will > > > Happy hacking! > > > > brgds, H-P