From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by sourceware.org (Postfix) with ESMTPS id B663238582A1 for ; Wed, 14 Feb 2024 16:05:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B663238582A1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B663238582A1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707926709; cv=none; b=UzI1l+TztFujTaztjgyp8TX1oZeQsfE+BTT+FX6nm3llXVGViu06pYOUKJKfnPyEgdIbq4qOi+vO1q2LBYyG81amFAxZ8xyFGC2uMEqZzC8L6wPNFKp96SnCy/VO5FsiGp1Fx6Zwcz9zrzdvor9LALLMIdzLj76PvGIxnGDgRZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707926709; c=relaxed/simple; bh=cj9KI+C05sK/JNPg96UZ+4a5TuzPXlPvax9EX1gArKE=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=o+IRr2UqCrBFMGBiXTqRVDkpiNvitNPkrfM/vAVrLlQnRn8IdCT5A66YbZHORSJacqQ0LRXYvkANhMO6cu5sEizlpWldPIuFAQHQbW5VCq+bMkq8jYviKcHxQYbx1jfBep8DsuXp9bf7JixobL84oYYip8cdLpqCsOCMLichrgk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-6818aa08a33so9069576d6.0 for ; Wed, 14 Feb 2024 08:05:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20230601.gappssmtp.com; s=20230601; t=1707926707; x=1708531507; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M3n96gE9vvCW+XFJcToA8zEILibwmhRj7YcnYE64lds=; b=JMVNkDafCb4M8T1hg1r/uClMv0stptXidWeCYTSEtd2iR0PPZmx0CYFOB/RAcsaRJU g3h4xyjKkU/OHdgOfgAqgPoF4v8yQwkAmrOgPHk7FVIIwXWzzEWO+nTx7Pw9iWBbElkE ee24srvqtCzb492cPXp5xbFlSxhshv1p1U7G1up2XqYLBt8Eov/qBOPf1dyJU48n+ZnI 9TNGYx+vXTfxDaS6dISNPspzqrjwc6EQGI0pLsICz8wKKwOetVa4md01k7j52u2ScUoG EJ39AsMGvlJQug/ptrn5eURybnr4yB7YfN8Vi31DF948IspDuSX9Z58B/CfL4wBZt/jF QUsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707926707; x=1708531507; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M3n96gE9vvCW+XFJcToA8zEILibwmhRj7YcnYE64lds=; b=hqrnkSWBGhb2+yaJpImbP1dtqgVW+WrWEMKzxfBjE5M9g/ABpovGJ72hzBnKYpTQHs kCEBB7MeV+nBGRLDlZKEmaRKKMvzt7mOGFuMY/lHBfDWKfYvaWCbTIAj8dM899IFs8us jGMcV/DhIEb17m8SbLrzbyQSZQZ7ON/ZDVAas3ynz5QNtyWI66Ah8oxFpyurH71jY6Xj 0KFAJM3+mKOtUVx/aLT8qjSEDtJ75/2G7ZINXEY9bVfKjZ6EeQWZQ59OBDkirKkhZgVr KShWeiGr/Hi/P+Pg4+Gl1sMegM0XwXD51MwFlhJgwlXEe8r+Ez3I7jf2gkV2sVGLYJTL +TpQ== X-Forwarded-Encrypted: i=1; AJvYcCV7zSN02HNltTCcRDOOe+bOEhstC+qWxy9Ui57+qo4DT0U9esYoEo413aUClpcZ+aZ5g7JR+6g+JVdgQCagmQe9paf0sDKKyg== X-Gm-Message-State: AOJu0YyzFx4RoEAWJo4gk3qZ0K54budonaYt54lLW+84HOoDXe5HQvx+ gz7WDzbhw5ulDAivOHAq7hs9fDWcnTvFW/wovM09BWAMUUC81l7uqpngEKlgo1OKXBXCidk34Wm htyLp9LZcARSPAg+LVUMUSFa+jLOw7etjh1Hmtg3bhEOelJ9V X-Google-Smtp-Source: AGHT+IGTejjPRnI/zG0HgpR1Rg3vt0uzwbSP5PCI1uSImZfJp4fqSNdUdDB/QpsTS9ObL+nYyLU239WY5ZO79VX7xJg= X-Received: by 2002:a0c:ca92:0:b0:68c:ae6d:2abb with SMTP id a18-20020a0cca92000000b0068cae6d2abbmr3819616qvk.15.1707926707108; Wed, 14 Feb 2024 08:05:07 -0800 (PST) MIME-Version: 1.0 References: <20240212174209.620310-1-hawkinsw@obs.cr> <20240212174209.620310-2-hawkinsw@obs.cr> <82116e8c-390b-4389-8d04-744839785f2c@redhat.com> <87jzn7nwhe.fsf@oracle.com> In-Reply-To: <87jzn7nwhe.fsf@oracle.com> From: Will Hawkins Date: Wed, 14 Feb 2024 11:04:55 -0500 Message-ID: Subject: Re: [PATCH v2 1/1] objdump, as: Add callx support for BPF CPU v1 To: "Jose E. Marchesi" Cc: Nick Clifton , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 14, 2024 at 5:58=E2=80=AFAM Jose E. Marchesi wrote: > > > > First, as I said yesterday in my direct message to you, thank you for > > making binutils such a pleasant place to contribute to FOSS. You have > > no idea what that means to contributors like me! > > > > Second, thank you for this helpful critique. I really appreciated > > reading your feedback and will reply inline below (including with an > > offer for a patch unrelated to callx that may clean up some of the > > non-constant uses throughout the bpf-specific code). > > > > Third, there is good news: The heavy lifting of this patch is largely > > "overcome by events" -- clang/llvm developers are changing their > > encoding of the callx instruction to more closely match what gcc does. > > In fact, v3 of this patch will look much more like v1 than v2. > > Hi Will. > > It seems to me that all we need binutils-wise is to enable the callx > instruction with BPF >=3D v1. No other changes are necessary as far as I > can see, other than adjusting the testsuite accordingly. It should be making its way across the Internet to you now! The only thing ... it will probably cause a build error until a corresponding patch in the simulator lands that takes into consideration the new enum value. I am happy to handle that however you like! Sorry for the delay! Will > > Thanks!