public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Missing indcall-badoperand.d
@ 2024-02-20 10:35 Nick Clifton
  2024-02-20 11:05 ` Jose E. Marchesi
  0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2024-02-20 10:35 UTC (permalink / raw)
  To: hawkinsw, jose.marchesi; +Cc: binutils

Hi Will,

  Your recent commit ecd16ae4e471 appears to have omitted the new files,
  resulting in an error in the gas testsuite:
  
    ERROR: couldn't open "gas/testsuite/gas/bpf/indcall-badoperand.d": no such file or directory

  Please could you check and fix the issue ?  Thanks.

Cheers
  Nick


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Missing indcall-badoperand.d
  2024-02-20 10:35 Missing indcall-badoperand.d Nick Clifton
@ 2024-02-20 11:05 ` Jose E. Marchesi
  2024-02-20 17:52   ` Will Hawkins
  0 siblings, 1 reply; 3+ messages in thread
From: Jose E. Marchesi @ 2024-02-20 11:05 UTC (permalink / raw)
  To: Nick Clifton; +Cc: hawkinsw, binutils


> Hi Will,
>
>   Your recent commit ecd16ae4e471 appears to have omitted the new files,
>   resulting in an error in the gas testsuite:
>   
>     ERROR: couldn't open "gas/testsuite/gas/bpf/indcall-badoperand.d": no such file or directory
>
>   Please could you check and fix the issue ?  Thanks.

My fault.
Fixed as below.

commit f1efdade946d7dab958c4ecbf5feea9aba01e280 (HEAD -> master, origin/master, origin/HEAD)
Author: Jose E. Marchesi <jose.marchesi@oracle.com>
Date:   Tue Feb 20 12:03:43 2024 +0100

    bpf: gas: add missing indcall-badoperand.* test files
    
    This adds teh following files that were missing in the previous
    commit ecd16ae4e47118f66447641d93a6aa1334e550d4
    
      testsuite/gas/bpf/indcall-badoperand.d
      testsuite/gas/bpf/indcall-badoperand.l
      testsuite/gas/bpf/indcall-badoperand.s

diff --git a/gas/testsuite/gas/bpf/indcall-badoperand.d b/gas/testsuite/gas/bpf/indcall-badoperand.d
new file mode 100644
index 00000000000..bf2e9e8e643
--- /dev/null
+++ b/gas/testsuite/gas/bpf/indcall-badoperand.d
@@ -0,0 +1,3 @@
+#as: -EL -mno-relax
+#source: indcall-badoperand.s
+#error_output: indcall-badoperand.l
diff --git a/gas/testsuite/gas/bpf/indcall-badoperand.l b/gas/testsuite/gas/bpf/indcall-badoperand.l
new file mode 100644
index 00000000000..d791435a2ac
--- /dev/null
+++ b/gas/testsuite/gas/bpf/indcall-badoperand.l
@@ -0,0 +1,3 @@
+.*: Assembler messages:
+.*:7: Error: unrecognized instruction `call %0'
+.*:7: Error: expected register name, got '%0'
diff --git a/gas/testsuite/gas/bpf/indcall-badoperand.s b/gas/testsuite/gas/bpf/indcall-badoperand.s
new file mode 100644
index 00000000000..cf19c0a56b6
--- /dev/null
+++ b/gas/testsuite/gas/bpf/indcall-badoperand.s
@@ -0,0 +1,8 @@
+
+    .text
+    .align 4
+main:
+
+    mov %r0, 1
+    call %0
+    exit

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Missing indcall-badoperand.d
  2024-02-20 11:05 ` Jose E. Marchesi
@ 2024-02-20 17:52   ` Will Hawkins
  0 siblings, 0 replies; 3+ messages in thread
From: Will Hawkins @ 2024-02-20 17:52 UTC (permalink / raw)
  To: Jose E. Marchesi; +Cc: Nick Clifton, binutils

On Tue, Feb 20, 2024 at 6:06 AM Jose E. Marchesi
<jose.marchesi@oracle.com> wrote:
>
>
> > Hi Will,
> >
> >   Your recent commit ecd16ae4e471 appears to have omitted the new files,
> >   resulting in an error in the gas testsuite:
> >
> >     ERROR: couldn't open "gas/testsuite/gas/bpf/indcall-badoperand.d": no such file or directory
> >
> >   Please could you check and fix the issue ?  Thanks.
>
> My fault.
> Fixed as below.

Thank you! Sorry for causing trouble!

Sincerely,
Will


>
> commit f1efdade946d7dab958c4ecbf5feea9aba01e280 (HEAD -> master, origin/master, origin/HEAD)
> Author: Jose E. Marchesi <jose.marchesi@oracle.com>
> Date:   Tue Feb 20 12:03:43 2024 +0100
>
>     bpf: gas: add missing indcall-badoperand.* test files
>
>     This adds teh following files that were missing in the previous
>     commit ecd16ae4e47118f66447641d93a6aa1334e550d4
>
>       testsuite/gas/bpf/indcall-badoperand.d
>       testsuite/gas/bpf/indcall-badoperand.l
>       testsuite/gas/bpf/indcall-badoperand.s
>
> diff --git a/gas/testsuite/gas/bpf/indcall-badoperand.d b/gas/testsuite/gas/bpf/indcall-badoperand.d
> new file mode 100644
> index 00000000000..bf2e9e8e643
> --- /dev/null
> +++ b/gas/testsuite/gas/bpf/indcall-badoperand.d
> @@ -0,0 +1,3 @@
> +#as: -EL -mno-relax
> +#source: indcall-badoperand.s
> +#error_output: indcall-badoperand.l
> diff --git a/gas/testsuite/gas/bpf/indcall-badoperand.l b/gas/testsuite/gas/bpf/indcall-badoperand.l
> new file mode 100644
> index 00000000000..d791435a2ac
> --- /dev/null
> +++ b/gas/testsuite/gas/bpf/indcall-badoperand.l
> @@ -0,0 +1,3 @@
> +.*: Assembler messages:
> +.*:7: Error: unrecognized instruction `call %0'
> +.*:7: Error: expected register name, got '%0'
> diff --git a/gas/testsuite/gas/bpf/indcall-badoperand.s b/gas/testsuite/gas/bpf/indcall-badoperand.s
> new file mode 100644
> index 00000000000..cf19c0a56b6
> --- /dev/null
> +++ b/gas/testsuite/gas/bpf/indcall-badoperand.s
> @@ -0,0 +1,8 @@
> +
> +    .text
> +    .align 4
> +main:
> +
> +    mov %r0, 1
> +    call %0
> +    exit

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-20 17:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-20 10:35 Missing indcall-badoperand.d Nick Clifton
2024-02-20 11:05 ` Jose E. Marchesi
2024-02-20 17:52   ` Will Hawkins

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).