From: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
Christian Svensson <blue@cmd.nu>,
binutils@sourceware.org, fche@sourceware.org
Subject: Re: [RFA] fix mingw32 --enable-targets=all --enable-64-bit-bfd failure in or1k-desc.h
Date: Thu, 22 May 2014 03:30:00 -0000 [thread overview]
Message-ID: <CADzBsGPcn1qidNtKNMV12u-q=DaqxHRvX3dtSL1QzhwrXc10Rg@mail.gmail.com> (raw)
In-Reply-To: <20140520103652.GR5162@bubble.grove.modra.org>
On Tue, May 20, 2014 at 1:36 PM, Alan Modra <amodra@gmail.com> wrote:
> On Tue, May 20, 2014 at 10:50:12AM +0200, Pierre Muller wrote:
>> > On Sat, May 17, 2014 at 11:09:06PM +0200, Pierre Muller wrote:
>> > > 2014-05-17 Pierre Muller <muller@sourceware.org>
>> > >
>> > > * or1k-desc.h (enum spr_field_masks): Remove compilation warning
>> > > on 32-bit systems.
>> > >
>> > > diff --git a/opcodes/or1k-desc.h b/opcodes/or1k-desc.h
>> >
>> > No, sorry, this file is generated. If this patch is committed, it
>> > will be undone next time the file is regenerated. I suspect you'll
>> > need to poke at cgen itself to fix this problem.
>>
>> Sorry, but this goes way beyond my skills...
>> I looked a little bit in cpu/or1* files
>> and in the opcodes/cgen* files, and this seems to
>> be based on guile, which is a language I know nothing about ...
>
> I took a look, and it seems to me there is no need for enum
> spr_field_masks.. OK, Christian?
>
> cpu/
> * or1kcommon.cpu (spr-field-masks): Delete.
> opcodes/
> * or1k-desc.h: Regenerate.
>
I would prefer to fix this at the root of the problem, as we *do* use
the spr_field_mask in a soon to submitted sim simulator.
So, removing spr-field-masks will only be a temporary fix (under the
assumption that our sim port will be accepted).
I'll prepare a proper patch with what I suggested in:
https://sourceware.org/ml/binutils/2014-05/msg00198.html
Stefan
next prev parent reply other threads:[~2014-05-22 3:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5377d006.617a420a.5cb0.ffffeacbSMTPIN_ADDED_BROKEN@mx.google.com>
2014-05-19 0:46 ` Alan Modra
2014-05-19 0:54 ` Frank Ch. Eigler
2014-05-20 8:50 ` Pierre Muller
[not found] ` <537b174b.a413c20a.4a37.3c76SMTPIN_ADDED_BROKEN@mx.google.com>
2014-05-20 10:37 ` Alan Modra
2014-05-22 3:30 ` Stefan Kristiansson [this message]
2014-05-22 4:17 ` Alan Modra
2014-05-17 21:09 Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzBsGPcn1qidNtKNMV12u-q=DaqxHRvX3dtSL1QzhwrXc10Rg@mail.gmail.com' \
--to=stefan.kristiansson@saunalahti.fi \
--cc=binutils@sourceware.org \
--cc=blue@cmd.nu \
--cc=fche@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).