From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14397 invoked by alias); 22 May 2014 03:30:22 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 14372 invoked by uid 89); 22 May 2014 03:30:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 22 May 2014 03:30:19 +0000 Received: by mail-ob0-f177.google.com with SMTP id wp4so3090559obc.36 for ; Wed, 21 May 2014 20:30:17 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.51.136 with SMTP id k8mr55364946oeo.33.1400729417379; Wed, 21 May 2014 20:30:17 -0700 (PDT) Received: by 10.60.31.65 with HTTP; Wed, 21 May 2014 20:30:17 -0700 (PDT) In-Reply-To: <20140520103652.GR5162@bubble.grove.modra.org> References: <5377d006.617a420a.5cb0.ffffeacbSMTPIN_ADDED_BROKEN@mx.google.com> <20140519004639.GK5162@bubble.grove.modra.org> <537b174b.a413c20a.4a37.3c76SMTPIN_ADDED_BROKEN@mx.google.com> <20140520103652.GR5162@bubble.grove.modra.org> Date: Thu, 22 May 2014 03:30:00 -0000 Message-ID: Subject: Re: [RFA] fix mingw32 --enable-targets=all --enable-64-bit-bfd failure in or1k-desc.h From: Stefan Kristiansson To: Pierre Muller , Christian Svensson , binutils@sourceware.org, fche@sourceware.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00203.txt.bz2 On Tue, May 20, 2014 at 1:36 PM, Alan Modra wrote: > On Tue, May 20, 2014 at 10:50:12AM +0200, Pierre Muller wrote: >> > On Sat, May 17, 2014 at 11:09:06PM +0200, Pierre Muller wrote: >> > > 2014-05-17 Pierre Muller >> > > >> > > * or1k-desc.h (enum spr_field_masks): Remove compilation warning >> > > on 32-bit systems. >> > > >> > > diff --git a/opcodes/or1k-desc.h b/opcodes/or1k-desc.h >> > >> > No, sorry, this file is generated. If this patch is committed, it >> > will be undone next time the file is regenerated. I suspect you'll >> > need to poke at cgen itself to fix this problem. >> >> Sorry, but this goes way beyond my skills... >> I looked a little bit in cpu/or1* files >> and in the opcodes/cgen* files, and this seems to >> be based on guile, which is a language I know nothing about ... > > I took a look, and it seems to me there is no need for enum > spr_field_masks.. OK, Christian? > > cpu/ > * or1kcommon.cpu (spr-field-masks): Delete. > opcodes/ > * or1k-desc.h: Regenerate. > I would prefer to fix this at the root of the problem, as we *do* use the spr_field_mask in a soon to submitted sim simulator. So, removing spr-field-masks will only be a temporary fix (under the assumption that our sim port will be accepted). I'll prepare a proper patch with what I suggested in: https://sourceware.org/ml/binutils/2014-05/msg00198.html Stefan