From: Sterling Augustine <saugustine@google.com>
To: Ian Lance Taylor <iant@google.com>
Cc: Cary Coutant <ccoutant@google.com>, binutils@sourceware.org
Subject: Re: [Gold Patch] Fix Gdb Index Generation from pubnames
Date: Mon, 10 Sep 2012 19:17:00 -0000 [thread overview]
Message-ID: <CAEG7qUxVUott9v5XcM41tF8UE7yWctLKGbvkXHVBzcHWWfFKdg@mail.gmail.com> (raw)
In-Reply-To: <CAKOQZ8wVnQOa3+bOa5MUthSB1wwqj+XkhDHKcMGy97+SxuYu8A@mail.gmail.com>
On Mon, Sep 10, 2012 at 11:57 AM, Ian Lance Taylor <iant@google.com> wrote:
> On Mon, Sep 10, 2012 at 11:05 AM, Cary Coutant <ccoutant@google.com> wrote:
>>> 2012-09-07 Sterling Augustine <saugustine@google.com>
>>>
>>> * gdb-index.cc (Gdb_index::pubnames_read): New parameter.
>>> (Gdb_index::pubtypes_read): New parameter.
>>> (Gdb_index_info_reader::read_pubnames_and_pubtypes): Add parameters
>>> to calls.
>>> * gdb-index.h (Gdb_index): New fields pubnames_object_ and
>>> pubtypes_object_.
>>
>> This is fine with me. Ian needs to approve.
>
> This is OK.
>
Committed as posted.
prev parent reply other threads:[~2012-09-10 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 23:56 Sterling Augustine
2012-09-10 18:05 ` Cary Coutant
2012-09-10 18:58 ` Ian Lance Taylor
2012-09-10 19:17 ` Sterling Augustine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEG7qUxVUott9v5XcM41tF8UE7yWctLKGbvkXHVBzcHWWfFKdg@mail.gmail.com \
--to=saugustine@google.com \
--cc=binutils@sourceware.org \
--cc=ccoutant@google.com \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).