From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 4A0C6388265E for ; Fri, 30 Jun 2023 21:53:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A0C6388265E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fbc77e769cso13014255e9.0 for ; Fri, 30 Jun 2023 14:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1688162016; x=1690754016; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/LDc5BPw9Dcrd21+WP5KuWe5mixvabNhIIqkoIO1fIE=; b=rDRxgBOfRhrGw0Q/UnelmyYELAk3J2YU64Cgp6UVcCyDDRyzC4qGyUZBV5O9HPQIaw xZdTdpK4YyT5WMAIhWFfA37Iif2OSr7T69L/2C8ZEzwftn+Ip1RRgnOtZnjuWPPmLax3 5bo8znt2o38jy5Z6p8GBexsFAF1o+pf3osjSQfK8FaO4eLsMfw0FJerToQVG5nxVZ4Fd J4vjeS7Z++1t5ZIwbyq6MxAjHUdoaXkdvJnJCO6UhJ1AcvVO+4Dr/XKr07h7qCEc85GN E6Ts+PvpbKhbM/3smG24oDs3zHwkoOFzTdrif8nVICzrtGVVaXNfauAIRNuG2rHAL9il btwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688162016; x=1690754016; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/LDc5BPw9Dcrd21+WP5KuWe5mixvabNhIIqkoIO1fIE=; b=S1QCSZFzZhvJJAYTYUPLM8yfnmu8RdRDI0vk+S4WAr7ujWE8XryV3OkNYjpI4M1bnN /bh0nA3hQVxKsBZ0itNIj9zIm3S4dU1r90TZjwZtH/qAS8bPM5wQpllMcV/+cy+0KgAb EkOPjyzZWffyhKDVneNWyG3JmhLZ8B3c2iju6xeN+PbjM5qsvWUUH/KtWWPXChcg8eIt KbFrpArY0HPXd4Jx6Tgrlgzw7isxJscWEtBVNUnTJ3ir0dIWN8YQetW81/dtytEx0Urh hiCBi9/c+3+l62dC3q1yq99HqizUG/079Wk7YLlHf/OpDmjB9g/H318OcIwawZ3Izd+M kmlA== X-Gm-Message-State: ABy/qLakR/jt1EICqfUvzNyJWVI6AXzl/aM4HrBtEtBYyPEFzHW2B9MK a+oXv5VQ1Xvgl/Y1srRcGu/RdivZ6h/tgMzU5+fR9Q== X-Google-Smtp-Source: APBJJlGzvxUWI0sLlU6zp2+kH+/Ag9EhqDyQbxi33aEwG6m2BFoZk7CoYt6aImWky9xxyP6xHywbCjeev/RLk1jqDsw= X-Received: by 2002:adf:dd89:0:b0:313:f1ac:a109 with SMTP id x9-20020adfdd89000000b00313f1aca109mr3343782wrl.30.1688162016608; Fri, 30 Jun 2023 14:53:36 -0700 (PDT) MIME-Version: 1.0 References: <20230629171839.573187-1-nhuck@google.com> <20230629171839.573187-10-nhuck@google.com> <91af0cee-baf3-fea1-9364-db269a232051@gmail.com> In-Reply-To: <91af0cee-baf3-fea1-9364-db269a232051@gmail.com> From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Fri, 30 Jun 2023 23:53:24 +0200 Message-ID: Subject: Re: [PATCH 09/14] Allow nested implications for extensions. To: Jeff Law Cc: Nathan Huckleberry , binutils@sourceware.org, nhuck@pmull.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jun 30, 2023 at 10:45=E2=80=AFPM Jeff Law via Binutils wrote: > > > > On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote: > > Certain extensions require two levels of implications. For example, > > zvkng implies zvkn and zvkn implies zvkned. Enabling zvkng should also > > enable zvkned. > > > > This patch fixes this behavior. > > > > Signed-off-by: Nathan Huckleberry > > --- > > bfd/elfxx-riscv.c | 16 ++++++++++++++-- > > 1 file changed, 14 insertions(+), 2 deletions(-) > No problem with the actual code. I would suggest a comment explicitly > stating this only allows two levels rather than arbitrary levels of nesti= ng. If I read the resulting code correctly, then arbitrary nesting should be possible. Whenever an implicit subset is found and added, `finished` will be set to f= alse, `t` will be reset to the initial value and the inner loop will terminate. The outer loop will start over because `finished` is false. Do I miss something? BR Christoph > > As with the others, it needs ChangeLog and NEWS entries. > > With those changes it'll be fine for the trunk. > > Thanks, > jeff