From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id D02643858C50 for ; Tue, 22 Nov 2022 09:51:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D02643858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-oi1-x230.google.com with SMTP id l127so15294476oia.8 for ; Tue, 22 Nov 2022 01:51:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tS4vpr3cVnavEzjWIPVbd590+Verxp5z2nxDJCWw6us=; b=ApQh82EYHlnKvQXBGKeacILwu6BVox8/4PsPv5ho+94zHKnO0KhT8Djnl3h1D4/kjr Skx1hE6Vsd2TzffZBoDkHGJfPrhEqttZWRuQOFd5dMdQUyzpBvXvnbxBY/WLNlvU6quW pJds3jJf8PcaC2tGLLfN5x+ovCB2O8py8FqeIKrxJfu/X5VFYUWbfgp8kGb8hncXbDQm pq969/nHrrT2T1O+qHUHBZyvsr6oxjxvya8RpHEvLfZXr3XN0team6PWRMMEDCSb5UNo QaGRUqXkr3kFKhAAtEyeZ1qZLHe+g5VGif35zc/1HZM4RoKTiXPldn0hXLVnL8wWMD+w 34cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tS4vpr3cVnavEzjWIPVbd590+Verxp5z2nxDJCWw6us=; b=p3uyZrtxHShjPVbJ/ejdRv10Gk8l6GBUkqTNeDcDCmX5Tg8jRdAJS3TH9gKISDOmw1 B/3jnNge8RFDdch6PStj8aK4sqVThPX5ltuZVlwvUdZASh+u3Qwj6HXRQXhlgrVYtezS 3CvEZUMCs+g7nYmxRUBbWKclMoR116BSUYBHz3dRbA/pm7OxauRuhyQ3+XY0KVaL9/jE PVEmLsX8WNPyhbq/elzdkwzjg26rlP5O4buRrV3zHkDKTI6heRy/08LCkUGmeAF/o5wr xeOxIcjvNbK2amn/VtXWywTEo6+ofXy6zYdy7IPFoHHWlUex7zcSG0uWNmgOUR5JTYcj ww0Q== X-Gm-Message-State: ANoB5pmIuCwUtxptongfzeEahI4Zy4A29XnirjmXD8HHEy81ZHqDtmHt C3H2EJRlybKlkSOn5hrVHqACoC83TvdM7GFbnZg+YQ== X-Google-Smtp-Source: AA0mqf6QXrGY9Jx8YrQJIqHQt2fzeVf5rwP3TrHGWiJ2XEOcmovku75DHElCnLMeguoV65G5mwGlTtfFN7saG0YOBQo= X-Received: by 2002:a05:6808:1649:b0:34b:7532:2d0e with SMTP id az9-20020a056808164900b0034b75322d0emr10971563oib.109.1669110685100; Tue, 22 Nov 2022 01:51:25 -0800 (PST) MIME-Version: 1.0 References: <20221118003212.3628771-1-christoph.muellner@vrull.eu> In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Tue, 22 Nov 2022 10:51:13 +0100 Message-ID: Subject: Re: [PATCH] riscv: Add AIA extension support (Smaia, Ssaia) To: Nelson Chu Cc: binutils@sourceware.org, Andrew Waterman , Palmer Dabbelt , Jim Wilson , Philipp Tomsich Content-Type: multipart/alternative; boundary="0000000000007a057c05ee0c1d68" X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007a057c05ee0c1d68 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Nov 18, 2022 at 10:34 AM Nelson Chu wrote: > On Fri, Nov 18, 2022 at 5:08 PM Christoph M=C3=BCllner > wrote: > > > > > > > > On Fri, Nov 18, 2022 at 9:12 AM Nelson Chu wrote: > >> > >> > +DECLARE_CSR(hvien, CSR_HVIEN, CSR_CLASS_SMAIA_AND_H, > PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) > >> > +DECLARE_CSR(hvictl, CSR_HVICTL, CSR_CLASS_SMAIA_AND_H, > PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) > >> > +DECLARE_CSR(hviprio1, CSR_HVIPRIO1, CSR_CLASS_SMAIA_AND_H, > PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) > >> > +DECLARE_CSR(hviprio2, CSR_HVIPRIO2, CSR_CLASS_SMAIA_AND_H, > PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) > >> > +DECLARE_CSR(hidelegh, CSR_HIDELEGH, CSR_CLASS_SMAIA_AND_H_32, > PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) > >> > +DECLARE_CSR(hvienh, CSR_HVIENH, CSR_CLASS_SMAIA_AND_H_32, > PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) > >> > +DECLARE_CSR(hviph, CSR_HVIPH, CSR_CLASS_SMAIA_AND_H_32, > PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) > >> > +DECLARE_CSR(hviprio1h, CSR_HVIPRIO1H, CSR_CLASS_SMAIA_AND_H_32, > PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) > >> > +DECLARE_CSR(hviprio2h, CSR_HVIPRIO2H, CSR_CLASS_SMAIA_AND_H_32, > PRIV_SPEC_CLASS_NONE, PRIV_SPEC_CLASS_NONE) > >> > >> Just curious does the spec clarify these belonged to smaia? or should > >> these just belonged to h? > > > > > > The AIA spec says: > > "If a hart implements the Privileged Architecture=E2=80=99s hypervisor > extension, then the hypervisor and > > VS CSRs listed in Table 2.3 are also added" > > > > So I think the way it is modeled is correct. > > So if we only enable ssaia and h, then we can only use virtual > supervisor aia CSRs, but cannot use the hypervisor aia? If that true, > then looks good. > I double-checked, and that's not the case. The hypervisor splits S-mode into HS and VS, but this has nothing to do with Smaia. Therefore all hypervisor and VS CSRs should be part of Ssaia. I will fix that in a v3. Thanks! --0000000000007a057c05ee0c1d68--