From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 8C8453858D1E for ; Thu, 22 Dec 2022 14:17:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C8453858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-wr1-x42a.google.com with SMTP id i7so1776592wrv.8 for ; Thu, 22 Dec 2022 06:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dUKFLOog6fhp56gJIt3qJGS+hCm07drZRrUxv+T1BQo=; b=KVEi4t5NInpcy+ol7gBy08ZTYwyKSTpbsm/Xjd4JDAB8dOrr83E6cLLeX0hpPE/GJS VunvcfKzOTL8m+rYXb4vyBdfZkSIVsWV09hnJF2omAUfHE2MIb5d0x3LG0IU3yUZ6rVW DhcZtheXF/utP+rx0RHvT9PjsHggV+HZPZ0MjWkDyct8ijGNTq6xVAW0tOZ2Dv6l3PHc W9imzzZpuRhPHTVkXWThIG+ZaEUK4l+BzW68OHR0fKR4gxNZlPTaqIC8bOBBFQJsHKcX JH5/Lr43L8WJRAf5o6YeMDGkcuPSXgyYe0IapFuE3ZYrFLLBMkv83RtGg/cA9q7ti9CZ yp1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dUKFLOog6fhp56gJIt3qJGS+hCm07drZRrUxv+T1BQo=; b=QjFF6QzVQ/8CzyFlbKa88E61rw8RvBC8msxFAN4RRm5y7BJiF6kUJfhLgda3f3Ar3A /zQuWLpNZzeR2f+DJIx5xjulj76NcFBPtKcCksW4YsUzPv2C8E3dYiEr/6m81o0AswFL d5M34oUzNdclNyii38TpZoUGv2GsPBd/VKtPiZY8bE4zZkKF6p6jb8HxDjmwI1olM43B Xac2yxkdfaqZ4Ug9gLuZRBO9sqg2AbA2LF+5CQpdU+imOGcni6o0VJN+pCovbZzYR/o3 TczglOIvRjIgdh7nb8TFDit8MWYThJyBFlzeHmox+6QWTL2PPPNt0+5+Zcb3/cOqKRRF Jljw== X-Gm-Message-State: AFqh2krSZNkV4ZzBP1i6wEtsMRjRwOypmygE6LDhvbb+G1PkFui6O/DA g5mlHThbpFReEop3GONW2k80XFXTYmOBZ5loGE/rIw== X-Google-Smtp-Source: AMrXdXsTS2w64LtiI5nossA85A3fBKRFREMqZKl0Ce6TQxbwgBXUjb2iPwMD7FmmiVN92t3V7tkNNMh+xR45PN4kNxw= X-Received: by 2002:a5d:548f:0:b0:270:8db0:89e0 with SMTP id h15-20020a5d548f000000b002708db089e0mr50582wrv.189.1671718675220; Thu, 22 Dec 2022 06:17:55 -0800 (PST) MIME-Version: 1.0 References: <20221221170706.2877188-1-christoph.muellner@vrull.eu> <20221221170706.2877188-4-christoph.muellner@vrull.eu> In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Thu, 22 Dec 2022 15:17:43 +0100 Message-ID: Subject: Re: [RFC PATCH 3/6] RISC-V: Add Zvkh[a,b] ISA extension support To: Jeff Law Cc: binutils@sourceware.org, Nelson Chu , Andrew Waterman , Palmer Dabbelt , Jim Wilson , Philipp Tomsich , Aaron Durbin , Andrew de los Reyes , Eric Gouriou , Barna Ibrahim Content-Type: multipart/alternative; boundary="000000000000cd1e0b05f06b55a7" X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000cd1e0b05f06b55a7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 21, 2022 at 10:24 PM Jeff Law wrote: > > > On 12/21/22 10:07, Christoph Muellner wrote: > > From: Christoph M=C3=BCllner > > > > This commit adds the Zvkh[a,b] ISA extension instructions, which are pa= rt > > of the vector crypto extensions. > > > > Signed-off-by: Christoph M=C3=BCllner > > --- > > bfd/elfxx-riscv.c | 13 +++++++++++++ > > gas/testsuite/gas/riscv/zvkha.d | 12 ++++++++++++ > > gas/testsuite/gas/riscv/zvkha_zvkhb.s | 3 +++ > > gas/testsuite/gas/riscv/zvkhb.d | 12 ++++++++++++ > > include/opcode/riscv-opc.h | 11 +++++++++++ > > include/opcode/riscv.h | 3 +++ > > opcodes/riscv-opc.c | 5 +++++ > > 7 files changed, 59 insertions(+) > > create mode 100644 gas/testsuite/gas/riscv/zvkha.d > > create mode 100644 gas/testsuite/gas/riscv/zvkha_zvkhb.s > > create mode 100644 gas/testsuite/gas/riscv/zvkhb.d > Looks reasonable to me. Just one comment nit below... > > > > > diff --git a/opcodes/riscv-opc.c b/opcodes/riscv-opc.c > > index bb716c8c9d0..35d3e653147 100644 > > --- a/opcodes/riscv-opc.c > > +++ b/opcodes/riscv-opc.c > > @@ -1834,6 +1834,11 @@ const struct riscv_opcode riscv_opcodes[] =3D > > /* Zvkg instructions. */ > > {"vghmac.vv", 0, INSN_CLASS_ZVKG, "Vd,Vt,Vs", MATCH_VGHMACVV, > MASK_VGHMACVV, match_opcode, 0}, > > > > +/* Xvkh[a,b] instructions. */ > Are these X or Z? > Thanks for spotting this! > > Jeff > --000000000000cd1e0b05f06b55a7--