From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id F09E8384F6D1 for ; Fri, 18 Nov 2022 00:35:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F09E8384F6D1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-ot1-x334.google.com with SMTP id p27-20020a056830319b00b0066d7a348e20so2153039ots.8 for ; Thu, 17 Nov 2022 16:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+tLdVTN4VP9RK+F9DLyZW13uMiE55/6FyCik40j90x8=; b=p2FxDvVDlLBmW0G2F4G9ycWd5TvZrS2wtJYZ67RfbbyS/L4d+4zFbNn5HMmZgnuIKR hXxfhudbEudQ+wqgS+ZhSl3adHp8o5wSbHE2QrCQP8eb3g5oxLMTOXXCwRR4/O5/+JUo W/fowP4A3oRVbGGMUJNcezj9KuAKDub5Xdyui8BRkBCEevBmI+/wEwnujWwbxuke4Vlu xH111R4P/7N5L6spvzLRtQfKKbKz9Jw5/7/QnPVjIOm4uw+8B0fdKwwzLLnhFVLBuGQC 5PYj6HWBWQo/tiWRZfdRXA+H5tN3H7r5i38NfnSJGULj4/SwnFh9vgehp1iRcJzwzMGR jQyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+tLdVTN4VP9RK+F9DLyZW13uMiE55/6FyCik40j90x8=; b=IaFvnMIwiUeBpvrK6IUHTGaLhgMi7e6U8GOd+qc40jFUYm8dcwbSt54ORvi7iiJ1sR ysykvUwOvbghhLc60qL5/0rq/CO8XdyHaimqbqA5sxJoD0fR0VZXwGDQtA3qCpZjEp1e N6KKPiVVR3ZLaaOWJ9PgREH1HP7p/g19UuXQa+78O14LXmsD4BC9Fflq9Q06KYC0+dpc G+E6IhjP3dkHlKg+EbO/mSXekjqZBsM2ENLkIZNlj8h/meYX/iges4bPx1D5nGs/NX4j uZL2RLE3Dj17tDgBFy/p551DtZKFR408dRf7tAVbJgBAZ/pygmJcva3Rft6mfYIFFPLS c6Nw== X-Gm-Message-State: ANoB5pmuzdZWtH0U+p+DGx2o2HulZdLMi1EOy/zAWoR8acxyT8JTfiq5 jaujl1eWkxyS6kD0z7t0CsNMEtAJwfYd5qxo80m/Qw== X-Google-Smtp-Source: AA0mqf7ddmTiSnxvWxiG21uFablRpW3rgnsaZXUotqQ6erH0658VV+Mrz0uhRTpL9OCmj1gPNSvl7/DeNITmsd3fPWI= X-Received: by 2002:a05:6830:11d9:b0:661:8f21:1e14 with SMTP id v25-20020a05683011d900b006618f211e14mr2657141otq.340.1668731738252; Thu, 17 Nov 2022 16:35:38 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Fri, 18 Nov 2022 01:35:27 +0100 Message-ID: Subject: Re: [PATCH] riscv: Add AIA extension support (Smaia, Ssaia) To: Nelson Chu Cc: Palmer Dabbelt , binutils@sourceware.org, kito.cheng@sifive.com, Jim Wilson , philipp.tomsich@vrull.eu, apatel@ventanamicro.com Content-Type: multipart/alternative; boundary="0000000000007bfb6b05edb3e2b3" X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007bfb6b05edb3e2b3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 26, 2022 at 11:53 AM Nelson Chu wrote: > On Fri, Aug 26, 2022 at 3:11 AM Christoph M=C3=BCllner > wrote: > > > > This patch needs a v2 anyway because I missed the Hypervisor and VS CSR= s. > > Yeah, reviewed in advance, except the missing Hypervisor AIA CSRs and > the spec frozen issue which mentioned by Palmer, otherwise LGTM. Just > curious that will we add something like "Shaia" or "Zhaia" for the > Hypervisor and VS AIA CSRs? If no, then seems like they will belong > to the single h extension directly? Anyway, this patch just support > Ssaia and Smaia extensions, so missing the hypervisor and VS AIA CSRs > seems reasonable... Anyway, all of us agree to wait for the AIA spec > frozen before merging, so I think you can just merge this after that > time, since the Ssaia and Smaia don't include the Hypervisor AIA in > fact... > AIA spec is now frozen for a few weeks. Therefore I've sent a v2, that includes the hypervisor and VS CSRs. See: https://sourceware.org/pipermail/binutils/2022-November/124466.html > > > > >> @@ -947,7 +956,12 @@ riscv_csr_address (const char *csr_name, > > > >> || csr_class =3D=3D CSR_CLASS_SMSTATEEN_AND_= H_32); > > > >> extension =3D "smstateen"; > > > >> break; > > > >> - case CSR_CLASS_SSCOFPMF_32: > > > >> + case CSR_CLASS_SSAIA: > > > >> + case CSR_CLASS_SSAIA_32: > > > >> + is_rv32_only =3D (csr_class =3D=3D CSR_CLASS_SSAIA_32); > > > >> + extension =3D "ssaia"; > > > >> + break; > > > >> + case CSR_CLASS_SSCOFPMF_32: > > Here should be a minor indent issue. > Fixed in v2 as well. > > Thanks > Nelson > --0000000000007bfb6b05edb3e2b3--