From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 664D53858412 for ; Sun, 2 Jul 2023 20:01:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 664D53858412 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3142a9ff6d8so1858712f8f.3 for ; Sun, 02 Jul 2023 13:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1688328092; x=1690920092; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sg4Zn6Xw9q4d+hNJsY7Ni0lO4vo3cIlkTBmaUDJdNlk=; b=UVtmbPRCM1Tq2LozG9RVDQNAkolHgbERMfu12UiiFkRLJPfRC9ziIdmYcRo9vV9NTG cHgV7uAstPW0HRlNxRTxQNVda58e/fM6Q9/gkupE+LGVGoJn6I7HRJXhuiDMChKi2hUb sxBd4b/a7jocdkzBb7c1iCu+yX4D5Nbc+Ac9BlRaS2RPcphRRxV8Pbv6hzndtDh2mqhF yPMFSz84LTLeqIsCo6YiG4I8Aiovle4j2pF/OZjmP7SsoRlngIpnv78tuMDey1AdxBbh BMpNiPa6o5quK3kaFXGZUd4Vuih6Gih3EIW9UQrcAoCYNadXx3JryZcCZ5MxYXjpfE+A AWwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688328092; x=1690920092; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sg4Zn6Xw9q4d+hNJsY7Ni0lO4vo3cIlkTBmaUDJdNlk=; b=NbB2oCSC4Bly4DvB5TL4RTySJkX2lxRceAZQ1bN7nLLJ7YXIS7ICQOYqQTtTUh96p0 Wxvi1oJKKhG5F0OgI7mQDyEyJGfZRCueKJyK3sEQRk6abXOEzLxBFJp7I/0Rt0KL/44Q vq7CJ68ig6HW5KGnJK/eYcD6JhHXo435eFm/HcoOQXKmU8lGsOJekUaqdzPWwpMlH049 zFZWMlYCan/9752anL76NAWKfTozQ6ehIWAnr3Lac0g+ESm/qSdZFhRl2/1DhdNxkxdg 2dGEL+rOe4LDn3ljsOvUe5/cBTFna3DzMXqFLEe732H7lqYhfKPZGTLxa9lbjPbiHdqB ntvA== X-Gm-Message-State: ABy/qLYLDy6WbIC/F4dTdQBl+8z8NICjwVnUfK3E7O/IL6Dbwtiq9Q/L 1XK7K3NZvGHcjJ0UGDCpmmsHfvDW/aYO9jezdRT27A== X-Google-Smtp-Source: APBJJlHxSuhTArfkblqjzhqcBJWvy1mZJucws7d1W7faKVQVeqFi3gDbwWOY58f5dBFfeDqR/u6bJPhHQnkYLmHV/y8= X-Received: by 2002:a5d:61d2:0:b0:313:e8bf:a6e with SMTP id q18-20020a5d61d2000000b00313e8bf0a6emr6998323wrv.21.1688328092368; Sun, 02 Jul 2023 13:01:32 -0700 (PDT) MIME-Version: 1.0 References: <20230629171839.573187-1-nhuck@google.com> <20230629171839.573187-10-nhuck@google.com> <91af0cee-baf3-fea1-9364-db269a232051@gmail.com> <346ebb6d-a65a-214e-2ab9-66844b463b03@gmail.com> In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Sun, 2 Jul 2023 22:01:18 +0200 Message-ID: Subject: Re: [PATCH 09/14] Allow nested implications for extensions. To: Jeff Law Cc: Nathan Huckleberry , binutils@sourceware.org, nhuck@pmull.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Jul 1, 2023 at 3:33=E2=80=AFPM Jeff Law wro= te: > > > > On 6/30/23 23:22, Christoph M=C3=BCllner wrote: > > On Sat, Jul 1, 2023 at 12:24=E2=80=AFAM Jeff Law wrote: > >> > >> > >> > >> On 6/30/23 15:53, Christoph M=C3=BCllner wrote: > >>> On Fri, Jun 30, 2023 at 10:45=E2=80=AFPM Jeff Law via Binutils > >>> wrote: > >>>> > >>>> > >>>> > >>>> On 6/29/23 11:18, Nathan Huckleberry via Binutils wrote: > >>>>> Certain extensions require two levels of implications. For example= , > >>>>> zvkng implies zvkn and zvkn implies zvkned. Enabling zvkng should = also > >>>>> enable zvkned. > >>>>> > >>>>> This patch fixes this behavior. > >>>>> > >>>>> Signed-off-by: Nathan Huckleberry > >>>>> --- > >>>>> bfd/elfxx-riscv.c | 16 ++++++++++++++-- > >>>>> 1 file changed, 14 insertions(+), 2 deletions(-) > >>>> No problem with the actual code. I would suggest a comment explicit= ly > >>>> stating this only allows two levels rather than arbitrary levels of = nesting. > >>> > >>> If I read the resulting code correctly, then arbitrary nesting should > >>> be possible. > >>> Whenever an implicit subset is found and added, `finished` will be se= t to false, > >>> `t` will be reset to the initial value and the inner loop will termin= ate. > >>> The outer loop will start over because `finished` is false. > >>> Do I miss something? > >> This is making my brain hurt, too late on a Friday afternoon to think. > >> I should just put it under the debugger (the downside of trying to > >> review code for a hands-on learner), but I don't have the time right > >> now. ISTM there needs to be a worklist of things we've found that we > >> then need to scan. > >> > >> But I'll trust you on this, you're a lot more familiar with this code = in > >> general than I am. > >> > >> I wouldn't lose any sleep if you fixed formatting in this code. We're > >> supposed to be using GNU style. So the open curley on the IF statemen= t > >> should be on its own line, indented twice (which implies the code in t= he > >> TRUE arm ought to be reindented) and the close curley should line up > >> with the open curley. > > > > I tested all patches with check_GNU_style.sh and it only found > > what you have commented here. > > > > Since nobody has pushed this series so far, I have updated the code > > and sent out a v6 > > which can also be found here: > > https://github.com/cmuellner/binutils-gdb/tree/riscv-zvk-v6 > I had to fix Nathan's email address in various commits to satisfy the > commit hooks. So while the git hashes have changed, the actual source > contents pushed to the trunk are the same. Sorry for missing that! I just downloaded the emails and applied them. I did go through all commit messages, added the ChangeLog and cleaned them up, but I did not look at the author line. Thanks for fixing and pushing!