From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 98FD63858281 for ; Thu, 22 Dec 2022 14:23:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 98FD63858281 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-wr1-x42d.google.com with SMTP id y16so1812010wrm.2 for ; Thu, 22 Dec 2022 06:23:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Nidx/4/wwRba6qDBp1PiKKfbggnCc9+rJP+u8C6gp48=; b=peuYNgnFXhNuuv/dySqOXmy+mcnGsieoDGL313zKeM8rIgmUXAeveYMp6sFxx0tGVp WPAzGavBs7egwCYARKrHXjlRk/xRKYcWs2BWtwM41ImFzCghT/PkPbA/De+BXXF9XORt qmVIIczWW41j0Z/f4s7wAKtR6lU7WV1WALKbDK9rBwgLw1xedjgjRfhWsE7qTCCG8YMX bZA4EiO/L3Cog33o/Z0EkMuw7ioK9zPt1THmRS3CaOIa+ZNdkKNetou1iwjzXN0e3gSA 40u345GzVJwbH+7IFEJA/0SRqgbLAteDGmLlm/o4W2JIWlfOjCO1HCS45ZVCNqtyp/PL R/tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Nidx/4/wwRba6qDBp1PiKKfbggnCc9+rJP+u8C6gp48=; b=qaoFw1lZpPWwSnHj7BaY8ScjpfegsjNfvdvF1b+c/NHKiMqNdGKHZ5z+65LIQr2BJI dM6tLXQVE3vBRO8BUlYvpj5sstOWr24kj+3rfqBhTR7FX0xsSixw6vOCf8lj+N6RMIEK TbkkMlRn51NdHvCrvOeCRJ7xDe2UiKJtcBFPgGXIgNECfaxAfvkMx2e5urdxg/M0z/8q lqWBLi+EgOI4sZlsP4P8hg9ZoDZBCXH8bkCC88vsUUmnSIxqsALUcqrignsQG4is5XJQ MVPLnkxAbuXUQA5UC4z/KtSx7mIk2+fiDjrCom7JXgOWhOc/9KCLzJF6noLAB5k96wtS dQWQ== X-Gm-Message-State: AFqh2kppySn2ZFTCX2XUWd6a5jK6r8qbbrUIOCBiaV+Eb1gw2LbbKx0N 5Ogm5SD0ZZ+TH3DoOwBToS7jszF6UCz8s/2vi4iDAbXX+izdeQ== X-Google-Smtp-Source: AMrXdXuSBFM0t6T/NOMkQVkG149quW5XT52NfPEnz1uq2Ju7dcmqvSbr9Pi/O7kfGGRabjHht8idPMSiACL6/XQGEkQ= X-Received: by 2002:a5d:5226:0:b0:242:5570:d4b4 with SMTP id i6-20020a5d5226000000b002425570d4b4mr172870wra.674.1671718996238; Thu, 22 Dec 2022 06:23:16 -0800 (PST) MIME-Version: 1.0 References: <20221221170706.2877188-1-christoph.muellner@vrull.eu> <20221221170706.2877188-2-christoph.muellner@vrull.eu> In-Reply-To: From: =?UTF-8?Q?Christoph_M=C3=BCllner?= Date: Thu, 22 Dec 2022 15:23:04 +0100 Message-ID: Subject: Re: [RFC PATCH 1/6] RISC-V: Add Zvkb ISA extension support To: Jeff Law Cc: binutils@sourceware.org, Nelson Chu , Andrew Waterman , Palmer Dabbelt , Jim Wilson , Philipp Tomsich , Aaron Durbin , Andrew de los Reyes , Eric Gouriou , Barna Ibrahim Content-Type: multipart/alternative; boundary="000000000000ef776d05f06b6834" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ef776d05f06b6834 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 21, 2022 at 9:50 PM Jeff Law wrote: > > > On 12/21/22 10:07, Christoph Muellner wrote: > > From: Christoph M=C3=BCllner > > > > This commit adds the Zvkb ISA extension instructions, which are part > > of the vector crypto extensions. > > > > Signed-off-by: Christoph M=C3=BCllner > > --- > > bfd/elfxx-riscv.c | 5 ++++ > > gas/config/tc-riscv.c | 13 ++++++++++ > > gas/testsuite/gas/riscv/zvkb.d | 36 ++++++++++++++++++++++++++++ > > gas/testsuite/gas/riscv/zvkb.s | 28 ++++++++++++++++++++++ > > include/opcode/riscv-opc.h | 44 ++++++++++++++++++++++++++++++++++ > > include/opcode/riscv.h | 5 ++++ > > opcodes/riscv-dis.c | 4 ++++ > > opcodes/riscv-opc.c | 16 +++++++++++++ > > 8 files changed, 151 insertions(+) > > create mode 100644 gas/testsuite/gas/riscv/zvkb.d > > create mode 100644 gas/testsuite/gas/riscv/zvkb.s > It all looks quite sensible to me. > > > > +/* Zvkb instructions. */ > > +#define MATCH_VCLMULVV 0x30002057 > > +#define MASK_VCLMULVV 0xfc00707f > I'm just going to trust you got these right and that the MATCH value in > particular might need adjustment if the encodings change. > In fact, they changed two days ago (clmul, clmulh, rotl, rotr). So I had to adjust these before sending the patchset on the list. When doing so, I rechecked all Zvkb, so I'm quite sure they are good. > > > > > +DECLARE_INSN(vclmulvv, MATCH_VCLMULVV, MASK_VCLMULVV) > So IIRC, these are only used in GDB's prologue/epilogue scanning code -- > and we're quite unlikely to ever need any of these instructions for > prologues/epilogues. I'm guessing convention is to go ahead and add the > DECLARE_INSN instances for each instruction, even if they aren't likely > to be show up in a prologue or epilogue? > Honestly, I'm not sure what to list here and what not (and I did not see any policy). Therefore, in doubt, I always add these. > > Jeff > --000000000000ef776d05f06b6834--