public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Peter Smith <peter.smith@linaro.org>
To: Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Cc: "nickc@redhat.com" <nickc@redhat.com>,
	Sudakshina Das <Sudi.Das@arm.com>,
		"binutils@sourceware.org" <binutils@sourceware.org>,
	nd <nd@arm.com>, 	Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH, BFD, LD, AArch64, 0/4] Add support for AArch64 BTI and PAC in the linker
Date: Fri, 08 Mar 2019 11:46:00 -0000	[thread overview]
Message-ID: <CAEt-8LC6FP2-6_ac9X_kB=WiiWooa5XM622=3Gpkgf38T9oU_g@mail.gmail.com> (raw)
In-Reply-To: <5653d89c-3239-df8f-6a62-07c0fa189387@arm.com>

On Fri, 8 Mar 2019 at 11:14, Ramana Radhakrishnan
<Ramana.Radhakrishnan@arm.com> wrote:
>
> On 08/03/2019 10:07, Nick Clifton wrote:
> > Hi Sudi,
> >
> >>> OK, so just to be clear, with --bti or --bti-nowarn the output will be
> >>> given the BTI tag *even if* some of the input files do not have the BTI note ?
> >
> >> Yes
> >
> >> can go back and check the objects that need recompiling or use
> >> --bti-nowarn when they are sure that even if there is any object with
> >> missing BTI note section it is still safe to turn on BTI (or they still
> >> want to turn on BTI). We think that these options would be most helpful
> >> in early deployment.
> >
> > OK, well I get the --bti option then, but I still think that --bti-nowarn
> > is a mistake.  Given that --bti will only generate warnings if there are
> > object files without the BTI note, and warnings can be ignored, I do not
> > see the need for --bti-nowarn.  Plus using --bti-nowarn could potentially
> > cause problems if the developer forgets (or does not know) that it is
> > enabled, and they end up thinking that they are creating BTI enabled
> > binaries when in fact they are not.
>
> Given this conversation, maybe renaming --bti to --force-bti would
> express the intention clearer ?
>
>
Indeed warnings can be ignored in most cases, particularly when there
aren't too many. In a large project the output could be large enough
to drown out other possibly more important warnings though. If there
were a way to generically suppress individual warnings then the case
for the separate command line option wouldn't be as good. Having said
that, I the nowarn form isn't as important as just --bti, or as Ramana
says --force-bti.

Peter

> regards
> Ramana
> >
> > Cheers
> >    Nick
> >
> >
>

  reply	other threads:[~2019-03-08 11:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 10:26 Sudakshina Das
2019-03-06 10:31 ` [PATCH, BFD, LD, AArch64, 1/4] Add support for GNU PROPERTIES in AArch64 for BTI and PAC Sudakshina Das
2019-03-06 10:34   ` [PATCH, BFD, LD, AArch64, 2/4] Add --bti-nowarn to enable BTI without warning and to select BTI enabled PLTs Sudakshina Das
2019-03-06 10:36     ` [PATCH, BFD, LD, AArch64, 3/4] Add --bti to enable BTI and select BTI enabled PLTs but also warn for missing NOTE sections Sudakshina Das
2019-03-06 10:39       ` [PATCH, BFD, LD, AArch64, 4/4] Add --pac-plt to enable PLTs protected with PAC Sudakshina Das
2019-04-11 14:47         ` Szabolcs Nagy
2019-03-07 12:37 ` [PATCH, BFD, LD, AArch64, 0/4] Add support for AArch64 BTI and PAC in the linker Nick Clifton
2019-03-07 14:28   ` Sudakshina Das
2019-03-07 15:26     ` Peter Smith
2019-03-07 15:35       ` Nick Clifton
2019-03-07 15:49         ` Szabolcs Nagy
2019-03-07 15:33     ` Nick Clifton
2019-03-07 17:53       ` Sudakshina Das
2019-03-08 10:07         ` Nick Clifton
2019-03-08 11:08           ` Szabolcs Nagy
2019-03-08 11:14           ` Ramana Radhakrishnan
2019-03-08 11:46             ` Peter Smith [this message]
2019-03-08 12:32               ` Nick Clifton
2019-03-08 12:44                 ` Ramana Radhakrishnan
2019-03-08 13:36                   ` Sudakshina Das
2019-03-11 12:30                     ` Nick Clifton
2019-03-13 11:49                       ` Sudakshina Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEt-8LC6FP2-6_ac9X_kB=WiiWooa5XM622=3Gpkgf38T9oU_g@mail.gmail.com' \
    --to=peter.smith@linaro.org \
    --cc=Ramana.Radhakrishnan@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=Sudi.Das@arm.com \
    --cc=binutils@sourceware.org \
    --cc=nd@arm.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).