From: Kai Tietz <ktietz70@googlemail.com>
To: Kai Tietz <ktietz70@googlemail.com>, Binutils <binutils@sourceware.org>
Subject: Re: [patch bfd]: Avoid to remove leading underscore for anon-object for pe-coff targets with empty USER_LABEL_PREFIX
Date: Fri, 09 Sep 2011 13:21:00 -0000 [thread overview]
Message-ID: <CAEwic4awSsJKFJJP=NMh8Ri0La9VyQTUDAucKi8_SNC41xzVUg@mail.gmail.com> (raw)
In-Reply-To: <20110909131510.GA336@ednor.casa.cgf.cx>
2011/9/9 Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>:
> On Fri, Sep 09, 2011 at 02:41:58PM +0200, Kai Tietz wrote:
>>this patch avoids the removal of leading underscores for pe-coff
>>targets with empty USER_LABEL_PREFIX (like x86_64-pe-coff, and arm).
>>
>>Regression-tested for i686-w64-mingw32 and x86_64-w64-mingw32. Ok for apply?
>
> Shouldn't that testing include a non-w64 Windows target too?
>
>>ChangeLog
>>
>>2011-09-09 Kai Tietz <ktietz@redhat.com>
>>
>> * peicode.h (pe_ILF_build_a_bfd): Don't remove leading underscore
>> for targets without symbol_leading_char.
>
> It looks ok to me, but I would like confirmation that it works with
> mingw32 and Cygwin.
>
> cgf
I tested iit for 686-w64-mingw32 target - as I wrote - and this is a
32-bit i686 target. So test is sufficiant as there is in binutils'
bfd code no difference between i686-pc-mingw32, i686-pc-cygwin, and
i686-w64.mingw32 targets in this area.
Kai
next prev parent reply other threads:[~2011-09-09 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 12:42 Kai Tietz
2011-09-09 13:15 ` Christopher Faylor
2011-09-09 13:21 ` Kai Tietz [this message]
2011-09-09 13:57 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEwic4awSsJKFJJP=NMh8Ri0La9VyQTUDAucKi8_SNC41xzVUg@mail.gmail.com' \
--to=ktietz70@googlemail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).