From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8244 invoked by alias); 19 Mar 2014 13:57:45 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 8232 invoked by uid 89); 19 Mar 2014 13:57:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-la0-f47.google.com Received: from mail-la0-f47.google.com (HELO mail-la0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 19 Mar 2014 13:57:43 +0000 Received: by mail-la0-f47.google.com with SMTP id y1so5873309lam.20 for ; Wed, 19 Mar 2014 06:57:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=E92XjqThhSHLDGq/NGBfzo7HlaVhyezkhENQnQHXNLM=; b=g7//ZorBXVybvIXsdLWju0ETXLWzQ7PJU433qFk7SdHCEjGJaSN+wCMts/1ncT3nab EYNgyDG/krTKWjyYsdv8IKg743IMz7Jx41rNbjL4xhFvDL5v2MzITGPaR112OwPeIJEs tegQFxdwmtxqSS2udWhlZ3f/hW1DMoZMBNYGvnSeXxcg+0GA3Wy2YBY6Dg5MS/whjTLe TOt/sQUX+StrE8VBDIzv5wlgX/bzE8do4tso1Vj3f9OrvDFjIldWwlD+0qDsgeAyrUwX CDtKLJapREmeIHS8QWgz2rjRqnDfy80feE0KDz80eiZP7VytXpGHD3nZ+ClyO2bpmhzh W+3A== X-Gm-Message-State: ALoCoQmIpeiTRtOa2YAT337F7j9UXsaSMzmRc8X1Pjo9iDbTNqFcR4eZTXJOeeigurhvoErUEaS0 MIME-Version: 1.0 X-Received: by 10.112.156.165 with SMTP id wf5mr1686866lbb.37.1395237460061; Wed, 19 Mar 2014 06:57:40 -0700 (PDT) Received: by 10.112.9.40 with HTTP; Wed, 19 Mar 2014 06:57:39 -0700 (PDT) In-Reply-To: <53299C43.8040607@redhat.com> References: <240112064-1393947412-cardhu_decombobulator_blackberry.rim.net-1332958159-@b28.c15.bise6.blackberry> <53162C0E.6080002@eagerm.com> <604343986-1393969065-cardhu_decombobulator_blackberry.rim.net-1475874685-@b28.c15.bise6.blackberry> <564843056-1394800165-cardhu_decombobulator_blackberry.rim.net-1498109565-@b28.c15.bise6.blackberry> <1168996588-1395223994-cardhu_decombobulator_blackberry.rim.net-959557934-@b28.c15.bise6.blackberry> <53299C43.8040607@redhat.com> Date: Wed, 19 Mar 2014 13:57:00 -0000 Message-ID: Subject: Re: [PATCH] add CodeComposer Studio assembly syntax compatibility support From: Daniel Gutson To: Nicholas Clifton Cc: binutils@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00204.txt.bz2 On Wed, Mar 19, 2014 at 10:31 AM, Nicholas Clifton wrote: > Hi Daniel, Hi Nick, > > Sorry for the long delay in reviewing this patch. > > Unfortunately I do not like the approach of converting the comment_chars > and line_separator_chars arrays in *all* targets to non-constant versions. > GAS already has a solution for the comment_chars array - defining > tc_comment_chars - and it is a relatively simply affair to extend this to > handle line_separator_chars as well. Nice, I didn't see that, of course this is a cleaner and simpler solution. > > Also your patch adds a new command line option -mccs, but it does not > include any documentation of it in gas/doc/c-arm.texi or gas/NEWS. Sorry about that, I only updated as.texinfo. > > So... please have a look at the attached variant patch and let me know = if > this is acceptable to you. Yes, looks OK. Could you please commit it for me since I don't think I have write access? Thanks! Daniel. > > Cheers > Nick > > --=20 Daniel F. Gutson Chief Engineering Officer, SPD San Lorenzo 47, 3rd Floor, Office 5 C=F3rdoba, Argentina Phone: +54 351 4217888 / +54 351 4218211 Skype: dgutson