From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 0259C3858425 for ; Fri, 11 Nov 2022 08:00:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0259C3858425 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-lj1-x231.google.com with SMTP id k19so3678838lji.2 for ; Fri, 11 Nov 2022 00:00:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eov4H+6KnSVQUs5J4zSVzIAzlxO1mGxiVg8U29u/GWg=; b=OV6WIpoj8bYjDJC5/XGLKCDBbxAitxTE9S5ZSoh/GMBnasxK9KAPYAt4BgJRo/1WFW mxVDLoQbPGvlnbT7jclsue5kHLfVVIEdHPOpdzFe4eaF5SUOqhmIcm4GYR3x0kten6Gx EUd3M8QRpcfqdh6glOq6jQ/3jIDION6//t+Ocgj6yqwus47W64J6759ohGKyggTcOgGq SvpNWn6vBsLBZ2i803xJSZJElmQNHwevGC8sO//k+yUjCxM3EXCYAZfrWqAvHSplqtOP wGP68BNDmjg4TzwDGcbc81w8R1nnAEi6AkBoaWsXvNDIX49GKjGuBfB0s/1Hh8jjZuuJ 4s/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eov4H+6KnSVQUs5J4zSVzIAzlxO1mGxiVg8U29u/GWg=; b=hEKsq+rJE3+Qw/xV4Ks99el4rDB55M4+ZH77wdGHtf+y8radFIZjCAvyWfgV6YeZe+ bYsJ8ZA2u1r7U/Ghu2ZSKhz3K9nkKFoyxqHDJZbZQ4urC8aK4l0ajxqU2TljUP9CxFjH Jawqkg0aZYKnFt7sRnfyv+34Y3rHq56i/Gx99YBeQfFKYpwm7rQdNKoUHyDy/F9ehzfu did9s61q7DqtB1pw+gv4hfe/70+/fAYDES33fyb+AMPKprhJ34Uzcg5iamDl6Ntu/Fha LHn4Ref7WiE6fsvQ4wzHEhVdIUAVwuUBE806it+9AknPdzOZ7d0CcjTZSpK9LnBA3u5u iD1w== X-Gm-Message-State: ANoB5pkoD5enFd1avj5ryZIJAq1HMlT2iJGemrUwHt8Wsdsg9lrJkZ5d HEWl+9HVHMLcuJQRA+8O4dDGkEAs+m4nVN9fYHHUAw== X-Google-Smtp-Source: AA0mqf71XmgQ2WCfpm3+AyTPxpOYdGS5JPNfGjcQUw7bBYRKEM279JxGlNYKSSpvhJlVhJsIHbpkycednG/Tv8mwMhA= X-Received: by 2002:a05:651c:2314:b0:277:2123:120e with SMTP id bi20-20020a05651c231400b002772123120emr295551ljb.4.1668153655915; Fri, 11 Nov 2022 00:00:55 -0800 (PST) MIME-Version: 1.0 References: <20221001023846.590825-1-maskray@google.com> In-Reply-To: From: Fangrui Song Date: Fri, 11 Nov 2022 00:00:44 -0800 Message-ID: Subject: Re: [PATCH] gold: add --compress-debug-sections=zstd [PR 29641] To: Alan Modra Cc: Cary Coutant , binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-22.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 10, 2022 at 11:40 PM Alan Modra wrote: > > Applied. > Fix the following: > compressed_output.cc:86:8: error: assignment of read-only variable =E2=80= =98size=E2=80=99 > 86 | size =3D ZSTD_compress(*compressed_data + header_size, size, un= compressed_data, Sorry for my embarrassing last-minute error and thanks for fixing it :) > diff --git a/gold/compressed_output.cc b/gold/compressed_output.cc > index e9f12241f26..f192ddb5080 100644 > --- a/gold/compressed_output.cc > +++ b/gold/compressed_output.cc > @@ -81,7 +81,7 @@ zstd_compress(int header_size, const unsigned char *unc= ompressed_data, > unsigned long uncompressed_size, > unsigned char **compressed_data, unsigned long *compressed_= size) > { > - const size_t size =3D ZSTD_compressBound(uncompressed_size); > + size_t size =3D ZSTD_compressBound(uncompressed_size); > *compressed_data =3D new unsigned char[size + header_size]; > size =3D ZSTD_compress(*compressed_data + header_size, size, uncompres= sed_data, > uncompressed_size, ZSTD_CLEVEL_DEFAULT); > > -- > Alan Modra > Australia Development Lab, IBM --=20 =E5=AE=8B=E6=96=B9=E7=9D=BF