[PATCH/AARCH64] Add ThunderX T88 pass1 -mpcu option

[PATCH/AARCH64] Add ThunderX T88 pass1 -mpcu option

[Andrew Pinski]

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

Hi,
  ThunderX T88 pass 1.x does not include ARMv8.1 support but all
future ThunderX (including T88 pass 2) does so we need an option to
distinguish the two.  Note ThunderX is family of processors and they
all have very similar cores (just errata fixes) which have different
part numbers so having a different -mcpu= for each of those processors
does not make sense.

ok?  Build and tested on aarch64-linux-gnu with no regressions.

ChangeLog:
* config/tc-aarch64.c (aarch64_cpus):
Add thunderxt88pass1.
* doc/c-aarch64.texi: Document that thunderxt88pass1
is a valid processor name.

[-- Attachment #2: addt88pass1.diff.txt --]
[-- Type: text/plain, Size: 1832 bytes --]

commit 0d570028738107a01564798a99a51f6e0c5a71dd
Author: Andrew Pinski <apinski@cavium.com>
Date:   Wed Aug 19 04:02:46 2015 -0700

    [PATCH/AARCH64] Add ThunderX T88 pass1 -mpcu option
    
    Hi,
      ThunderX T88 pass 1.x does not include ARMv8.1 support but all future ThunderX (including T88 pass 2) does so we need an option to distinguish the two.  Note ThunderX is family of processors and they all have very similar cores (just errata fixes) which have different part numbers so having a different -mcpu= for each of those processors does not make sense.
    
    ok?  Build and tested on aarch64-linux-gnu with no regressions.
    
    ChangeLog:
    	* config/tc-aarch64.c (aarch64_cpus):
    	Add thunderxt88pass1.
    	* doc/c-aarch64.texi: Document that thunderxt88pass1
    	is a valid processor name.

diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index df37541..91e1acc 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -7407,6 +7407,10 @@ static const struct aarch64_cpu_option_table aarch64_cpus[] = {
   {"exynos-m1", AARCH64_FEATURE (AARCH64_ARCH_V8,
 				 AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO),
 				"Samsung Exynos M1"},
+  {"thunderxt88pass1", AARCH64_FEATURE (AARCH64_ARCH_V8,
+					AARCH64_FEATURE_CRC
+					| AARCH64_FEATURE_CRYPTO),
+   "Cavium ThunderX T88xx pass 1.x"},
   {"thunderx", AARCH64_FEATURE (AARCH64_ARCH_V8,
 				AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO),
    "Cavium ThunderX"},
diff --git a/gas/doc/c-aarch64.texi b/gas/doc/c-aarch64.texi
index 2053990..940549d 100644
--- a/gas/doc/c-aarch64.texi
+++ b/gas/doc/c-aarch64.texi
@@ -60,6 +60,7 @@ on the target processor.  The following processor names are recognized:
 @code{cortex-a72},
 @code{exynos-m1},
 @code{thunderx},
+@code{thunderxt88pass1},
 @code{xgene1}
 and
 @code{xgene2}.

Re: [PATCH/AARCH64] Add ThunderX T88 pass1 -mpcu option

[Marcus Shawcroft]

On 19 August 2015 at 12:05, Andrew Pinski <pinskia@gmail.com> wrote:
> Hi,
>   ThunderX T88 pass 1.x does not include ARMv8.1 support but all
> future ThunderX (including T88 pass 2) does so we need an option to
> distinguish the two.  Note ThunderX is family of processors and they
> all have very similar cores (just errata fixes) which have different
> part numbers so having a different -mcpu= for each of those processors
> does not make sense.
>
> ok?  Build and tested on aarch64-linux-gnu with no regressions.
>
> ChangeLog:
> * config/tc-aarch64.c (aarch64_cpus):
> Add thunderxt88pass1.
> * doc/c-aarch64.texi: Document that thunderxt88pass1
> is a valid processor name.

OK...  assuming that in light of James G's proposed patch to have gcc
pass -march rather than -mcpu
https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01106.html you still
want to land this patch...
Cheers
/Marcus

Re: [PATCH/AARCH64] Add ThunderX T88 pass1 -mpcu option

[Andrew Pinski]

On Thu, Aug 20, 2015 at 12:33 AM, Marcus Shawcroft
<marcus.shawcroft@gmail.com> wrote:
> On 19 August 2015 at 12:05, Andrew Pinski <pinskia@gmail.com> wrote:
>> Hi,
>>   ThunderX T88 pass 1.x does not include ARMv8.1 support but all
>> future ThunderX (including T88 pass 2) does so we need an option to
>> distinguish the two.  Note ThunderX is family of processors and they
>> all have very similar cores (just errata fixes) which have different
>> part numbers so having a different -mcpu= for each of those processors
>> does not make sense.
>>
>> ok?  Build and tested on aarch64-linux-gnu with no regressions.
>>
>> ChangeLog:
>> * config/tc-aarch64.c (aarch64_cpus):
>> Add thunderxt88pass1.
>> * doc/c-aarch64.texi: Document that thunderxt88pass1
>> is a valid processor name.
>
> OK...  assuming that in light of James G's proposed patch to have gcc
> pass -march rather than -mcpu
> https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01106.html you still
> want to land this patch...

No I don't need this patch any more.  I submitted this patch right
before James G.'s patch was submitted upstream.

Thanks,
Andrew

> Cheers
> /Marcus