* [AArch64][2/2] BFD support BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14
@ 2015-05-20 10:51 Jiong Wang
2015-06-01 9:39 ` Jiong Wang
2015-06-01 14:14 ` Marcus Shawcroft
0 siblings, 2 replies; 3+ messages in thread
From: Jiong Wang @ 2015-05-20 10:51 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
This patch add BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14 relocation supoprt in bfd linker.
native check-ld OK
OK for trunk?
2015-05-19 Jiong Wang <jiong.wang@arm.com>
bfd/
* elfnn-aarch64.c (aarch64_reloc_got_type): Support
BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14.
(elfNN_aarch64_final_link_relocate): Ditto.
(elfNN_aarch64_gc_swap_hook): Ditto.
(elfNN_aarch64_check_relocs): Ditto.
* elfxx-aarch64.c (_bfd_aarch64_elf_put_addend): Ditto.
ld/testsuite/
* ld-aarch64/emit-relocs-28.s: New test file.
* ld-aarch64/emit-relocs-28.d: Ditto.
* ld-aarch64/aarch64-elf.exp: Run new test.
--
Regards,
Jiong
[-- Attachment #2: ld-3.patch --]
[-- Type: text/x-diff, Size: 6756 bytes --]
commit 1c7c422019b7474bb26d0ed924d5d009438d480d
Author: Jiong Wang <jiong.wang@arm.com>
Date: Tue May 12 14:21:09 2015 +0000
3
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index e9e63c8..91878bf 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -4067,6 +4067,7 @@ aarch64_reloc_got_type (bfd_reloc_code_real_type r_type)
{
case BFD_RELOC_AARCH64_ADR_GOT_PAGE:
case BFD_RELOC_AARCH64_GOT_LD_PREL19:
+ case BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14:
case BFD_RELOC_AARCH64_LD32_GOT_LO12_NC:
case BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15:
case BFD_RELOC_AARCH64_LD64_GOT_LO12_NC:
@@ -4621,6 +4622,7 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto,
howto, value);
case BFD_RELOC_AARCH64_ADR_GOT_PAGE:
case BFD_RELOC_AARCH64_GOT_LD_PREL19:
+ case BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14:
case BFD_RELOC_AARCH64_LD32_GOT_LO12_NC:
case BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15:
case BFD_RELOC_AARCH64_LD64_GOT_LO12_NC:
@@ -4682,7 +4684,8 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto,
value = aarch64_calculate_got_entry_vma (h, globals, info,
value, output_bfd,
unresolved_reloc_p);
- if (bfd_r_type == BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15)
+ if (bfd_r_type == BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15
+ || bfd_r_type == BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14)
addend = (globals->root.sgot->output_section->vma
+ globals->root.sgot->output_offset);
value = _bfd_aarch64_elf_resolve_relocation (bfd_r_type, place, value,
@@ -4890,6 +4893,7 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto,
case BFD_RELOC_AARCH64_ADR_GOT_PAGE:
case BFD_RELOC_AARCH64_GOT_LD_PREL19:
+ case BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14:
case BFD_RELOC_AARCH64_LD32_GOT_LO12_NC:
case BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15:
case BFD_RELOC_AARCH64_LD64_GOT_LO12_NC:
@@ -4902,7 +4906,8 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto,
value = aarch64_calculate_got_entry_vma (h, globals, info, value,
output_bfd,
unresolved_reloc_p);
- if (bfd_r_type == BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15)
+ if (bfd_r_type == BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15
+ || bfd_r_type == BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14)
addend = (globals->root.sgot->output_section->vma
+ globals->root.sgot->output_offset);
value = _bfd_aarch64_elf_resolve_relocation (bfd_r_type, place, value,
@@ -4960,7 +4965,8 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto,
the direct data access into indirect data access through GOT. */
value = got_entry_addr;
- if (bfd_r_type == BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15)
+ if (bfd_r_type == BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15
+ || bfd_r_type == BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14)
addend = base_got->output_section->vma + base_got->output_offset;
value = _bfd_aarch64_elf_resolve_relocation (bfd_r_type, place, value,
@@ -5965,6 +5971,7 @@ elfNN_aarch64_gc_sweep_hook (bfd *abfd,
{
case BFD_RELOC_AARCH64_ADR_GOT_PAGE:
case BFD_RELOC_AARCH64_GOT_LD_PREL19:
+ case BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14:
case BFD_RELOC_AARCH64_LD32_GOT_LO12_NC:
case BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15:
case BFD_RELOC_AARCH64_LD64_GOT_LO12_NC:
@@ -6327,6 +6334,7 @@ elfNN_aarch64_check_relocs (bfd *abfd, struct bfd_link_info *info,
case BFD_RELOC_AARCH64_CALL26:
case BFD_RELOC_AARCH64_GOT_LD_PREL19:
case BFD_RELOC_AARCH64_JUMP26:
+ case BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14:
case BFD_RELOC_AARCH64_LD32_GOT_LO12_NC:
case BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15:
case BFD_RELOC_AARCH64_LD64_GOT_LO12_NC:
@@ -6439,6 +6447,7 @@ elfNN_aarch64_check_relocs (bfd *abfd, struct bfd_link_info *info,
there are no dangling GOT_PAGE relocs. */
case BFD_RELOC_AARCH64_ADR_GOT_PAGE:
case BFD_RELOC_AARCH64_GOT_LD_PREL19:
+ case BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14:
case BFD_RELOC_AARCH64_LD32_GOT_LO12_NC:
case BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15:
case BFD_RELOC_AARCH64_LD64_GOT_LO12_NC:
diff --git a/bfd/elfxx-aarch64.c b/bfd/elfxx-aarch64.c
index 889b0d0..b720592 100644
--- a/bfd/elfxx-aarch64.c
+++ b/bfd/elfxx-aarch64.c
@@ -257,6 +257,7 @@ _bfd_aarch64_elf_put_addend (bfd *abfd,
contents = reencode_add_imm (contents, addend);
break;
+ case BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14:
case BFD_RELOC_AARCH64_LD32_GOT_LO12_NC:
case BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15:
case BFD_RELOC_AARCH64_LD64_GOT_LO12_NC:
@@ -414,6 +415,7 @@ _bfd_aarch64_elf_resolve_relocation (bfd_reloc_code_real_type r_type,
value = PG (value + addend) - PG (place);
break;
+ case BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14:
case BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15:
/* Caller must make sure addend is the base address of .got section. */
value = value - PG (addend);
diff --git a/ld/testsuite/ld-aarch64/aarch64-elf.exp b/ld/testsuite/ld-aarch64/aarch64-elf.exp
index 79b5a3e..6b1109a 100644
--- a/ld/testsuite/ld-aarch64/aarch64-elf.exp
+++ b/ld/testsuite/ld-aarch64/aarch64-elf.exp
@@ -50,6 +50,7 @@ run_dump_test "erratum843419"
# Relocation Tests
run_dump_test "weak-undefined"
+run_dump_test "emit-relocs-28"
run_dump_test "emit-relocs-257"
run_dump_test "emit-relocs-257-be"
# 258 is tested in 257
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-28.d b/ld/testsuite/ld-aarch64/emit-relocs-28.d
new file mode 100644
index 0000000..f138fb1
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-28.d
@@ -0,0 +1,19 @@
+#source: emit-relocs-28.s
+#as: -mabi=ilp32
+#ld: -m aarch64linux32 --defsym globala=0x11000 --defsym globalb=0x45000 --defsym globalc=0x1234 -e0 --emit-relocs
+#objdump: -dr
+
+.*: +file format .*
+
+
+Disassembly of section .text:
+
+00400074 <\.text>:
+ 400074: 90000082 adrp x2, 410000 <globalb\+0x3cb000>
+ 400074: R_AARCH64_P32_ADR_PREL_PG_HI21 _GLOBAL_OFFSET_TABLE_
+ 400078: f9408c40 ldr x0, \[x2,#280\]
+ 400078: R_AARCH64_P32_LD32_GOTPAGE_LO14 globala
+ 40007c: f9409040 ldr x0, \[x2,#288\]
+ 40007c: R_AARCH64_P32_LD32_GOTPAGE_LO14 globalb
+ 400080: f9408840 ldr x0, \[x2,#272\]
+ 400080: R_AARCH64_P32_LD32_GOTPAGE_LO14 globalc
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-28.s b/ld/testsuite/ld-aarch64/emit-relocs-28.s
new file mode 100644
index 0000000..b13a0e5
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-28.s
@@ -0,0 +1,5 @@
+ .text
+ adrp x2, _GLOBAL_OFFSET_TABLE_
+ ldr x0, [x2, #:gotpage_lo14:globala]
+ ldr x0, [x2, #:gotpage_lo14:globalb]
+ ldr x0, [x2, #:gotpage_lo14:globalc]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [AArch64][2/2] BFD support BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14
2015-05-20 10:51 [AArch64][2/2] BFD support BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14 Jiong Wang
@ 2015-06-01 9:39 ` Jiong Wang
2015-06-01 14:14 ` Marcus Shawcroft
1 sibling, 0 replies; 3+ messages in thread
From: Jiong Wang @ 2015-06-01 9:39 UTC (permalink / raw)
To: binutils
Jiong Wang writes:
> This patch add BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14 relocation supoprt in bfd linker.
>
> native check-ld OK
>
> OK for trunk?
>
>
> 2015-05-19 Jiong Wang <jiong.wang@arm.com>
>
> bfd/
> * elfnn-aarch64.c (aarch64_reloc_got_type): Support
> BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14.
> (elfNN_aarch64_final_link_relocate): Ditto.
> (elfNN_aarch64_gc_swap_hook): Ditto.
> (elfNN_aarch64_check_relocs): Ditto.
> * elfxx-aarch64.c (_bfd_aarch64_elf_put_addend): Ditto.
>
> ld/testsuite/
> * ld-aarch64/emit-relocs-28.s: New test file.
> * ld-aarch64/emit-relocs-28.d: Ditto.
> * ld-aarch64/aarch64-elf.exp: Run new test.
Ping.
--
Regards,
Jiong
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [AArch64][2/2] BFD support BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14
2015-05-20 10:51 [AArch64][2/2] BFD support BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14 Jiong Wang
2015-06-01 9:39 ` Jiong Wang
@ 2015-06-01 14:14 ` Marcus Shawcroft
1 sibling, 0 replies; 3+ messages in thread
From: Marcus Shawcroft @ 2015-06-01 14:14 UTC (permalink / raw)
To: Jiong Wang; +Cc: binutils
On 20 May 2015 at 11:48, Jiong Wang <jiong.wang@arm.com> wrote:
>
> This patch add BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14 relocation supoprt in bfd linker.
>
> native check-ld OK
>
> OK for trunk?
>
>
> 2015-05-19 Jiong Wang <jiong.wang@arm.com>
>
> bfd/
> * elfnn-aarch64.c (aarch64_reloc_got_type): Support
> BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14.
> (elfNN_aarch64_final_link_relocate): Ditto.
> (elfNN_aarch64_gc_swap_hook): Ditto.
> (elfNN_aarch64_check_relocs): Ditto.
> * elfxx-aarch64.c (_bfd_aarch64_elf_put_addend): Ditto.
>
> ld/testsuite/
> * ld-aarch64/emit-relocs-28.s: New test file.
> * ld-aarch64/emit-relocs-28.d: Ditto.
> * ld-aarch64/aarch64-elf.exp: Run new test.
> --
> Regards,
> Jiong
OK /Marcus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-01 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-20 10:51 [AArch64][2/2] BFD support BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14 Jiong Wang
2015-06-01 9:39 ` Jiong Wang
2015-06-01 14:14 ` Marcus Shawcroft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).