From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47531 invoked by alias); 21 Feb 2020 00:55:09 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 47519 invoked by uid 89); 21 Feb 2020 00:55:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*RU:209.85.222.66, HX-Spam-Relays-External:209.85.222.66 X-HELO: mail-ua1-f66.google.com Received: from mail-ua1-f66.google.com (HELO mail-ua1-f66.google.com) (209.85.222.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2020 00:55:08 +0000 Received: by mail-ua1-f66.google.com with SMTP id y3so79864uae.3 for ; Thu, 20 Feb 2020 16:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=roeoo0d37Nh1d+e087lsozFHmOMkTExRDs6Vb6rGZ34=; b=RnH6KBsR855WmDcRcyXFOtOFFKfdtv0CPJLQZjyY32iSYQKuEIa8lUeF5MmTvlYFHY dfk8GEP0BBzBOakfkWzDWRNstczlZ0tZErjpdpOtErThjVKpt19o3wd6gFI9yOthl3qD Rl4sAhJznnF+YHxobDdSApsUcwHt69gPjninnvowUl5M2FyhdocJPrFFt824PVM3O0fJ 042/b5Nfei8ufa8abIggbES89IruM4sk/kO4lrAf5mqj7uf87mLs8qbSgYn/8YPAvAQ6 6kGde3E66Y4EIZ51jwyj44E+dETtI/XP6WfjmQV2kljTOnC+v36N2XVXKHW1dwWCEVCp aUoQ== MIME-Version: 1.0 References: <1581502731-28327-1-git-send-email-nelson.chu@sifive.com> In-Reply-To: <1581502731-28327-1-git-send-email-nelson.chu@sifive.com> From: Jim Wilson Date: Fri, 21 Feb 2020 00:55:00 -0000 Message-ID: Subject: Re: [PATCH v5 0/3] RISC-V: Support more rigorous check for CSR To: Nelson Chu Cc: Binutils , Andrew Burgess , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00504.txt.bz2 On Wed, Feb 12, 2020 at 2:18 AM Nelson Chu wrote: > * [PATCH v5 1/3] RISC-V: Support the ISA-dependent CSR checking. > a. Add missing comments for each function. > b. Add -march=rv32if option to the csr-dw-regnum test case. > c. Report warning messages rather than error for the CSR cheking. > d. Keep the consistent usage in gas/config/tc-riscv.c (from Andrew's suggestion) > d-1. Change the 'typedef struct {...} riscv_csr_extra' to > 'struct riscv_csr_extra {...}'. > d-2. Use 'if (hash_error != NULL)' in init_opcode_hash and riscv_init_csr_hash, since > hash_error is not a boolean. > > * [PATCH v5 2/3] RISC-V: Disable the CSR checking by default. > > * [PATCH v5 3/3] RISC-V: Support the read-only CSR checking. This looks good. I fixed a comment typo in part 3, and rewrote the ChangeLog entries a bit because you didn't mention all of the types, variables, and functions modified by the patches. Andrew Burgess had already approved the gdb parts, so I committed both the binutils and gdb patches. Jim