From: Jim Wilson <jimw@sifive.com>
To: Nelson Chu <nelson.chu@sifive.com>
Cc: Nick Clifton <nickc@redhat.com>, Alex Bradbury <asb@lowrisc.org>,
Kito Cheng <kito.cheng@sifive.com>,
Binutils <binutils@sourceware.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/9] RISC-V: Support version controling for ISA standard extensions and CSR
Date: Mon, 1 Jun 2020 14:35:54 -0700 [thread overview]
Message-ID: <CAFyWVaajfZWBJCecuTnSBEHaTHinoVc3hkq59r-AZcgrLZAUHQ@mail.gmail.com> (raw)
In-Reply-To: <CAJYME4FFQSU-Z4LrGp5-GuaOkyntu2gLApO-PQ2Jvg1a6J6q_Q@mail.gmail.com>
I found another problem with the patches. RISC-V Linux native
gdbserver fails to build. gdbserver/linux-riscv-low.cc includes
include/opcode/riscv.h. Your patch added bfd.h include to that file,
just like 7 other files in that dir. Unfortunately, gdbserver is not
built with -I options pointing at the bfd source and build trees like
gdb is. Also, bfd is configured for the host, and gdbserver is
configured for the target, so including bfd header files in gdbserver
seems wrong. linux-riscv-low.cc is the only one trying to include
header files from include/opcode but that doesn't seem inherently
wrong. We could fix this by moving the parts that gdbserver needs to
another file that is target safe. This is primarily
riscv_insn_length, but might also include other stuff. riscv-opc.h is
probably safe but seems odd, so maybe a riscv-target.h or
riscv-common.h would be better, and add a comment saying that this is
intended to be shared between host and target code. Then gdbserver
can include the safe file and avoid the bfd.h include. Or
alternatively we could duplicate some code and just put it directly in
gdbserver, but I'd prefer to avoid that if we can.
JIm
prev parent reply other threads:[~2020-06-01 21:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 2:55 Nelson Chu
2020-05-06 2:55 ` [PATCH v2 1/9] RISC-V: Remove the redundant gas test file Nelson Chu
2020-05-19 9:07 ` Nelson Chu
2020-05-06 2:55 ` [PATCH v2 2/9] RISC-V: Forgot to update the priv-reg-fail-read-only-01 test case Nelson Chu
2020-05-19 9:07 ` Nelson Chu
2020-05-06 2:55 ` [PATCH v2 3/9] RISC-V: Support GAS option -misa-spec to set ISA versions Nelson Chu
2020-05-19 9:07 ` Nelson Chu
2020-05-06 2:55 ` [PATCH v2 4/9] RISC-V: Support configure options to set ISA versions by default Nelson Chu
2020-05-19 9:07 ` Nelson Chu
2020-05-06 2:55 ` [PATCH v2 5/9] RISC-V: Support version checking for CSR according to privilege spec version Nelson Chu
2020-05-19 9:08 ` Nelson Chu
2020-05-06 2:55 ` [PATCH v2 6/9] RISC-V: Support configure option to choose the " Nelson Chu
2020-05-19 9:08 ` Nelson Chu
2020-05-06 2:55 ` [PATCH v2 7/9] RISC-V: Make privilege spec attributes workable Nelson Chu
2020-05-19 9:08 ` Nelson Chu
2020-05-06 2:55 ` [PATCH v2 8/9] RISC-V: Disassembler dumps the CSR according to the chosen privilege spec Nelson Chu
2020-05-19 9:08 ` Nelson Chu
2020-05-06 2:55 ` [PATCH v2 9/9] RISC-V: Add documents and --help for the new GAS and OBJDUMP options Nelson Chu
2020-05-19 9:08 ` Nelson Chu
2020-05-19 9:07 ` [PATCH v2 0/9] RISC-V: Support version controling for ISA standard extensions and CSR Nelson Chu
2020-05-20 16:27 ` Nick Clifton
2020-05-21 2:38 ` Nelson Chu
2020-05-21 7:29 ` Nick Clifton
2020-05-21 9:11 ` Nelson Chu
2020-05-28 20:09 ` Jim Wilson
2020-05-29 1:02 ` Nelson Chu
2020-06-01 21:35 ` Jim Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyWVaajfZWBJCecuTnSBEHaTHinoVc3hkq59r-AZcgrLZAUHQ@mail.gmail.com \
--to=jimw@sifive.com \
--cc=asb@lowrisc.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=kito.cheng@sifive.com \
--cc=nelson.chu@sifive.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).