From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by sourceware.org (Postfix) with ESMTPS id 2E66B3857C4E for ; Wed, 2 Dec 2020 23:51:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2E66B3857C4E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-qk1-x744.google.com with SMTP id v143so560418qkb.2 for ; Wed, 02 Dec 2020 15:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=icc8wxnpqm8h7A6u58XBKE1nN47EnjmQNQZ4Je21zy0=; b=VDlXXabbNymo9FORH1X7IatvJMoEPKqN08EmFvEr1amGiWyzcMyfeHCcgH6pOJzB/7 eZqA+u/Yk0nZgQtQfhqIh2cJ7NtC7AWnj8CPSEvhAkMxG4ujbj2YmXvzeahYICr1Cg3V nKNhstMGnROVCwUoZEf6OAudVqx4Pu9/FyySEMvgmZeuRHyB/SEvSP+y6RllicbCeCU1 eQs+NAOcv6T6mJPuH6O6aH0EhToJ/menosL+nEM6unuuDht78l9efq242dODOvikiZmf pCdFmej2PC2vorqxjM6x0Je57jBsXPufW7t27LWWVRaShCkGI3sP67KfVdV/InDc5TXa B4QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=icc8wxnpqm8h7A6u58XBKE1nN47EnjmQNQZ4Je21zy0=; b=QQO1Bst5PnMRDFQjfQSZrXYwKHkw8uRwmLJp6LrSUi41BYNGFf6KSZvILHWiOr+9tx 2ozG4oekd0jB/mBv/wPziq26R6xKS2PuEd51zj94VZBDLgu5/uG2PxFK4rbspGKYF58l j7iXojh+lholMgA9uIC0oRjq0jBYRsvTlLd4r3PnBlHl5OSwhDVfdRIYTlQkGuwRoetZ WMCE7vW4zz+mh0JSq4kd1M9CE6+S48OUKLn6Db4fA2RqZm+35LrA8zANXHNeQasNbC+4 zgX6uqrYb/Cs8V+dWAQBJY0JG/wRqi7f+oUOrTJrNxoqCVcvqmtTtdtsKMuzNOd4Su7a YR2Q== X-Gm-Message-State: AOAM530xjKdoJG1BBU52kml5LJn0cYo0uubzJj1bFbQ8UJvw625rmGsN REtACam4pP7ZWE//UQX/hYX1/xQ8pnP/426EH1uOEQ== X-Google-Smtp-Source: ABdhPJxi8EtPAzE0uXQKIPM+NkbKdLZQpe8fNwGU0ILSIcFOItVNiSsM3mNXR31sQlza4mFaCC+FdPgqk1qekjfri3Q= X-Received: by 2002:a37:77c6:: with SMTP id s189mr296921qkc.87.1606953069718; Wed, 02 Dec 2020 15:51:09 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jim Wilson Date: Wed, 2 Dec 2020 15:50:58 -0800 Message-ID: Subject: Re: [PATCH 6/8] bfd/binutils: add support for RISC-V CSRs in core files To: Andrew Burgess Cc: Binutils , gdb-patches@sourceware.org, Nelson Chu , John Baldwin X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2020 23:51:11 -0000 On Wed, Dec 2, 2020 at 9:39 AM Andrew Burgess wrote: > diff --git a/include/elf/common.h b/include/elf/common.h > index 1dbf0b11983..54d5d989a39 100644 > --- a/include/elf/common.h > +++ b/include/elf/common.h > @@ -663,6 +663,8 @@ > /* note name must be "LINUX". */ > #define NT_ARC_V2 0x600 /* ARC HS accumulator/extra > registers. */ > /* note name must be "LINUX". */ > +#define NT_RISCV_CSR 0x501 /* RISC-V Control and Status > Registers */ > + /* note name must be "CORE". */ > #define NT_SIGINFO 0x53494749 /* Fields of siginfo_t. */ > #define NT_FILE 0x46494c45 /* Description of mapped > files. */ > Odd that the 0x5XX numbering was skipped for ARC, though I don't see any reason for it, so it appears OK to use for RISC-V. I would suggest keeping them in numerical order to make the file easier to read, so if you want to use 0x501 put it before the ARC entry. Otherwise, this looks OK to me with a trivial change here. Jim