From: Jim Wilson <jimw@sifive.com>
To: Kuan-Lin Chen <kuanlinchentw@gmail.com>
Cc: "binutils@sourceware.org Development" <binutils@sourceware.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Nelson Chu <nelson.chu@sifive.com>
Subject: Re: [PATCH] RISC-V : Support bitmanip-0.93 ZBA/ZBB/ZBC instructions
Date: Wed, 24 Feb 2021 19:54:47 -0800 [thread overview]
Message-ID: <CAFyWVab_ar7zLiKK2KYJ6g7nf5pXa+TOrHcMZoBmHDnBU2kpPQ@mail.gmail.com> (raw)
In-Reply-To: <CAJr6u0iws2wsQEi1CghksKp26ZhfgyhMkGw4rHiKzaW9Cs0jng@mail.gmail.com>
On Wed, Feb 24, 2021 at 12:50 AM Kuan-Lin Chen <kuanlinchentw@gmail.com>
wrote:
> This patch is to support bitmanip-0.93 ZBA/ZBB/ZBC extensions.
>
ror and rorw don't accept immediates. This would be useful and is
expected, same as how the rv32i sll with immediate is supported as an alias
for slli.
zext.h for rv32 uses the pack encoding, but zext.h for rv64 uses the
packw encoding. You have it using the pack encoding always which is wrong
for rv64.
You are missing a rv64 zbb zext.w. This uses the same encoding as add.uw,
though add.uw itself remains zba. So zext.h should be available for both
zba and zbb. it is an instruction for zbb and an alias for zba, but
probably simpler to just always mark it as an alias.
Otherwise this looks good, just a few small issues to fix.
Jim
next prev parent reply other threads:[~2021-02-25 3:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 8:50 Kuan-Lin Chen
2021-02-24 9:19 ` Jan Beulich
2021-02-24 20:18 ` Jim Wilson
2021-02-24 23:34 ` Jim Wilson
2021-02-25 3:54 ` Jim Wilson [this message]
2021-02-25 8:44 ` Kuan-Lin Chen
2021-02-25 20:21 ` Jim Wilson
2021-02-25 22:51 ` Andrew Waterman
2021-03-03 6:51 ` Kuan-Lin Chen
2021-03-07 18:49 ` Jim Wilson
2021-03-07 18:52 ` Jim Wilson
2021-03-07 21:03 ` Jim Wilson
2021-03-08 5:32 ` Kito Cheng
2021-03-09 1:18 ` Kuan-Lin Chen
2021-03-09 2:01 ` Nelson Chu
2021-03-16 6:54 ` Kuan-Lin Chen
2021-03-16 7:52 ` Nelson Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyWVab_ar7zLiKK2KYJ6g7nf5pXa+TOrHcMZoBmHDnBU2kpPQ@mail.gmail.com \
--to=jimw@sifive.com \
--cc=binutils@sourceware.org \
--cc=kuanlinchentw@gmail.com \
--cc=nelson.chu@sifive.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).