From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24533 invoked by alias); 26 Oct 2017 15:06:16 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 24522 invoked by uid 89); 26 Oct 2017 15:06:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*c:alternative, cary, Cary X-HELO: mail-pg0-f53.google.com Received: from mail-pg0-f53.google.com (HELO mail-pg0-f53.google.com) (74.125.83.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Oct 2017 15:06:14 +0000 Received: by mail-pg0-f53.google.com with SMTP id y5so2910240pgq.7 for ; Thu, 26 Oct 2017 08:06:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tByuZUwu9hKOs1dJrGXf7NRnaLf3DnMtfiaOFmZiHRo=; b=TASZS42MoSDipYIsqzeHBSS1ME44OGrvlMDt44UBi89zFyU6K21v9Zj7DbTS7MGfwd MNmNoIPSOwza8mhEnFNKvBipPjztNDbegoU3egNJ5FZdJ2L+QrGFtHJl3pj6zA/xpxUi k6iywFMYIwGQFhl0WlzGi+fRwLpN4euPvQSOWAasBGm/jgf+FgVhOqoDYbWsrMKj8MeZ 0zQZ6iDbdo6aMzTcCu9Q1GrGFxu11oBbuurDTziDi6M4YQ7P1dLIrq5q5V7disZC1Ixc KR/m6Nr1utUFLEqPIqEr25cXY5mS8B/+HmzNIHL30EWH0b9BIjfTc9aaTF6dgLDjZA3c 7Xag== X-Gm-Message-State: AMCzsaW02XX30u9hS8CteoEi1BMGkLFw/OkvAs1jQNnNb1PiNhWqNULo 3TKK/4jGEQEPRFU+PkLpAbbgG5LkhoWnZs1LoRs= X-Google-Smtp-Source: ABhQp+TbfnKRYOH+opUTEZOYiGbCHa2myB2V7of0FDu2WjV3HEsKThwk/KtLlzcrd6xltB3oiltnXmFpAHnUw6/r2BY= X-Received: by 10.101.81.197 with SMTP id i5mr604007pgq.260.1509030372404; Thu, 26 Oct 2017 08:06:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.165.131 with HTTP; Thu, 26 Oct 2017 08:06:11 -0700 (PDT) Received: by 10.100.165.131 with HTTP; Thu, 26 Oct 2017 08:06:11 -0700 (PDT) In-Reply-To: References: From: Umesh Kalappa Date: Thu, 26 Oct 2017 15:06:00 -0000 Message-ID: Subject: Re: [Patch][Gold] BE8 for ARM To: Cary Coutant Cc: "Bharathi Seshadri (bseshadr)" , "Richard Earnshaw (lists)" , "binutils@sourceware.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00413.txt.bz2 Thanks a lot. Umesh On Oct 20, 2017 9:30 AM, "Cary Coutant" wrote: + unsigned int enable_be8 = parameters->options().be8(); Should be const bool. case Insn_template::THUMB16_TYPE: - elfcpp::Swap<16, big_endian>::writeval(pov, insns[i].data() & 0xffff); + if (enable_be8) elfcpp::Swap<16, false>::writeval(pov, insns[i].data() & 0xffff); + else + elfcpp::Swap<16, big_endian>::writeval(pov, insns[i].data() & 0xffff); break; + if (enable_be8) + elfcpp::Swap<16, false>::writeval( + pov,this->thumb16_special(i)); + else + elfcpp::Swap<16, big_endian>::writeval( + pov,this->thumb16_special(i)); + if (enable_be8) + { + elfcpp::Swap<16, false>::writeval(pov, hi); + elfcpp::Swap<16, false>::writeval(pov + 2, lo); + } + else + { + elfcpp::Swap<16, big_endian>::writeval(pov, hi); + elfcpp::Swap<16, big_endian>::writeval(pov + 2, lo); + } + if (enable_be8) + elfcpp::Swap<32, false>::writeval(pov, insns[i].data()); + else + elfcpp::Swap<32, big_endian>::writeval(pov, insns[i].data()); + break; These are still not indented correctly. Check the tab stop settings in your editor -- it looks like you may have your editor set to tabs every 4 columns. - for (unsigned int i = 1; i < shnum; ++i) + for (static unsigned int i = 1; i < shnum; ++i) What are you trying to do here? I'm pretty sure you don't mean to use a static here. I've fixed these and applied the patch for you. Thanks! -cary