public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix an internal error in do_print_to_mapfile seen with gold on arm
@ 2015-02-27 14:46 Khem Raj
  2015-02-28  0:10 ` Cary Coutant
  0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2015-02-27 14:46 UTC (permalink / raw)
  To: binutils; +Cc: Khem Raj

This is due to missing implementation of do_print_to_mapfile for
atrributea section (ARM.attributes), it started to show up after fix
for PR gold/16980 was installed

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 gold/ChangeLog    | 5 +++++
 gold/attributes.h | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/gold/ChangeLog b/gold/ChangeLog
index 31d123e..6d9da81 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,8 @@
+2015-02-27  Khem Raj  <raj.khem@gmail.com>
+
+	* attributes.h (class Output_attributes_section_data ): Add
+	do_print_to_mapfile function.
+
 2015-02-24  Alan Modra  <amodra@gmail.com>
 
 	PR 18010
diff --git a/gold/attributes.h b/gold/attributes.h
index c0b171f..6e3ab8c 100644
--- a/gold/attributes.h
+++ b/gold/attributes.h
@@ -387,6 +387,10 @@ class Output_attributes_section_data : public Output_section_data
   { }
 
  protected:
+  // Write to a map file.
+  void
+  do_print_to_mapfile(Mapfile* mapfile) const
+  { mapfile->print_output_data(this, _("** attributes")); }
   // Write the data to the output file.
   void
   do_write(Output_file*);
-- 
2.1.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix an internal error in do_print_to_mapfile seen with gold on arm
  2015-02-27 14:46 [PATCH] Fix an internal error in do_print_to_mapfile seen with gold on arm Khem Raj
@ 2015-02-28  0:10 ` Cary Coutant
  2015-02-28 21:27   ` Khem Raj
  0 siblings, 1 reply; 4+ messages in thread
From: Cary Coutant @ 2015-02-28  0:10 UTC (permalink / raw)
  To: Khem Raj; +Cc: Binutils

> +2015-02-27  Khem Raj  <raj.khem@gmail.com>
> +
> +       * attributes.h (class Output_attributes_section_data ): Add
> +       do_print_to_mapfile function.

This is OK for trunk. Thanks!

-cary

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix an internal error in do_print_to_mapfile seen with gold on arm
  2015-02-28  0:10 ` Cary Coutant
@ 2015-02-28 21:27   ` Khem Raj
  2015-03-02 18:11     ` Cary Coutant
  0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2015-02-28 21:27 UTC (permalink / raw)
  To: Cary Coutant; +Cc: Binutils


> On Feb 27, 2015, at 10:09 AM, Cary Coutant <ccoutant@google.com> wrote:
> 
>> +2015-02-27  Khem Raj  <raj.khem@gmail.com>
>> +
>> +       * attributes.h (class Output_attributes_section_data ): Add
>> +       do_print_to_mapfile function.
> 
> This is OK for trunk. Thanks!
> 

Thanks. Can you push it in too ? I do not have commit permissions

> -cary

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix an internal error in do_print_to_mapfile seen with gold on arm
  2015-02-28 21:27   ` Khem Raj
@ 2015-03-02 18:11     ` Cary Coutant
  0 siblings, 0 replies; 4+ messages in thread
From: Cary Coutant @ 2015-03-02 18:11 UTC (permalink / raw)
  To: Khem Raj; +Cc: Binutils

Done.

-cary

On Fri, Feb 27, 2015 at 7:23 PM, Khem Raj <raj.khem@gmail.com> wrote:
>
>> On Feb 27, 2015, at 10:09 AM, Cary Coutant <ccoutant@google.com> wrote:
>>
>>> +2015-02-27  Khem Raj  <raj.khem@gmail.com>
>>> +
>>> +       * attributes.h (class Output_attributes_section_data ): Add
>>> +       do_print_to_mapfile function.
>>
>> This is OK for trunk. Thanks!
>>
>
> Thanks. Can you push it in too ? I do not have commit permissions
>
>> -cary
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-03-02 18:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-27 14:46 [PATCH] Fix an internal error in do_print_to_mapfile seen with gold on arm Khem Raj
2015-02-28  0:10 ` Cary Coutant
2015-02-28 21:27   ` Khem Raj
2015-03-02 18:11     ` Cary Coutant

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).