From: Cary Coutant <ccoutant@google.com>
To: Jing Yu <jingyu@google.com>
Cc: binutils <binutils@sourceware.org>,
Doug Kwan <dougkwan@google.com>, Han Shen <shenhan@google.com>
Subject: Re: [gold][aarch64]patch2: link helloworld
Date: Fri, 08 Aug 2014 16:33:00 -0000 [thread overview]
Message-ID: <CAHACq4okukFwS=8vuBpgva4hj66nFYEAq-batXaK3wokYGdqYg@mail.gmail.com> (raw)
In-Reply-To: <CAJ_rGWROP3wgUxxLFZZG806eOZJm75ec1A_A-pVovDg6AdLzZA@mail.gmail.com>
> elfcpp/Changelog:
> 2014-08-07 Jing Yu <jingyu@google.com>
> Han Shen <shenhan@google.com>
>
> * aarch64.h(enum): Replace withdrawn with R_AARCH64_withdrawn.
>
>
> gold/Changelog:
> 2014-08-07 Jing Yu <jingyu@google.com>
> Han Shen <shenhan@google.com>
>
> * Makefile.am(HFILES): Add aarch64-reloc-property.h.
> (DEFFILES): add aarch64-reloc.def.
> (TARGETSOURCES): Add aarch64-reloc-property.cc.
> (ALL_TARGETOBJS): Add aarch64-reloc-property.$(OBJEXT).
> * Makefile.in: Regenerate.
> * aarch64-reloc-property.cc: New file.
> * aarch64-reloc-property.h: New file.
> * aarch64-reloc.def: New file.
> * aarch64.cc: Include aarch64-reloc-property.h. Replace spaces
> with tab to make the format consistent.
> (Output_data_got_aarch64::symbol_table_): New method.
> (Target_aarch64::do_plt_address_for_global): New method.
> (Target_aarch64::do_plt_address_for_local): New method.
> (Target_aarch64::do_select_as_default_target): New method.
> (Target_aarch64::do_make_data_plt): New method.
> (Target_aarch64::make_data_plt): New method.
> (Output_data_plt_aarch64::has_irelative_section): New method.
> (Output_data_plt_aarch64::address_for_global): New method.
> (Output_data_plt_aarch64::address_for_local): New method.
> (Output_data_plt_aarch64::irelative_rel_): New parameter.
> (Output_data_plt_aarch64::add_entry): Implement contents.
> (Output_data_plt_aarch64::set_final_data_size): Fix typo.
> (Output_data_plt_aarch64::do_write): Remove useless got_base. Set
> the got_pov entry to plt0.
> (Output_data_plt_aarch64_standard::do_fill_first_plt_entry):
> Implement contents.
> (Output_data_plt_aarch64_standard::do_fill_plt_entry): Implement.
> (AArch64_howto): New struct.
> (aarch64_howto[]): New static const array.
> (AArch64_relocate_functions): New class
> (Target_aarch64::Scan::get_reference_flags): Remove method.
> (Target_aarch64::Scan::local): Implement to support a few relocations.
> (Target_aarch64::Scan::global): Implement to support a few relocations.
> (Target_aarch64::make_plt_section): Implement contents.
> (Target_aarch64::make_plt_entry): Implement contents.
> (Target_aarch64::do_finalize_sections): Implement contents.
> (Target_aarch64::Relocate::relocate): Implement a few relocations.
> (Target_aarch64::relocate_section): Implement contents.
+// Above is from Table 4-10, Relocations for control-fl
Looks like this comment got truncated.
+// Above is from Table 4-17, Initial Exec TLS relocatios, 539-543.
"relocations"
+ Page(typename elfcpp::Elf_types<size>::Elf_Addr address)
It might be worth making a class-local typedef for this type.
+ return (address &
+ (~(typename elfcpp::Elf_types<size>::Elf_Addr)0xFFF));
Please use static_cast (which will be more manageable with the local typedef).
OK with these changes (please post the patch as committed for
reference). Thanks!
-cary
next prev parent reply other threads:[~2014-08-08 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 2:05 Jing Yu
2014-08-04 9:53 ` Jiong Wang
2014-08-05 17:49 ` Cary Coutant
2014-08-07 23:52 ` Jing Yu
2014-08-08 16:33 ` Cary Coutant [this message]
2014-08-08 21:44 ` Jing Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHACq4okukFwS=8vuBpgva4hj66nFYEAq-batXaK3wokYGdqYg@mail.gmail.com' \
--to=ccoutant@google.com \
--cc=binutils@sourceware.org \
--cc=dougkwan@google.com \
--cc=jingyu@google.com \
--cc=shenhan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).