From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20208 invoked by alias); 8 Aug 2014 16:33:26 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 20197 invoked by uid 89); 8 Aug 2014 16:33:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f53.google.com Received: from mail-qa0-f53.google.com (HELO mail-qa0-f53.google.com) (209.85.216.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 08 Aug 2014 16:33:24 +0000 Received: by mail-qa0-f53.google.com with SMTP id v10so5870331qac.12 for ; Fri, 08 Aug 2014 09:33:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=gjj+tR/r3IzV5PsNx7CIa2YCPvUfphLXI33Wi197z+0=; b=T1JsGxPtV4ed+o4tf4Bp+4wK4sAt5lsoUm67BEi6Rg1TLzwjvW7oQO9PZkoExQHkcX xA621yXI7BvzH60GSE+7D7v282gC3Vvo+EQpRMUAoOyMp2J+eBeib2rXyvokv2zt9Q+A hrooavW94hwZ9Pr8kWk/rQI6ts5GEX0i40wFbmruxzugYNGVIDeRFsL8EU8gtC+aVoGV JGATMjh2BP5QSBQ4crFUDFcV2Vx0Vhwj1zBq+wxOsrTa+Cv6FsaAi6Xn94zfAa0iakp+ 1EtNVFoz07MDBawTl7Lgl8yxjPuW6c0IBZp5ZccWeXJGxCyphC48kpn8Lnw8g3OjAvnu ND2Q== X-Gm-Message-State: ALoCoQlMVDzbdJYHgJaNipd/MKSEh7qouv9avTYi9dwhp6IrRfQVLhhsEx0XOTCyHiLztDB0ICjb MIME-Version: 1.0 X-Received: by 10.229.103.70 with SMTP id j6mr39019005qco.27.1407515602021; Fri, 08 Aug 2014 09:33:22 -0700 (PDT) Received: by 10.140.85.113 with HTTP; Fri, 8 Aug 2014 09:33:21 -0700 (PDT) In-Reply-To: References: Date: Fri, 08 Aug 2014 16:33:00 -0000 Message-ID: Subject: Re: [gold][aarch64]patch2: link helloworld From: Cary Coutant To: Jing Yu Cc: binutils , Doug Kwan , Han Shen Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00064.txt.bz2 > elfcpp/Changelog: > 2014-08-07 Jing Yu > Han Shen > > * aarch64.h(enum): Replace withdrawn with R_AARCH64_withdrawn. > > > gold/Changelog: > 2014-08-07 Jing Yu > Han Shen > > * Makefile.am(HFILES): Add aarch64-reloc-property.h. > (DEFFILES): add aarch64-reloc.def. > (TARGETSOURCES): Add aarch64-reloc-property.cc. > (ALL_TARGETOBJS): Add aarch64-reloc-property.$(OBJEXT). > * Makefile.in: Regenerate. > * aarch64-reloc-property.cc: New file. > * aarch64-reloc-property.h: New file. > * aarch64-reloc.def: New file. > * aarch64.cc: Include aarch64-reloc-property.h. Replace spaces > with tab to make the format consistent. > (Output_data_got_aarch64::symbol_table_): New method. > (Target_aarch64::do_plt_address_for_global): New method. > (Target_aarch64::do_plt_address_for_local): New method. > (Target_aarch64::do_select_as_default_target): New method. > (Target_aarch64::do_make_data_plt): New method. > (Target_aarch64::make_data_plt): New method. > (Output_data_plt_aarch64::has_irelative_section): New method. > (Output_data_plt_aarch64::address_for_global): New method. > (Output_data_plt_aarch64::address_for_local): New method. > (Output_data_plt_aarch64::irelative_rel_): New parameter. > (Output_data_plt_aarch64::add_entry): Implement contents. > (Output_data_plt_aarch64::set_final_data_size): Fix typo. > (Output_data_plt_aarch64::do_write): Remove useless got_base. Set > the got_pov entry to plt0. > (Output_data_plt_aarch64_standard::do_fill_first_plt_entry): > Implement contents. > (Output_data_plt_aarch64_standard::do_fill_plt_entry): Implement. > (AArch64_howto): New struct. > (aarch64_howto[]): New static const array. > (AArch64_relocate_functions): New class > (Target_aarch64::Scan::get_reference_flags): Remove method. > (Target_aarch64::Scan::local): Implement to support a few relocations. > (Target_aarch64::Scan::global): Implement to support a few relocations. > (Target_aarch64::make_plt_section): Implement contents. > (Target_aarch64::make_plt_entry): Implement contents. > (Target_aarch64::do_finalize_sections): Implement contents. > (Target_aarch64::Relocate::relocate): Implement a few relocations. > (Target_aarch64::relocate_section): Implement contents. +// Above is from Table 4-10, Relocations for control-fl Looks like this comment got truncated. +// Above is from Table 4-17, Initial Exec TLS relocatios, 539-543. "relocations" + Page(typename elfcpp::Elf_types::Elf_Addr address) It might be worth making a class-local typedef for this type. + return (address & + (~(typename elfcpp::Elf_types::Elf_Addr)0xFFF)); Please use static_cast (which will be more manageable with the local typedef). OK with these changes (please post the patch as committed for reference). Thanks! -cary