From: Cary Coutant <ccoutant@google.com>
To: Roland McGrath <mcgrathr@google.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] gold: remove unused private members
Date: Fri, 11 Oct 2013 21:03:00 -0000 [thread overview]
Message-ID: <CAHACq4p2xaV+CqCCnna4HS51WiRSUHRzjmj+UTS03q3TCz3pCw@mail.gmail.com> (raw)
In-Reply-To: <CAB=4xhq1ZM7AtPL7-1S9EdJ=jq2JhpT28Ss0Z_fcQEto2t0ikw@mail.gmail.com>
> gold/
> * i386.cc (Target_i386): Remove unused member dynbss_.
This appears to be unused in all the other target-specific files as
well. I believe it was replaced by Copy_relocs::dynbss_. While you're
cleaning it up, please remove it from arm.cc, powerpc.cc, sparc.cc,
tilegc.cc, and x86_64.cc.
> * dwarf_reader.h (Dwarf_info_reader): Remove unused members
> type_signature_, type_offset_.
> * plugin.h (Plugin_hook): Remove unused member layout_.
> * readsyms.h (Add_symbols): Remove unused members dirpath_, dirindex_,
> mapfile_.
> (Read_member): Remove unused members input_objects_, symtab_,
> mapfile_, layout_.
> (Check_library): Remove unused member symtab_.
> * archive.h (Lib_group): Remove unused member lib_.
> * archive.cc (Lib_group::Lib_group): Update initializer.
> * incremental.h (Incremental_binary): Remove unused member target_.
> (Incremental_script_entry): Removed unused member script_.
> * layout.h (Write_symbols_task): Remove unused member input_objects_.
> * icf.h (Icf): Remove unused member num_tracked_relocs.
This is OK with the changes noted above. Thanks.
-cary
next prev parent reply other threads:[~2013-10-11 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 18:21 Roland McGrath
2013-10-11 21:03 ` Cary Coutant [this message]
2013-10-11 21:24 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHACq4p2xaV+CqCCnna4HS51WiRSUHRzjmj+UTS03q3TCz3pCw@mail.gmail.com \
--to=ccoutant@google.com \
--cc=binutils@sourceware.org \
--cc=mcgrathr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).