From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22592 invoked by alias); 11 Oct 2013 21:03:15 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 22582 invoked by uid 89); 11 Oct 2013 21:03:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f53.google.com Received: from mail-pb0-f53.google.com (HELO mail-pb0-f53.google.com) (209.85.160.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 11 Oct 2013 21:03:14 +0000 Received: by mail-pb0-f53.google.com with SMTP id up15so4734909pbc.26 for ; Fri, 11 Oct 2013 14:03:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=B6QUYRf9LVLIljxkgcYyK8LGt4+owkDsVO6bm0HxTsY=; b=Fw4cSxpsA4/drua+TyhFLBWtUzH3D/nEVHMPAl0vENiOYEmjR9r+NwrpxnrISCeBYe Gp6uCLtgdLqyTbPrbEHC4EIOdeb6XNYOS317vNQIz0LJpW7lUTWEGFV3kRqr7LNtABsF PYMaP54+wHCHZBIUZbADTZklkLfwpf9GDsTTu8GL4R7lfJYvGzfp8Qth7Qh/XW2n2zui JKuSBAn5i+kkJ4cHq7UdOb0VMtgDIzh/AVA5HrM8uvjFjq6z+GIp7whsSlhHDiS5xmvY vqKEYXtnjm0KacAC2TFVlmqJbZ1WpaI5l7aVaAAit4pehFa+vZtHZNOlNTBRR9XIME2S 4aqw== X-Gm-Message-State: ALoCoQnda+Mn6Zb80ul8UzHUuQO5c2I5xE02zJ7tHCI8ThHuogmctZDyGDBrTiiKgp0LxYI1UzBCJHfR/GMV1bBvXPYbMCQ1VMWD/8AM64UmhKPsIODOUjKTci1HhCS/B0USTK0hyMB3x5Cmub8W9i3hMmw76H4RzG7EdzlFadxf/N2LaBzlKHlVZkHAv0HvYbIitYNSD1DV5a1IH7fh79+Pr0eIaVqPFg== MIME-Version: 1.0 X-Received: by 10.66.25.173 with SMTP id d13mr23332895pag.146.1381525392209; Fri, 11 Oct 2013 14:03:12 -0700 (PDT) Received: by 10.68.8.101 with HTTP; Fri, 11 Oct 2013 14:03:12 -0700 (PDT) In-Reply-To: References: Date: Fri, 11 Oct 2013 21:03:00 -0000 Message-ID: Subject: Re: [PATCH] gold: remove unused private members From: Cary Coutant To: Roland McGrath Cc: "binutils@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00179.txt.bz2 > gold/ > * i386.cc (Target_i386): Remove unused member dynbss_. This appears to be unused in all the other target-specific files as well. I believe it was replaced by Copy_relocs::dynbss_. While you're cleaning it up, please remove it from arm.cc, powerpc.cc, sparc.cc, tilegc.cc, and x86_64.cc. > * dwarf_reader.h (Dwarf_info_reader): Remove unused members > type_signature_, type_offset_. > * plugin.h (Plugin_hook): Remove unused member layout_. > * readsyms.h (Add_symbols): Remove unused members dirpath_, dirindex_, > mapfile_. > (Read_member): Remove unused members input_objects_, symtab_, > mapfile_, layout_. > (Check_library): Remove unused member symtab_. > * archive.h (Lib_group): Remove unused member lib_. > * archive.cc (Lib_group::Lib_group): Update initializer. > * incremental.h (Incremental_binary): Remove unused member target_. > (Incremental_script_entry): Removed unused member script_. > * layout.h (Write_symbols_task): Remove unused member input_objects_. > * icf.h (Icf): Remove unused member num_tracked_relocs. This is OK with the changes noted above. Thanks. -cary