From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=wU7D=5A=adacore.com=chigot@sourceware.org>
Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531])
	by sourceware.org (Postfix) with ESMTPS id 828B93858D1E
	for <binutils@sourceware.org>; Tue,  3 Jan 2023 16:21:26 +0000 (GMT)
Received: by mail-pg1-x531.google.com with SMTP id f3so20453513pgc.2
        for <binutils@sourceware.org>; Tue, 03 Jan 2023 08:21:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=adacore.com; s=google;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=pqsr2coOVT7uZMj6APA8BItiTq7sgmY+pre76NcBGtc=;
        b=U9cB6eKEopkMIiHen5rPw4UVi40scx/1vzWuXh6bXdmafyv6o3E6h3Fm5mG5sHOmm1
         MbW61FkoUWY4dz6BuNMiqkK+jWmGja3d2DpW3kl8dmvk3QUD+sHiwnxkPZtd9GVfZmwP
         lpDG2EHAkANE7bUFozn8oPjIEbvCG8TBMuXFFVJ+3sIaQay5gR50N5kK8ws5gNBkDt//
         GmVYPqV4nltW92igeQEWK/cn5GCVvFxz24Io1aORY6m0A2TB11GPLnlmjRzoqVHRUt2l
         HGsRHtQ4uY1lzFCUAGkrdIYjTSFukFbYp8BPODWG45fDLBRJsX53Zk3MiyCXVVEI6uqv
         pGtQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=pqsr2coOVT7uZMj6APA8BItiTq7sgmY+pre76NcBGtc=;
        b=zWWawilsMrW9p5l8FilMnunhcU26krXhiAqhjxRsO5e/Wt4hCEbOfYXQsRERIfbBfI
         8zhZKPURWtF9hLIEjtTexWZI5Qyv1QQWQPspalvk5tOAIyNlymfQ9ZRjnoQWdxvdwJZM
         UMt4zBciQHBQLCz7JiYAPAxmUr5I7rCWKCz5qu1jsOYIjUAdpzt4/DxjH/arqaiOy5lA
         bxjTPvsu+HIyxJSaxEME25m5HojaPzuwW1cO8Q7/hHbLj8iIfHTeNNW1/IQP9sj4RcUH
         +hWTjmr+axBC/L52bWINPz8jKiJDZfXsXxxPsSRJO6ojasiziVgOD3EITgBWAcMUUcM6
         OG6Q==
X-Gm-Message-State: AFqh2krj0VmXp5d5p5GMigSIgSmVFYu/82yTAUOWUjlZDXbJYYvSqgnu
	31SkhZnii3qqQGOTwkCeMbn/FY+qGXQOTFd9TVc0/A==
X-Google-Smtp-Source: AMrXdXuT0+AWF82fqQ/WA5TnICsvaoOeJoQ03P4E8lHtKPQ8XfJgFThnQT+4dC+rHbYjs8URqy6smCuaJ4nIgUh3fnY=
X-Received: by 2002:a65:6946:0:b0:470:60a5:146d with SMTP id
 w6-20020a656946000000b0047060a5146dmr3126800pgq.156.1672762885596; Tue, 03
 Jan 2023 08:21:25 -0800 (PST)
MIME-Version: 1.0
References: <20230103135330.1225218-1-chigot@adacore.com> <CA+=Sn1nKO9ENAGxCPpGhf3BhVO1YBa=crYtZdgjv-BQkRLV0Hg@mail.gmail.com>
In-Reply-To: <CA+=Sn1nKO9ENAGxCPpGhf3BhVO1YBa=crYtZdgjv-BQkRLV0Hg@mail.gmail.com>
From: =?UTF-8?Q?Cl=C3=A9ment_Chigot?= <chigot@adacore.com>
Date: Tue, 3 Jan 2023 17:21:14 +0100
Message-ID: <CAJ307EgBrJc8mpUaRTSPmm61dWWKGACUaVoTkbQKnr64xpFeEA@mail.gmail.com>
Subject: Re: [PATCH] configure: remove dependencies on gmp and mpfr when gdb
 is disabled
To: Andrew Pinski <pinskia@gmail.com>
Cc: binutils@sourceware.org, nickc@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

Hi Andrew,

On Tue, Jan 3, 2023 at 4:59 PM Andrew Pinski <pinskia@gmail.com> wrote:
>
> On Tue, Jan 3, 2023 at 5:53 AM Cl=C3=A9ment Chigot <chigot@adacore.com> w=
rote:
> >
> > Since 991180627851801f1999d1ebbc0e569a17e47c74, the configure checks
> > about GMP and MPFR for gdb builds have been moved to the toplevel
> > configure.
> > However, it doesn't take into account the --disable-gdb option. Meaning
> > that a build without gdb will require these libraries even if not
> > needed.
>
> Here is a much simpler patch and disables the whole check for gmp/mpfr
> rather than just disables the error message, it is like the gdbserver
> check earlier:
> diff --git a/configure.ac b/configure.ac
> index 3a1eb0357e5..c184dc27201 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1585,7 +1585,9 @@ if test -d ${srcdir}/gcc ; then
>    require_mpc=3Dyes
>  fi
>  if test -d ${srcdir}/gdb ; then
> -  require_gmp=3Dyes
> +  if test x$enable_gdb =3D x; then
> +    require_gmp=3Dyes
> +  fi
>  fi
>
>  gmplibs=3D"-lmpfr -lgmp"

Indeed, thanks for that.

However, it should be "test x$enable_gdb !=3D xno". Otherwise,
require_gmp is also disabled when gdb is explicitly enable (with
--enable-gdb).
But as all the similar patterns are similar to yours, I'm wondering if
there isn't something wrong here.

Thanks,
Cl=C3=A9ment