From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by sourceware.org (Postfix) with ESMTPS id 585CA3858D1E for ; Thu, 10 Nov 2022 07:54:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 585CA3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-13be3ef361dso1340271fac.12 for ; Wed, 09 Nov 2022 23:54:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JnXQ3IhmBh8LhR8JbiCsh2xz+LMG7HcVUgi3A1aQ524=; b=gO3LVVnMChTJSS/n3ywS7wh4iODl4BV1ikbQhwYIoWuShKY+jJ+g1NrpqPjY9o7ZBa wAy/d8QphEXbnzQCDGY6DQvM+Aa2NM9Oc8dB+Lold2eEipdrbzXczUWcFODXmA2N/UuT ApYXDtZGIBqWq2lhul530/02GN9CVXkmB+kZOC5UE+Yivi6xFLJlmQhZzCD4jWOKs4Hz /EtXekA6iu/gY+vZ9sTxUyzrKTg0XvRk3y4640etw4pcqOY9uDiL12rzvf852+A4WZZv nb4aq7ZbI8LGwtuCsd2gOAZ59+nM1sj/OlL4l0mr/1bcYSBhVFGURMQi8J5ylMGHyiq4 gFiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JnXQ3IhmBh8LhR8JbiCsh2xz+LMG7HcVUgi3A1aQ524=; b=ng0aP9Tlh+noQk/vDe3PyphIK4D+f+15y+O5yr4zyd9BMhYPuv8VMFP+Ayod2GjZRz V4vk43do46wg3U4lVYVUiC4a+hHnADvGA/GV9jW3y1erDtfpRzERpKBXLDuKXnyftRvt 2FG/+6h9iSfjYuTmo9RmPzoS+1W9NoV3b7U5c+GdlK9I5ZwCccqVb7hq0vz8Z9LQ7w0t Man6xaraFSgQ7GwZ3qjTLhFEbDY0Wdr0jRLvxElxBZ8O8wXd1GQGyuWH9n1bzoXJdrf9 IJ1nL65Lx71+ePLhR2gImahmIoBzcg4upu8lhsQXbLGWQytLOEAlxVkAq4Kacq8RBKGW 40nQ== X-Gm-Message-State: ACrzQf0ZUPhWFLyz8RyEg1rvnLYbfq90ZLSW4t77Sfy8gi7ODeEuGPtz XCMYTyanz9EfFgOF5tSH0eIayDfkAD6FqBJajLkQiw== X-Google-Smtp-Source: AMsMyM4eoKW7jpJjKcWDl5iwbJVd1JmiHB/rG6wnRE4FxcbasNFcT7pcXgT3vZn7AZk3IlXtyqS0+e+iJtgplWgilOs= X-Received: by 2002:a05:6870:56a9:b0:13b:d2ae:ed90 with SMTP id p41-20020a05687056a900b0013bd2aeed90mr47614730oao.198.1668066854728; Wed, 09 Nov 2022 23:54:14 -0800 (PST) MIME-Version: 1.0 References: <20221109162611.760465-1-chigot@adacore.com> In-Reply-To: From: =?UTF-8?Q?Cl=C3=A9ment_Chigot?= Date: Thu, 10 Nov 2022 08:54:04 +0100 Message-ID: Subject: Re: [PATCH] ld/testsuite: skip ld-size when -shared is not supported To: Alan Modra Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 9, 2022 at 10:37 PM Alan Modra wrote: > > On Wed, Nov 09, 2022 at 05:26:11PM +0100, Cl=C3=A9ment Chigot via Binutil= s wrote: > > * testsuite/ld-size/size.exp: Skip when -shared is not > > supported. > > What does this catch that isn't already covered by the target test? It does in a wide approach. But it doesn't allow custom targets (as I do) where shared support is explicitly disabled. It might not have a big impact but it looks logical to me to check for -shared (both linker and compiler by the way) before running any tests related to that. I've pushed other similar patches recently (see ld-arm or ld-shared). Thanks, Cl=C3=A9ment