From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 456863858D33 for ; Thu, 20 Apr 2023 08:56:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 456863858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-63b7096e2e4so724696b3a.2 for ; Thu, 20 Apr 2023 01:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1681980977; x=1684572977; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=efqLwDbaMrhntirPFf0KCQLwmv3d394m6vffPL8A7WU=; b=GdhwxcM/9nVKTG76qOgPGYo5Vyh6EjEAycZ7ZSc3H0xMk6v2KratDz2DI6OHRokczX 3FXZg8vnP2w37URj/cxQpA8YnfbmUayEvZU6iHvXJsOuM82Ppqz1EBpxBOs7NPo1L9zF V39W9yj/oMLyWE1sSQNefr2FHcNViTj6S4teH9VFEyiLg0EdSf5BHoOPQp1xy+mJqNb+ oAt++it2OZK/gdovHX4No0RVPfCVruu7XkP9HBqnTCPUvKBB+pDnUp3plre2k7foA3Ow Noy1pGI9RGIuOa5SMa56nAi1NbeAjp9SWobVvk3HOMwN/nsvAwhRpCySoJmmH2XBbWaQ zJLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681980977; x=1684572977; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=efqLwDbaMrhntirPFf0KCQLwmv3d394m6vffPL8A7WU=; b=hLl1xaNFAHi3+JpYErK+Pevly92Ysq2oU1zKyrKVGNK70caBEiwLN+kRwZcYAt2r8r YKNYA+/8QVAb2XYZs5FIiWGO23GpCUiy2ghf7CITXpfBg1vUvyCOjoqYjFeAJX5FYOlG clgzOF2B4SN5BQ+nNfA0X2oV66HiIR321fta78lDLTkeFYEuJ+y0yYkd/xzSx9j0Yqu/ Q/2p+mAHwoqpqOz9x+e/1v7mGFgWosGwobeUzBB6O9Z9L1+eT8GgiwBvjZe6Y4WMnJy6 89tWwn4YmLX4QlWB2bnXPCDvqaIyxeROXxFjnaMZTUhPXaa2PXHuJU2Crs3jM7dIzUNq WcCg== X-Gm-Message-State: AAQBX9eLfAdVmAZOz9Pg7jzJNWth5NklQshQMz4d61vzV1E1eYVKox5k LOZ3r4hWYeZeYl0VGHCEUlahp8flw152IbMEnnFQIw== X-Google-Smtp-Source: AKy350b9wICG8GUro08YoZL/makjAobKfWBJwYj88Dierrn4JxUHZjwGkZmwGRH/Q+Lui/19u50jwQrfgyih39oOhxE= X-Received: by 2002:a05:6a20:2450:b0:f0:6def:6b93 with SMTP id t16-20020a056a20245000b000f06def6b93mr1393000pzc.56.1681980977153; Thu, 20 Apr 2023 01:56:17 -0700 (PDT) MIME-Version: 1.0 References: <2b0ca132-9d85-86a8-8b91-828fa66881b8@suse.com> In-Reply-To: <2b0ca132-9d85-86a8-8b91-828fa66881b8@suse.com> From: =?UTF-8?Q?Cl=C3=A9ment_Chigot?= Date: Thu, 20 Apr 2023 10:56:06 +0200 Message-ID: Subject: Re: [PATCH v2 13/14] x86: convert testcases to use .insn To: Jan Beulich Cc: Binutils , "H.J. Lu" , "Jiang, Haochen" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, > --- a/gas/testsuite/gas/i386/x86-64-opcode.s > +++ b/gas/testsuite/gas/i386/x86-64-opcode.s > @@ -458,16 +458,16 @@ > int3 > int $0x90 > > - .byte 0xf6, 0xc9, 0x01 > - .byte 0x66, 0xf7, 0xc9, 0x02, 0x00 > - .byte 0xf7, 0xc9, 0x04, 0x00, 0x00, 0x00 > - .byte 0x48, 0xf7, 0xc9, 0x08, 0x00, 0x00, 0x00 > - .byte 0xc0, 0xf0, 0x02 > - .byte 0xc1, 0xf0, 0x01 > - .byte 0x48, 0xc1, 0xf0, 0x01 > - .byte 0xd0, 0xf0 > - .byte 0xd1, 0xf0 > - .byte 0x48, 0xd1, 0xf0 > - .byte 0xd2, 0xf0 > - .byte 0xd3, 0xf0 > - .byte 0x48, 0xd3, 0xf0 > + .insn 0xf6/1, $1, %cl > + .insn 0xf7/1, $2{:u16}, %cx > + .insn 0xf7/1, $4{:u32}, %ecx > + .insn 0xf7/1, $8{:s32}, %rcx > + .insn 0xc0/6, $2, %al > + .insn 0xc1/6, $1, %eax > + .insn 0xc1/6, $1, %rax > + .insn 0xd0/6, %al > + .insn 0xd1/6, %eax > + .insn 0xd1/6, %rax > + .insn 0xd2/6, %al > + .insn 0xd3/6, %eax > + .insn 0xd3/6, %rax The test is failing on my side when building with --target=3Dx86_64-elf. I'm not sure what's wrong yet but gas seems to ignore everything after "/": | $ ../../binutils/objdump -drw tmpdir/x86-64-opcode.o | ... | 4ea: f6 f7 div %bh | 4ec: f7 f7 div %edi | 4ee: c0 c1 c1 rol $0xc1,%cl | 4f1: d0 d1 rcl %cl | 4f3: d1 d2 rcl %edx | 4f5: d3 d3 rcl %cl,%ebx Thanks, Cl=C3=A9ment