From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id D2E9D3857836 for ; Tue, 28 Jun 2022 09:38:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2E9D3857836 Received: by mail-qk1-x72d.google.com with SMTP id u124so9095479qkb.12 for ; Tue, 28 Jun 2022 02:38:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=itcBxUg5NjsnUn3S3cJp9z9KjpUb8jNv4v7eFcvUK0o=; b=KbQsc9i2ncFMIYdGWwPA2r2/6/j+mrCH3MvF36CsIrvEhe2XM2Meo9g+liNxFAqpsj 9EtPafKJ9uxqmFFwCkACT6NrUtIPgOCF2ICdqiYqm3z0QshlGeHAAiLq6YBLL8gwhyvo O1TwhVZ5+OZ855oSxQG2X4LsU5dS2JyEI8GyjFCi6AHZYWFLC6lcWbyoyVIsOk2WmDLc /c/LtK6dB1D6EWWp6VBNnbgw+K2lN2bXNZaO3K61EI4blPkfMqIvz2UIdw/V9cin+X4S PiCRsJg4Nd9LSrwtnnBrOv2Hgi30wvWcjfptPuDXPteYdN5YN6iAztZmIGTXMRQvYqfA esSQ== X-Gm-Message-State: AJIora/R0OlGnLZ388wuOR0ws6a47VCqp73eFtEzbCZJepv92xQKkE69 vFoP4Zck5RoJTfDBJDxH2nP6c/BVhHxkLiD0lE0/YUuJrPw= X-Google-Smtp-Source: AGRyM1t0mLJVXA+y97C6/3BVuPVLcZX+dxS8vpkvODkXDKwJpA9+LGlwMnDQ1TxPwULSwM9aLAXf9f9YK6CoT1lUJrA= X-Received: by 2002:a37:2756:0:b0:6ae:f7c2:ae4a with SMTP id n83-20020a372756000000b006aef7c2ae4amr11118233qkn.504.1656409082306; Tue, 28 Jun 2022 02:38:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Cl=C3=A9ment_Chigot?= Date: Tue, 28 Jun 2022 11:37:52 +0200 Message-ID: Subject: Re: [PATCH] windres: add quotes around preprocessor cmd if needed To: Jan Beulich Cc: binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 09:38:04 -0000 On Tue, Jun 28, 2022 at 11:00 AM Jan Beulich wrote: > > On 28.06.2022 09:35, Cl=C3=A9ment Chigot via Binutils wrote: > > This patch ensures that the gcc binary called by windres is quoted if > > needed. Otherwise, errors can occur if the gcc is under a folder having > > a name containing a space (eg "Program Files"). > > > > binutils/ > > * resrc.c (DEFAULT_PREPROCESSOR): Split into... > > (DEFAULT_PREPROCESSOR_CMD): that... > > (DEFAULT_PREPROCESSOR_ARGS): and that. > > (look_for_default): Add quotes around the command if needed. > > (read_rc_file): Adapt to new defines. > > Commenting is a little difficult without you providing the patch (also) > inline: IIRC, it should be done directly but the "=C3=A9" in my name makes the mailservers think my patches are binaries... Shouldn't you also (optionally) quote the pre-processor string > if that came into read_rc_file() as non-NULL? Everything else looks > okay to me. Yeah. I didn't run into this issue but looking at the code it should happen too. Thanks for pointing it out ! Cl=C3=A9ment