From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by sourceware.org (Postfix) with ESMTPS id 041CD3858C2F for ; Tue, 28 Jun 2022 07:47:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 041CD3858C2F Received: by mail-qk1-x736.google.com with SMTP id n10so5604930qkn.10 for ; Tue, 28 Jun 2022 00:47:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=NwwAI2FpWiOBUqyewum2s2xkpc0IKgGB8f9hXZq3fmU=; b=Mjf77eiDUXBzM1LLwzVJ0vopLmxpQmx0Z99s9ho31wf7h9EfYfqB2ED4RFxrqHiedi kEbF3f7xyfOMsqTKRWZ4LOfhmrug62Ed02Eqb23vv+TEMjJA2HSm+cVLDpiJGOYJdZWy NX8NcetzKmN3e7lp4fFMQl1F/GVLZzvaP//JqhdKkzTxPHldRELy27rwmM7skQL9sCj4 jT7eaSdotcACVVxczy2Y6y0xxVIX9JDoBHfV2JrPsBqHFKf1B40VaBCxrFSD4y0Yy0UX uDCy1O9I/Yk7Hm2kSNlk4PYN63rU3+/D9VEIc5r+BwVfVO+QikG+yV/qagrkVc4dpqa1 77mA== X-Gm-Message-State: AJIora+gRveGnE1iieOARqXrPEKbXSQByA+0VOncQzLlHwz5ZhDYrRXm 6v6qACJ5P9apBWe6QGqtHIAGaVLJ0C/2LXni+jAgl7Od+odzkg== X-Google-Smtp-Source: AGRyM1vWCDvFetsFmPhZ3pdzAicWMlXSOOVQuOkWWijlmwyU5OnP7688eHUd2h/a1Aumgnl+sbCtqrZJOg2UxS2IZao= X-Received: by 2002:a05:620a:d8c:b0:6a7:91a4:2669 with SMTP id q12-20020a05620a0d8c00b006a791a42669mr10657234qkl.269.1656402449420; Tue, 28 Jun 2022 00:47:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Cl=C3=A9ment_Chigot?= Date: Tue, 28 Jun 2022 09:47:19 +0200 Message-ID: Subject: Re: [PATCH] bfd: handle codepage when opening files on MinGW To: Nick Clifton , binutils@sourceware.org Content-Type: multipart/mixed; boundary="0000000000009aaec805e27d3f43" X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 07:47:31 -0000 --0000000000009aaec805e27d3f43 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2022 at 9:27 AM Cl=C3=A9ment Chigot wr= ote: > > Hi Nick, > > A few days ago, I've tried to open > https://sourceware.org/bugzilla/show_bug.cgi?id=3D25713 > again because the new handling of Windows filename is triggering > issues for GNAT under MinGW. > > We've made the following changes attached. We aren't sure this > is the best solution, but it seems to work fine and it's what MinGW is > using internally. > If you find such a patch ok, I guess it would be logical to merge it > for 2.39. Oops, I've pushed a patch which was a bit old and doesn't apply anymore... This version is better. Sorry for the noise.. Thanks Cl=C3=A9ment --0000000000009aaec805e27d3f43 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-bfd-handle-codepage-when-opening-files-on-MinGW.patch" Content-Disposition: attachment; filename="0001-bfd-handle-codepage-when-opening-files-on-MinGW.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4xv7nlq0 RnJvbSAwMDRkMmI1MTQ2OTFjOWUzMzQ5ZDlkMTY4MjRjZTc2NGUwOTNjZjE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Q2w9QzM9QTltZW50PTIwQ2hpZ290Pz0gPGNo aWdvdEBhZGFjb3JlLmNvbT4KRGF0ZTogVHVlLCAyOCBKdW4gMjAyMiAwOTo0MjoxMiArMDIwMApT dWJqZWN0OiBbUEFUQ0hdIGJmZDogaGFuZGxlIGNvZGVwYWdlIHdoZW4gb3BlbmluZyBmaWxlcyBv biBNaW5HVwoKRXZlbiBpZiBNUyBkb2NzIHNheSB0aGF0IENQX1VURjggc2hvdWxkIGFsd2F5cyBi ZSB1c2VkIG9uIG5ld2VyCmFwcGxpY2F0aW9ucywgZm9yY2luZyBpdCBtaWdodCBwcm9kdWNlIHVu ZGVmaW5lZCBmaWxlbmFtZSBpZiB0aGUKZW5jb2RpbmcgaXNuJ3QgVVRGLTguCk1pbkdXIHNlZW1z IHRvIGNhbGwgX19fbGNfY29kZXBhZ2VfZnVuYygpIGluIG9yZGVyIHRvIHJldHJpZXZlIHRoZQpj dXJyZW50IHRocmVhZCBjb2RlcGFnZS4KCmJmZC9DaGFuZ2VMb2c6CgogICAgICAgICogYmZkaW8u YyAoX2JmZF9yZWFsX2ZvcGVuKTogUmV0cmlldmUgY29kZXBhZ2Ugd2l0aAogICAgICAgIF9fX2xj X2NvZGVwYWdlX2Z1bmMoKSBvbiBNaW5HVy4KLS0tCiBiZmQvYmZkaW8uYyB8IDEyICsrKysrKysr Ky0tLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9iZmQvYmZkaW8uYyBiL2JmZC9iZmRpby5jCmluZGV4IGRjOGQzOTE2NTA5Li5h N2M3ZDViZDM2MyAxMDA2NDQKLS0tIGEvYmZkL2JmZGlvLmMKKysrIGIvYmZkL2JmZGlvLmMKQEAg LTI4LDYgKzI4LDcgQEAKICNpbmNsdWRlICJhb3V0L2FyLmgiCiAjaWYgZGVmaW5lZCAoX1dJTjMy KQogI2luY2x1ZGUgPHdpbmRvd3MuaD4KKyNpbmNsdWRlIDxsb2NhbGUuaD4KICNlbmRpZgogCiAj aWZuZGVmIFNfSVhVU1IKQEAgLTEyMCwxNSArMTIxLDIwIEBAIF9iZmRfcmVhbF9mb3BlbiAoY29u c3QgY2hhciAqZmlsZW5hbWUsIGNvbnN0IGNoYXIgKm1vZGVzKQogICAgd2NoYXJfdCAqKiAgICAg bHBGaWxlUGFydCA9IHtOVUxMfTsKICAgIGNvbnN0IHdjaGFyX3QgIHByZWZpeFtdID0gTCJcXFxc P1xcIjsKICAgIGNvbnN0IHNpemVfdCAgIHBhcnRQYXRoTGVuID0gc3RybGVuIChmaWxlbmFtZSkg KyAxOworI2lmZGVmIF9fTUlOR1czMl9fCisgICBjb25zdCB1bnNpZ25lZCBpbnQgY3AgPSBfX19s Y19jb2RlcGFnZV9mdW5jKCk7CisjZWxzZQorICAgY29uc3QgdW5zaWduZWQgaW50IGNwID0gQ1Bf VVRGODsKKyNlbmRpZgogCiAgICAvKiBDb252ZXJ0aW5nIHRoZSBwYXJ0aWFsIHBhdGggZnJvbSBh c2NpaSB0byB1bmljb2RlLgogICAgICAgMSkgR2V0IHRoZSBsZW5ndGg6IENhbGxpbmcgd2l0aCBs cFdpZGVDaGFyU3RyIHNldCB0byBudWxsIHJldHVybnMgdGhlIGxlbmd0aC4KICAgICAgIDIpIENv bnZlcnQgdGhlIHN0cmluZzogQ2FsbGluZyB3aXRoIGNiTXVsdGlCeXRlIHNldCB0byAtMSBpbmNs dWRlcyB0aGUgdGVybWluYXRpbmcgbnVsbC4gICovCi0gICBzaXplX3QgICAgICAgICBwYXJ0UGF0 aFdTaXplID0gTXVsdGlCeXRlVG9XaWRlQ2hhciAoQ1BfVVRGOCwgMCwgZmlsZW5hbWUsIC0xLCBO VUxMLCAwKTsKKyAgIHNpemVfdCAgICAgICAgIHBhcnRQYXRoV1NpemUgPSBNdWx0aUJ5dGVUb1dp ZGVDaGFyIChjcCwgMCwgZmlsZW5hbWUsIC0xLCBOVUxMLCAwKTsKICAgIHdjaGFyX3QgKiAgICAg IHBhcnRQYXRoID0gY2FsbG9jIChwYXJ0UGF0aFdTaXplLCBzaXplb2Yod2NoYXJfdCkpOwogICAg c2l6ZV90ICAgICAgICAgaXg7CiAKLSAgIE11bHRpQnl0ZVRvV2lkZUNoYXIgKENQX1VURjgsIDAs IGZpbGVuYW1lLCAtMSwgcGFydFBhdGgsIHBhcnRQYXRoV1NpemUpOworICAgTXVsdGlCeXRlVG9X aWRlQ2hhciAoY3AsIDAsIGZpbGVuYW1lLCAtMSwgcGFydFBhdGgsIHBhcnRQYXRoV1NpemUpOwog CiAgICAvKiBDb252ZXJ0IGFueSBVTklYIHN0eWxlIHBhdGggc2VwYXJhdG9ycyBpbnRvIHRoZSBE T1MgaS5lLiBiYWNrc2xhc2ggc2VwYXJhdG9yLiAgKi8KICAgIGZvciAoaXggPSAwOyBpeCA8IHBh cnRQYXRoTGVuOyBpeCsrKQpAQCAtMTUyLDcgKzE1OCw3IEBAIF9iZmRfcmVhbF9mb3BlbiAoY29u c3QgY2hhciAqZmlsZW5hbWUsIGNvbnN0IGNoYXIgKm1vZGVzKQogICAgLyogSXQgaXMgbm9uLXN0 YW5kYXJkIGZvciBtb2RlcyB0byBleGNlZWQgMTYgY2hhcmFjdGVycy4gICovCiAgICB3Y2hhcl90 ICAgIG1vZGVzV1sxNl07CiAKLSAgIE11bHRpQnl0ZVRvV2lkZUNoYXIgKENQX1VURjgsIDAsIG1v ZGVzLCAtMSwgbW9kZXNXLCBzaXplb2YobW9kZXNXKSk7CisgICBNdWx0aUJ5dGVUb1dpZGVDaGFy IChjcCwgMCwgbW9kZXMsIC0xLCBtb2Rlc1csIHNpemVvZihtb2Rlc1cpKTsKIAogICAgRklMRSAq ICAgICBmaWxlID0gX3dmb3BlbiAoZnVsbFBhdGgsIG1vZGVzVyk7CiAgICBmcmVlIChmdWxsUGF0 aCk7Ci0tIAoyLjI1LjEKCg== --0000000000009aaec805e27d3f43--