From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id E04D63858C83 for ; Thu, 20 Apr 2023 09:22:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E04D63858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-63b4bf2d74aso687022b3a.2 for ; Thu, 20 Apr 2023 02:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1681982566; x=1684574566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AkaKi608zBYQA+9TTRNNhW2gKta/8N8BNv6hmeMbPqw=; b=bddwlyqDAoe53WvE2qRahRhfEGx6IlsPYleU43MVzJ/h/hXQl9/uD8eN4bBQe/W9Td dxh9fk6Oa56IEBYmpiOkEO1f6jAmJWqcqIRq52/XKbm3QyR9W4YNpsZ88VA379EVtaHT r7bSjdhZ1UkRmrMwU+ZlZ6R+OPOwv4LU2W9L0NDUJG4Gl4OBSdLbavI7tVPZRs9d2XfP 35AlqXZ4++nLomjHB+gbIbm/80AsTMefWN5cwrkwXUj6n8s/6mbcCsgKDBzj4PjZgvgu 42xWNijOrBrCj2rmlalhcNCHszIcuXo7NWz79he+VFLl3TdcM+7IVsjbm1NXZL3Ipb28 VT4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681982566; x=1684574566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AkaKi608zBYQA+9TTRNNhW2gKta/8N8BNv6hmeMbPqw=; b=cedU6+pybLlBJ7OavjJ4BXeD2nG3PLpj9o10zWzwT8hOYFk2cuznYhfJbhCF42DHMN lxZLPAlBJDhaYTxBVp2bZkOkg+RgbtEwmknVEEI78JU7znX9CiHp/spI2KcPPNeXKDKF WoebUf4B+rdDd2pLKg30zStg/juQ1oBfiHGoMor8LfaUlYzD8vtctsxR48pTtoF4x9ZS KLJgK11daKMR5ukdpav5geZxLLjXAoCphNuFlxtgLdaBuT5PYg/O5zVbRfg+fwpNqgfH uAvCxk9nPmmO+uaplLv1P/KqYPzE56JTIsRGDFDr3vsB1VcNYhnGyrT9YB/ecO0wz/QB 8nfg== X-Gm-Message-State: AAQBX9dHjDUm+V40NL+cvdUfZ43Dbtc6YWsuBdCXndxTUPzPxp8DsHzX t/R+fOXplhIo3z9Yp3fObsQ8fX3t1gdK2Regw8kPog== X-Google-Smtp-Source: AKy350Y7XjLLJ0qMutimhynm1KjZz014b7ii1JSM6GN0L85t/oRuGm0q6JzCypO3p4TGoV9ZQ+QedhGPCDVZKWv1RVM= X-Received: by 2002:a05:6a20:4321:b0:ec:713f:3cb2 with SMTP id h33-20020a056a20432100b000ec713f3cb2mr1658616pzk.53.1681982566477; Thu, 20 Apr 2023 02:22:46 -0700 (PDT) MIME-Version: 1.0 References: <2b0ca132-9d85-86a8-8b91-828fa66881b8@suse.com> <15454510-ffe4-7afa-6151-f918983769a5@suse.com> <5e80c8bc-07da-fe6a-c162-ba830f56aa49@suse.com> In-Reply-To: <5e80c8bc-07da-fe6a-c162-ba830f56aa49@suse.com> From: =?UTF-8?Q?Cl=C3=A9ment_Chigot?= Date: Thu, 20 Apr 2023 11:22:35 +0200 Message-ID: Subject: Re: [PATCH v2 13/14] x86: convert testcases to use .insn To: Jan Beulich Cc: Binutils , "H.J. Lu" , "Jiang, Haochen" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 20, 2023 at 11:19=E2=80=AFAM Jan Beulich wr= ote: > > On 20.04.2023 11:09, Cl=C3=A9ment Chigot wrote: > > On Thu, Apr 20, 2023 at 11:01=E2=80=AFAM Jan Beulich wrote: > >> > >> On 20.04.2023 10:56, Cl=C3=A9ment Chigot wrote: > >>>> --- a/gas/testsuite/gas/i386/x86-64-opcode.s > >>>> +++ b/gas/testsuite/gas/i386/x86-64-opcode.s > >>>> @@ -458,16 +458,16 @@ > >>>> int3 > >>>> int $0x90 > >>>> > >>>> - .byte 0xf6, 0xc9, 0x01 > >>>> - .byte 0x66, 0xf7, 0xc9, 0x02, 0x00 > >>>> - .byte 0xf7, 0xc9, 0x04, 0x00, 0x00, 0x00 > >>>> - .byte 0x48, 0xf7, 0xc9, 0x08, 0x00, 0x00, 0x00 > >>>> - .byte 0xc0, 0xf0, 0x02 > >>>> - .byte 0xc1, 0xf0, 0x01 > >>>> - .byte 0x48, 0xc1, 0xf0, 0x01 > >>>> - .byte 0xd0, 0xf0 > >>>> - .byte 0xd1, 0xf0 > >>>> - .byte 0x48, 0xd1, 0xf0 > >>>> - .byte 0xd2, 0xf0 > >>>> - .byte 0xd3, 0xf0 > >>>> - .byte 0x48, 0xd3, 0xf0 > >>>> + .insn 0xf6/1, $1, %cl > >>>> + .insn 0xf7/1, $2{:u16}, %cx > >>>> + .insn 0xf7/1, $4{:u32}, %ecx > >>>> + .insn 0xf7/1, $8{:s32}, %rcx > >>>> + .insn 0xc0/6, $2, %al > >>>> + .insn 0xc1/6, $1, %eax > >>>> + .insn 0xc1/6, $1, %rax > >>>> + .insn 0xd0/6, %al > >>>> + .insn 0xd1/6, %eax > >>>> + .insn 0xd1/6, %rax > >>>> + .insn 0xd2/6, %al > >>>> + .insn 0xd3/6, %eax > >>>> + .insn 0xd3/6, %rax > >>> > >>> The test is failing on my side when building with --target=3Dx86_64-e= lf. > >>> I'm not sure what's wrong yet but gas seems to ignore everything afte= r "/": > >>> | $ ../../binutils/objdump -drw tmpdir/x86-64-opcode.o > >>> | ... > >>> | 4ea: f6 f7 div %bh > >>> | 4ec: f7 f7 div %edi > >>> | 4ee: c0 c1 c1 rol $0xc1,%cl > >>> | 4f1: d0 d1 rcl %cl > >>> | 4f3: d1 d2 rcl %edx > >>> | 4f5: d3 d3 rcl %cl,%ebx > >> > >> Right, and I think I did address all of these issues (there were more = than > >> just here) in what was committed (and in fact already in v2), by passi= ng > >> --divide to as. Can you confirm --divide does not take the intended ef= fect > >> in that case? > > > > --divide is not passed to x86_64-opcode test. > > Well, you continue to supply ambiguous information up to here; it only > becomes clear ... > > > But adding it resolves the issue: > > | $ ../as-new --x32 --divide -J -o tmpdir/x86-64-opcode.o > > ... here that what you mean is the ilp32/x86-64-opcode test (which is a > clone of the x86-64-opcode one). So yes, I did overlook the need to add > --divide there as well. Oh yeah my bad. This is indeed ilp32 version of the test: FAIL: x86-64 (ILP32) opcode Sorry about the confusion by not stating it earlier :(